From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC5DC433DF for ; Fri, 31 Jul 2020 08:10:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B79FF20829 for ; Fri, 31 Jul 2020 08:10:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YIxUFhDL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="fLOANyb1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B79FF20829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EvYbuOII8L9lHVKDRrQS8Fuy8mB+tjKgG8/tLKHOmYY=; b=YIxUFhDLLyrhGjoGBHRpvA+lu xLV+Y1I/Gu7Cd4ekRH6E+1Zu/ffsEfcgzJZyKJsCIFbOJEniJCted08+dIfXeXt7R+huO7AE3jBUh Vfrk0EocL0tzX3r5N/SK8yiaA3bk8var9RBdsrmtkEJNHIxE1D+4/TCWIVbrn36aBNAsLebcA7c7u YJRYKz9eBtnsg3FfTm67wT0lMcJB6Hy3gdvOqd99zoXPvdTi6AXhAB7jHDsmdA3uPI6a+nD6NkdjO p4koTlbkLMGW5RURYEdUnw6QjvItVKOtaKhj59QXC6s6aUa0Pljk6+VvgWMFLXL/eCvZK4bAjEXDJ AUxj109fA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Q5n-0008VN-O7; Fri, 31 Jul 2020 08:08:39 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Q5h-0008SM-C0 for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 08:08:35 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06V82cGL009807; Fri, 31 Jul 2020 10:08:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=duijA74hn6cm6wjqcWG4BwM4Dv82QSirbDAGiYHEvbM=; b=fLOANyb1hL4UcnLzmtSnyAC+bCnklq28UwMCQw8LGYbSEWnrtUkfqzOPhaN8eZkthTWb IdIi7n8B3stKbTXiKUcL8O0Z3PxVPeojF0kYa83H21mzMk9XArRCq3FcfOavqFSYCi6d 1UpqDWbopf03RKVYE90xjiVmM2Z6Y8xScv1v4552RAOH/tcw/4ahs92nBYqClxdvX15d hI4edFbJSPeTjfhHfrQc2j5n0VUs3iKkM/HxyyS8Z1xKNMMgDDTQY1NOHFdMQTxir9UW dW8prnb+XWqykVIJQb7kpgQG5QEhJxhGRJuLfcrZ9+VV99ffw9gCd5gu2MCU+HWJxHuw Sg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 32ga72cdk3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Jul 2020 10:08:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 67CFB10002A; Fri, 31 Jul 2020 10:08:14 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 30CAB21EB47; Fri, 31 Jul 2020 10:08:14 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.51) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 31 Jul 2020 10:08:13 +0200 Subject: Re: [PATCH v5 3/3] ARM: dts: stm32: add initial support for stm32mp157-odyssey board To: Ahmad Fatoum , Marcin Sloniewski , References: <20200724145107.35772-1-marcin.sloniewski@gmail.com> <20200724145107.35772-3-marcin.sloniewski@gmail.com> <4a160bb6-bc73-0a18-86c4-decd985104ad@pengutronix.de> From: Alexandre Torgue Message-ID: <9ab39ee2-d6db-73f5-5914-befd22a9bcfb@st.com> Date: Fri, 31 Jul 2020 10:08:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <4a160bb6-bc73-0a18-86c4-decd985104ad@pengutronix.de> Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG7NODE2.st.com (10.75.127.20) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-31_02:2020-07-31, 2020-07-31 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_040833_835410_00EC9059 X-CRM114-Status: GOOD ( 23.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, stephan@gerhold.net, mani@kernel.org, heiko.stuebner@theobroma-systems.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, lkundrak@v3.sk, devicetree@vger.kernel.org, robh+dt@kernel.org, broonie@kernel.org, mcoquelin.stm32@gmail.com, allen.chen@ite.com.tw, sam@ravnborg.org, linux-stm32@st-md-mailman.stormreply.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ... >> + >> +&sdmmc2_d47_pins_a { >> + pins { >> + pinmux = , /* SDMMC2_D4 */ >> + , /* SDMMC2_D5 */ >> + , /* SDMMC2_D6 */ >> + ; /* SDMMC2_D7 */ >> + }; >> +}; >> + >> +&sdmmc2_d47_sleep_pins_a { >> + pins { >> + pinmux = , /* SDMMC2_D4 */ >> + , /* SDMMC2_D5 */ >> + , /* SDMMC2_D6 */ >> + ; /* SDMMC2_D7 */ >> + }; >> +}; > > When I sent out the device trees for the lxa-mc1, Alex wanted > all pinctrl nodes to be collected in stm32mp15-pinctrl.dtsi. > > @Alex, should this be done here as well? Hi, Sorry for the late answer. Yes it has to be defined in stm32mp15-pinctrl.dtsi. If at the end there are too much definitions for the same pins or group of pins, I'll find a smarter way for pin definition, but currently all pin definitions have to be done in stm32mp15-pinctrl.dtsi. cheers Alex > >> + >> +&sdmmc2 { >> + pinctrl-names = "default", "opendrain", "sleep"; >> + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>; >> + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>; >> + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>; >> + non-removable; >> + no-sd; >> + no-sdio; >> + st,neg-edge; >> + bus-width = <8>; >> + vmmc-supply = <&v3v3>; >> + vqmmc-supply = <&v3v3>; >> + mmc-ddr-3_3v; >> + status = "okay"; >> +}; >> + >> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts >> new file mode 100644 >> index 000000000000..619243807842 >> --- /dev/null >> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts >> @@ -0,0 +1,73 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) >> +/* >> + * Copyright (C) 2020 Marcin Sloniewski . >> + */ >> + >> +/dts-v1/; >> + >> +#include "stm32mp157c-odyssey-som.dtsi" >> + >> +/ { >> + model = "Seeed Studio Odyssey-STM32MP157C Board"; >> + compatible = "seeed,stm32mp157c-odyssey", >> + "seeed,stm32mp157c-odyssey-som", "st,stm32mp157"; >> + >> + aliases { >> + ethernet0 = ðernet0; >> + serial0 = &uart4; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> +}; >> + >> +ðernet0 { >> + status = "okay"; >> + pinctrl-0 = <ðernet0_rgmii_pins_a>; >> + pinctrl-1 = <ðernet0_rgmii_sleep_pins_a>; >> + pinctrl-names = "default", "sleep"; >> + phy-mode = "rgmii-id"; >> + max-speed = <1000>; >> + phy-handle = <&phy0>; >> + >> + mdio0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "snps,dwmac-mdio"; >> + phy0: ethernet-phy@7 { /* KSZ9031RN */ >> + reg = <7>; > > reset-gpios is missing. I see that the vendor u-boot does it > in board code, but you don't want Linux to depend on this. > >> + }; >> + }; >> +}; >> + >> +&i2c1 { >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&i2c1_pins_a>; >> + pinctrl-1 = <&i2c1_sleep_pins_a>; >> + i2c-scl-rising-time-ns = <100>; >> + i2c-scl-falling-time-ns = <7>; >> + status = "okay"; >> + /delete-property/dmas; >> + /delete-property/dma-names; >> +}; >> + >> +&sdmmc1 { >> + pinctrl-names = "default", "opendrain", "sleep"; >> + pinctrl-0 = <&sdmmc1_b4_pins_a>; >> + pinctrl-1 = <&sdmmc1_b4_od_pins_a>; >> + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; >> + cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; >> + disable-wp; >> + st,neg-edge; >> + bus-width = <4>; >> + vmmc-supply = <&v3v3>; >> + status = "okay"; >> +}; >> + >> +&uart4 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart4_pins_a>; >> + status = "okay"; >> +}; >> + >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel