Re: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/11/2025 10:54, Jacky Chou wrote:
> Hi Krzysztof
> 
> Thank you for your reply.
> 
>>> Create the new compatibles to identify AST2600 MAC0/1 and MAC3/4.
>>> Add conditional schema constraints for Aspeed AST2600 MAC controllers:
>>> - For "aspeed,ast2600-mac01", require rx/tx-internal-delay-ps properties
>>>   with 45ps step.
>>> - For "aspeed,ast2600-mac23", require rx/tx-internal-delay-ps properties
>>>   with 250ps step.
>>
>> That difference does not justify different compatibles. Basically you said they
>> have same programming model, just different hardware characteristics, so
>> same compatible.
>>
> 
> This change was originally based on feedback from a previous review discussion.
> At that time, another reviewer suggested introducing separate compatibles for 
> MAC0/1 and MAC2/3 on AST2600, since the delay characteristics differ and they 
> might not be fully compatible.


Your commit msg does not provide enough of rationale for that.
Difference in DTS properties is rather a counter argument for having
separate compatibles. That's why you have these properties - to mark the
difference.

Best regards,
Krzysztof