From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Alex Guo <alexguo1023@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: brcmstb_gisb: Check required IRQ lookup results
Date: Thu, 19 Nov 2026 14:58:35 -0800 [thread overview]
Message-ID: <9b20b5f9-5568-4ea2-abf2-f609d134cb92@broadcom.com> (raw)
In-Reply-To: <CAAi4Z-fjR27iAXjb6VpovSVVObqLcLgurzuhCkDFqgGafyAaDw@mail.gmail.com>
On 11/14/26 06:22, Alex Guo wrote:
> platform_get_irq() can return a negative error code for the timeout
> or target abort interrupt. Passing it to devm_request_irq() can
> replace the lookup error with -EINVAL.
>
> Check both lookup results and return the original error before
> requesting either interrupt.
>
> A similar issue was fixed in commit 47c3e06ed95a
> ("spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe").
>
> Fixes: 44127b771d9c ("bus: add Broadcom GISB bus arbiter timeout/error handler")
> Signed-off-by: Alex Guo <alexguo1023@gmail.com>
> ---
> Build-tested the affected driver object with Clang 18 for ARM
> (multi_v7_defconfig). No hardware test was performed.
The patch is correct but I am not sure which tree you applied this to
because in my tree (drivers/next) we have not moved to
devm_kzalloc_obj() yet.
--
Florian
next prev parent reply other threads:[~2026-11-19 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 14:22 [PATCH] bus: brcmstb_gisb: Check required IRQ lookup results Alex Guo
2026-11-19 22:58 ` Florian Fainelli [this message]
2026-11-19 23:01 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b20b5f9-5568-4ea2-abf2-f609d134cb92@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=alexguo1023@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox