From: Jun Guo <jun.guo@cixtech.com>
To: Robin Murphy <robin.murphy@arm.com>,
peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
ychuang3@nuvoton.com, schung@nuvoton.com
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dma: arm-dma350: add support for shared interrupt mode
Date: Mon, 17 Nov 2025 19:57:46 +0800 [thread overview]
Message-ID: <9b3bc85f-aa32-46e3-9e95-81490ddacaa0@cixtech.com> (raw)
In-Reply-To: <00586912-661e-4092-a69d-87defe26db59@arm.com>
On 11/17/2025 7:32 PM, Robin Murphy wrote:
> On 2025-11-17 1:59 am, Jun Guo wrote:
>> - The arm dma350 controller's hardware implementation varies: some
>> designs dedicate a separate interrupt line for each channel, while
>> others have all channels sharing a single interrupt.This patch adds
>> support for the hardware design where all DMA channels share a
>> single interrupt.
>
> We already request the channel interrupts as shared, precisely because
> they could well end up muxed to the same physical interrupt line. I
> missed that the dedicated combined interrupt output had its own separate
> enable, but for that we may as well just set INTREN_ANYCHINTR_EN
> unconditionally - the rest of this seems pointless.
I'm not entirely sure if enabling the INTREN_ANYCHINTR_EN bit to 1 would
affect the current default scenario where each channel is assigned its
own interrupt. The hardware design of the chip I'm currently working
with does not support testing the scenario of individual interrupts per
channel. If it doesn't cause any issues, I will change it to an
unconditional configuration.
next prev parent reply other threads:[~2025-11-17 11:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 1:59 [PATCH 0/3] dmaengine: arm-dma350: add support for shared interrupt mode Jun Guo
2025-11-17 1:59 ` [PATCH 1/3] dt-bindings: dma: arm-dma350: update DT binding docs Jun Guo
2025-11-17 6:11 ` Krzysztof Kozlowski
2025-11-17 7:07 ` Jun Guo
2025-11-17 7:11 ` Krzysztof Kozlowski
2025-11-17 7:13 ` Krzysztof Kozlowski
2025-11-17 12:51 ` Jun Guo
2025-11-17 13:29 ` Krzysztof Kozlowski
2025-11-18 1:37 ` Jun Guo
2025-11-17 1:59 ` [PATCH 2/3] dma: arm-dma350: add support for shared interrupt mode Jun Guo
2025-11-17 6:13 ` Krzysztof Kozlowski
2025-11-17 7:18 ` Jun Guo
2025-11-17 11:37 ` Jun Guo
2025-11-17 11:44 ` Krzysztof Kozlowski
2025-11-17 11:52 ` Jun Guo
2025-11-17 11:32 ` Robin Murphy
2025-11-17 11:57 ` Jun Guo [this message]
2025-11-17 1:59 ` [PATCH 3/3] arm64: dts: cix: add DT nodes for DMA Jun Guo
2025-11-17 6:14 ` Krzysztof Kozlowski
2025-11-17 7:08 ` Jun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b3bc85f-aa32-46e3-9e95-81490ddacaa0@cixtech.com \
--to=jun.guo@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=schung@nuvoton.com \
--cc=vkoul@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).