From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B20CEB64DD for ; Mon, 7 Aug 2023 06:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lxhcXbcxJQtmwEO4fM4GOmz8vdp5P87vEBSBjcDY5cg=; b=F9YUcoTpN4Z07f dNNTcKBatrlyjwrzLon/KGZJjRiRJvkTSXiKGMgjZH9k7Q9ZrlMeu+PltNRGQSg4yHGu9i8GRioCi MvYufo7Bgqh31ZMBqq6bgmAoKemKJVX/w6mQHfA+dC/kG7FNdZ37smeo7QtYUebgpzBJhfcBdNBTL dQbaI2yWTcFFoZlpYYg+H3DMVuu4KMHFcjHm4GtlyissSu41iYLGA0fuk3qmqdZKPF+fIcT07OmBd jsY8uCw8HEZQsSzSOexRl9i3gaXtzbMWe4WlX1LnlOLxZHMMVFgchdaY00eyU+RvXdsSDlh6krXMI ve+y++rZma58QiP1We5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qStLh-00GEvt-1e; Mon, 07 Aug 2023 06:04:13 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qStLd-00GEvA-2I for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 06:04:11 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3776433N116671; Mon, 7 Aug 2023 01:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691388243; bh=z4xXCBW2WtWwhXULzwLLBfUTw1DeQ6YaU1rc1hGNsMM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=H6i5cuHpNmIwE2b9BL7o0AYuvMf3SHc35iLb6PpnpYkFt2KUfBk8NwWSvjMXH5Dlq 5Re0a3xHNh50l05T0bu1sDZ8Gn9fii9r3KfuuuyTRVuPbBwNPnWUYEH+5vUcdfvjPt idlBtVAeBJT6E8La1GMYr1N8XRNBuJW2wrfeofb0= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 377643nt032478 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Aug 2023 01:04:03 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 7 Aug 2023 01:04:02 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 7 Aug 2023 01:04:02 -0500 Received: from [172.24.227.6] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37763wpp019706; Mon, 7 Aug 2023 01:03:58 -0500 Message-ID: <9b61e8a0-fec0-b33f-259c-c744aa5a88b9@ti.com> Date: Mon, 7 Aug 2023 11:33:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] arm64: dts: ti: k3-am62x-sk-common: Reserve 128MiB of global CMA Content-Language: en-US To: Nishanth Menon , CC: , , , , , , , , , , , References: <20230803111455.811339-1-devarsht@ti.com> <20230805193355.o657pwbq2w3tciui@vehicular> From: Devarsh Thakkar In-Reply-To: <20230805193355.o657pwbq2w3tciui@vehicular> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_230409_856003_5889171B X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, Thanks for the review. On 06/08/23 01:03, Nishanth Menon wrote: > On 16:44-20230803, Devarsh Thakkar wrote: >> Reserve 128MiB of global CMA which is also marked as re-usable >> so that OS can also use the same if peripheral drivers are not using the >> same. >> >> AM62x supports multimedia components such as GPU, dual Display and Camera. >> Assuming the worst-case scenario where all 3 are run in parallel below >> is the calculation : >> >> 1) OV5640 camera sensor supports 1920x1080 resolution >> -> 1920 width x 1080 height x 2 bytesperpixel x 8 buffers >> (default in yavta) : 32MiB >> >> 2) 1920x1200 Microtips LVDS panel supported >> -> 1920 width x 1080 height x 4 bytesperpixel x 2 buffers : >> 16 MiB >> >> 3) 1920x1080 HDMI display supported >> -> 1920 width x 1080 height x 4 bytesperpixel x 2 buffers : >> 15.82 MiB which is ~16 MiB >> >> 4) IMG GPU shares with display allocated buffers while rendering >> but in case some dedicated operation viz color conversion, >> keeping same window of ~16 MiB for GPU too. >> >> Total is 80 MiB and adding 32 MiB for other peripherals and extra >> 16 MiB to keep as buffer for fragmentation thus rounding total to 128 >> MiB. >> >> Signed-off-by: Devarsh Thakkar >> Acked-by: Darren Etheridge >> Signed-off-by: Vignesh Raghavendra >> --- > > I don't think this is right approach. There are other techniques > than having to do this (Andrew: please comment) and require drivers to > behave properly. Sorry but I did not understand clearly the disadvantage of this approach. Here we are reserving CMA and also marking it as re-usable so that in case driver is not using it OS can use that region. Also I see quite a few vendors already taking this approach : $grep -r cma-default arch/arm64/boot/dts arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts:276: linux,cma-default; arch/arm64/boot/dts/qcom/sc8280xp-crd.dts:222: linux,cma-default; arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts:201: linux,cma-default; arch/arm64/boot/dts/freescale/imx8ulp-evk.dts:32: linux,cma-default; arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi:198: linux,cma-default; arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi:48: linux,cma-default; arch/arm64/boot/dts/freescale/imx8dxl-evk.dts:50: linux,cma-default; arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi:24: linux,cma-default; arch/arm64/boot/dts/freescale/imx8mq-tqma8mq.dtsi:59: linux,cma-default; arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl.dtsi:46: linux,cma-default; arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts:28: linux,cma-default; arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts:67: linux,cma-default; arch/arm64/boot/dts/amlogic/meson-gx.dtsi:63: linux,cma-default; arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:121: linux,cma-default; arch/arm64/boot/dts/amlogic/meson-a1.dtsi:59: linux,cma-default; I am esp concerned since there are platforms based on > am62x and just 256MB DDR. > The file "k3-am62x-sk-common.dtsi" refers DDR memory size as 2Gb[1] and so I put CMA reservation in same file assuming all boards including this file have 2Gb. But if there are some boards having lesser DDR and including this k3-am62x-sk-common.dtsi and overriding memory node, I can put the CMA reservation node in board specific file i.e. k3-am625-sk.dts in V2. Kindly let me know if above is preferred approach. [1] https://gitlab.com/linux-kernel/linux-next/-/blob/next-20230807/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi?ref_type=tags#L33 Regards Devarsh >> arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >> index 34c8ffc553ec..9dd6e23ca9ca 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi >> @@ -47,6 +47,14 @@ ramoops@9ca00000 { >> pmsg-size = <0x8000>; >> }; >> >> + /* global cma region */ >> + linux,cma { >> + compatible = "shared-dma-pool"; >> + reusable; >> + size = <0x00 0x8000000>; >> + linux,cma-default; >> + }; >> + >> secure_tfa_ddr: tfa@9e780000 { >> reg = <0x00 0x9e780000 0x00 0x80000>; >> alignment = <0x1000>; >> -- >> 2.34.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel