From: Krzysztof Kozlowski <krzk@kernel.org>
To: Diogo Silva <diogompaissilva@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com,
Frank.Li@nxp.com, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8: Fix lvds0 device tree
Date: Tue, 17 Sep 2024 08:05:33 +0200 [thread overview]
Message-ID: <9b86de44-c80c-42d9-a0eb-d39b077ce8f8@kernel.org> (raw)
In-Reply-To: <CAJpoHp4Dija5jDDMZnqX_g5QpQWfYPjoHK-3orJsyxCQYv4N0Q@mail.gmail.com>
On 16/09/2024 22:47, Diogo Silva wrote:
> Hey,
>
> Sorry for the broken tag, will fix on a resend.
>
> As for the naming, if there is any reason for them to be named qm_* it's
> totally fine, I'll revert it and only touch the clock names. I changed them
It's just unnecessary.
> because comparing with lvds1, those ones do not contain the qm_ prefix and
> I don't see how this dtsi relates specifically to the imx8qm, since it is a
> imx8-ss... and not imx8qm-ss...
> I didn't quite get the question about the nodes. Could you elaborate? Thanks
>
Usually they have alphabetical order and your change does not look like
keeping it.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-09-17 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 20:02 [PATCH] arm64: dts: imx8: Fix lvds0 device tree Diogo Silva
2024-09-16 20:23 ` Krzysztof Kozlowski
2024-09-16 20:50 ` Diogo Silva
[not found] ` <CAJpoHp4Dija5jDDMZnqX_g5QpQWfYPjoHK-3orJsyxCQYv4N0Q@mail.gmail.com>
2024-09-17 6:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b86de44-c80c-42d9-a0eb-d39b077ce8f8@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diogompaissilva@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).