From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C898C55182 for ; Mon, 3 Aug 2026 17:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cSyyM7BUXIDF3kJhgyCmgOwoW98OlpC1I9i3DPZMz2s=; b=BoVhOqu71x/La+IonyFg7TDp9y eARJZbzmUl+PnEWJiMEJLa/z4WQx1t9AHT8GalrZcSksa4837j4C6Napi7H4biZ9GXk8AC9AKxq+8 BIdYGFCQjY+lXekL6lyRJKAYSP0gOvKWV6A/w0xuNqW+dqcD6vvMGos5Mh2KdgQr6muhnXA651IhZ ZgrS2IZitMaiEbhB/T5oMX3MesniqWiGwC242Wyf4RedEk8we3Z9K+lYBien/BGV5BRNHbNnK5NcA 5R5V21FgsjzZGTL9JH/PyS5LM45jzzNvM5LKl+s2u08fOdzZHwk+9gfNfr6joCRLDZyaZGdnbtnZ+ hWjOXojA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqwm7-00000000GS5-30cd; Mon, 03 Aug 2026 17:48:31 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqwm5-00000000GRG-1mFu; Mon, 03 Aug 2026 17:48:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=cSyyM7BUXIDF3kJhgyCmgOwoW98OlpC1I9i3DPZMz2s=; b=u1 kXI2+R12w43beaPSCbM1HCJtvorD9d3Ebq53sQZR3ik4voCij2lPlW5oXM+0wRshrRMCr87mcUHo7 XN23BeKdWZNVXSS4v3jExOreZBR9tOxH6d4xKQfMcUyCUx/18N/JTdJBnEYVUqcMnpK/q5TYssUsX zXFXTFEDjez0ehA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wqwlg-00Fn1q-LQ; Mon, 03 Aug 2026 19:48:04 +0200 Date: Mon, 3 Aug 2026 19:48:04 +0200 From: Andrew Lunn To: James Hilliard Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Richard Genoud , Maxime Ripard , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Heiner Kallweit , Russell King , Saravana Kannan , Lee Jones , Heiko Stuebner , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, mfd@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/21] net: phy: add X-Powers AC200 EPHY control driver Message-ID: <9b8be475-1fde-409c-a82e-be4b2e402650@lunn.ch> References: <20260802-submit-acx00-of-dynamic-v1-v1-0-0a53cd9e21cc@gmail.com> <20260802-submit-acx00-of-dynamic-v1-v1-10-0a53cd9e21cc@gmail.com> <05b1e6a2-725e-4b8e-8629-249637bbcb81@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_104829_462135_A684812E X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 03, 2026 at 10:09:01AM -0600, James Hilliard wrote: > On Mon, Aug 3, 2026 at 7:51 AM Andrew Lunn wrote: > > > > > +static int > > > +ac200_ephy_ctl_set_led_outputs(struct acx00_ephy_control *control, > > > + unsigned long outputs) > > > +{ > > > +} > > > > > +static int > > > +ac200_ephy_ctl_set_led_polarity(struct acx00_ephy_control *control, > > > + bool active_low) > > > +{ > > > +} > > > > I've not looked into the details, but these look like pinmux. Does > > this I2C device have a GPIO controller? Can these pins be used for > > other things than LEDs? Maybe you should be implementing a GPIO and > > pinmux driver. The Ethernet PHY driver can then just select the > > correct pinmux configuration. > > These do not appear to be GPIO or muxable pins. The AC200 > documentation describes them as three dedicated EPHY LED > outputs: link/activity, speed, and duplex. The bits in SYS_EPHY_CTL1 > enable those output pads, while EPHY_CTL provides their shared > polarity setting. I have not found any documented GPIO data > registers or alternative functions for these pins. So what i'm trying to do with both of these is make it look more like standard Linux building blocks. If that is not possible, i would actually put all this code into the PHY driver. You then have a regmap property to gain access to the I2C registers. Andrew