From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4C8CC25B78 for ; Wed, 15 May 2024 18:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E1JBDS/iVVVXCiWkRjkeTr7YVo45V/t0CP+K47EOIaU=; b=K4dQVaTBS2RfaJ ZZYZN+wQZCNuN682MWveJgH9QrujGf36oGlxdrkip3FFaOsPziL8Sz4RnvMCFa7IokuBpyl0TdTiV jV0zdOE7kGj0HSAh7FxNeuz920fi1Mesh8XKj737UGaSDo2bbf6EvbQ9yNojrRDqdzfCDY6/31Wir drP77PRIdXN/yjT6mncn7wV+TZwKTbzB8YU2H67KYtV2SMeg+zg1Fms4cgGi2kWarJAuTCcVApoza qVn/j+s3FSbjnx6Y02Uk8O6lXenIBKoPg0QJt5SkO0i+618OKPfdriwvMU/qsuJLp8Rv6q6O6NWQh P7M2kOFMCm9L6duVzRxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JPo-00000002YiK-1UpJ; Wed, 15 May 2024 18:31:48 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7JPl-00000002Yhc-1eBc for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 18:31:47 +0000 Received: from [10.137.186.190] (unknown [131.107.159.62]) by linux.microsoft.com (Postfix) with ESMTPSA id 34AC020B915A; Wed, 15 May 2024 11:31:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 34AC020B915A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1715797903; bh=82+zV7NnktZKrrYz3USZfplzcKttP0Idb0GycX7Cnns=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Tc3R7BFIR2JNViaO9qjq3uMvYmVM1AuZf2gw+k3NhgatKmiADz5GUQr/Eq9W1WBlL ZXrQASe7tJ9ID2ozV8S8j/EYA8Hw4l8d6prnBSoHJqPPMI/maKBH/REjqXQEALiFL4 BYGxZ6oMD949FeCXUzspRET6wJZbMOQE7S14v4Ag= Message-ID: <9bd0f136-40d0-460f-8d40-39f33511e3cf@linux.microsoft.com> Date: Wed, 15 May 2024 11:31:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT To: Michael Kelley , "arnd@arndb.de" , "bhelgaas@google.com" , "bp@alien8.de" , "catalin.marinas@arm.com" , "dave.hansen@linux.intel.com" , "decui@microsoft.com" , "haiyangz@microsoft.com" , "hpa@zytor.com" , "kw@linux.com" , "kys@microsoft.com" , "lenb@kernel.org" , "lpieralisi@kernel.org" , "mingo@redhat.com" , "rafael@kernel.org" , "robh@kernel.org" , "tglx@linutronix.de" , "wei.liu@kernel.org" , "will@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "x86@kernel.org" Cc: "ssengar@microsoft.com" , "sunilmut@microsoft.com" , "vdso@hexbites.dev" References: <20240514224508.212318-1-romank@linux.microsoft.com> <20240514224508.212318-7-romank@linux.microsoft.com> Content-Language: en-US From: Roman Kisel In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_113145_648852_7E226436 X-CRM114-Status: GOOD ( 29.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/15/2024 6:47 AM, Michael Kelley wrote: > From: Roman Kisel Sent: Tuesday, May 14, 2024 3:44 PM >> >> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration >> on arm64 thereby it won't be able to do that in the VTL mode where >> only DeviceTree can be used. > > That sentence seems a bit weird. How about: > > The hyperv-pci driver uses ACPI for MSI IRQ domain configuration on arm64. > It won't be able to do that in the VTL mode where only DeviceTree can be used. > Agreed, appreciate your wordsmithing :) >> >> Update the hyperv-pci driver to discover interrupt configuration >> via DeviceTree. > > "discover interrupt configuration"? I think that's a cut-and-paste error > from the previous patch. > Guilty as charged :) Will fix. >> >> Signed-off-by: Roman Kisel >> --- >> drivers/pci/controller/pci-hyperv.c | 13 ++++++++++--- >> include/linux/acpi.h | 9 +++++++++ >> 2 files changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c >> index 1eaffff40b8d..ccc2b54206f4 100644 >> --- a/drivers/pci/controller/pci-hyperv.c >> +++ b/drivers/pci/controller/pci-hyperv.c >> @@ -906,9 +906,16 @@ static int hv_pci_irqchip_init(void) >> * way to ensure that all the corresponding devices are also gone and >> * no interrupts will be generated. >> */ >> - hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, >> - fn, &hv_pci_domain_ops, >> - chip_data); >> + if (acpi_disabled) >> + hv_msi_gic_irq_domain = irq_domain_create_hierarchy( >> + irq_find_matching_fwnode(fn, DOMAIN_BUS_ANY), >> + 0, HV_PCI_MSI_SPI_NR, >> + fn, &hv_pci_domain_ops, >> + chip_data); > > Does the above really work? It seems doubtful to me that irq_find_matching_fwnode() > always finds the parent domain that you want. But I don't have a deep understanding > of how this works or is supposed to work, so I don't know for sure. > > If the above *does* actually work for all cases, then should it also work for the ACPI > case? Then you could avoid the messiness when acpi_irq_create_hierarchy() doesn't > exist. > Have not got a system to validate this on. Conceptually (at my level of ignorance) didn't look very off... Will use the "collapsed" version you're suggesting as the litmus test. >> + else >> + hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR, >> + fn, &hv_pci_domain_ops, >> + chip_data); >> >> if (!hv_msi_gic_irq_domain) { >> pr_err("Failed to create Hyper-V arm64 vPCI MSI IRQ domain\n"); > > I'm wondering if these are the only changes needed to make vPCI work on > arm64 with DeviceTree. The DMA coherence issue I mentioned in the previous patch > definitely affects vPCI devices, so it needs to be fully understood and verified to work > correctly. > Likely not all as the code is venturing into the new territory composed of the pieces never snapped in place together before. Will work on the previous patch to resolve as many concerns as possible. >> diff --git a/include/linux/acpi.h b/include/linux/acpi.h >> index b7165e52b3c6..498cbb2c40a1 100644 >> --- a/include/linux/acpi.h >> +++ b/include/linux/acpi.h >> @@ -1077,6 +1077,15 @@ static inline bool acpi_sleep_state_supported(u8 sleep_state) >> return false; >> } >> >> +static inline struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags, >> + unsigned int size, >> + struct fwnode_handle *fwnode, >> + const struct irq_domain_ops *ops, >> + void *host_data) >> +{ >> + return NULL; >> +} >> + >> #endif /* !CONFIG_ACPI */ >> >> extern void arch_post_acpi_subsys_init(void); >> -- >> 2.45.0 >> -- Thank you, Roman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel