From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CDF4C5B572 for ; Thu, 13 Aug 2026 17:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Subject: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XFj6VBuvNlnLerahn+Ew2ADvQ1GLzQ4tJ+S+S2qSCZ0=; b=bbb/cy9cRSLoU2 8k7U0zV29DR87t0316pK/K/PQh2oqI6T3hhu3/Lv9K89v7zMPMcyzbnJmQT8zdTijailK+sCuk9j4 wrmvVfpHBZXOJHKBGpsDdV+eEKGcv0ZyteRZReHQ1jJ7PHLBcofn8i6zgKKBHfErgLje2D708U0SC qTzqtAtzIXtUenQC4xtgSTQ/XR79EZSxZY4y3EhW4B+/Gk9gVGHxoeRAaxBUAfoBL23C8pmZy6UqR vv+m+t+V6iwywhbbzCp4/MzYJum29Ku5QmBb3XMauVql0q6tx+2Laa44K1UBF+k/lS/HXco4Uaw7D ppj/q1B5xY/m/rYKydlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuZKL-00000001Izc-3nlo; Thu, 13 Aug 2026 17:34:49 +0000 Received: from ale.deltatee.com ([204.191.154.188]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuZKJ-00000001IyH-0oMQ; Thu, 13 Aug 2026 17:34:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=XFj6VBuvNlnLerahn+Ew2ADvQ1GLzQ4tJ+S+S2qSCZ0=; b=L5+ZsqOtNkaXdXhMeUmtDlxXCG 4+nWgHrJ/6YJ7a7wgq9ZARZicz03xxQhv5a2V1xFjOPSAstssr5ix0VfMjKwL/MfYk69qSVdYKa8V 7EIhycg37CLe4uJq27WaATd/QsdIRjTdsbnIXr9jGYu25sgB50xhxmWVTIlFhp1xha4mAHmrQ9ioR In/HlwNTgm+4Tm3c68Xl5hpr7vZPzq6XUCRoM84rgn8q+bD/2msGM9FUqy43Xu708/xoa9lTnNDfV AZ/h2VOCknwxnLug35RZsU//sokoMiM5WhtQv5m7s7DHnjngbdfaHNASnF1F2SsosrLxUXDsFByBY ePAS7V1A==; Received: from s0106ac1f6bb1ecac.cg.shawcable.net ([96.51.150.74] helo=[10.0.33.8]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wuZK6-00000002RIj-2N9e; Thu, 13 Aug 2026 11:34:35 -0600 Message-ID: <9bdb074f-da65-41a9-b7bc-790ecab27e60@deltatee.com> Date: Thu, 13 Aug 2026 11:33:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Frank.Li@oss.nxp.com, Jacky Huang , Shan-Chun Hung , Vinod Koul , Frank Li , Paul Cercueil , Eugeniy Paltsev , Andy Shevchenko , Binbin Zhou , Patrice Chotard , =?UTF-8?Q?Am=C3=A9lie_Delaunay?= , Maxime Coquelin , Alexandre Torgue , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Thierry Reding , Jonathan Hunter , Ludovic Desroches , Viresh Kumar , Keguang Zhang , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kelvin Cao , Laxman Dewangan , Vignesh Raghavendra Cc: linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-sunxi@lists.linux.dev, imx@lists.linux.dev, Frank Li References: <20260812-dma-chan_dev-rename-v1-0-a67131f7d5c2@nxp.com> <20260812-dma-chan_dev-rename-v1-2-a67131f7d5c2@nxp.com> Content-Language: en-CA From: Logan Gunthorpe In-Reply-To: <20260812-dma-chan_dev-rename-v1-2-a67131f7d5c2@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 96.51.150.74 X-SA-Exim-Rcpt-To: Frank.Li@oss.nxp.com, ychuang3@nuvoton.com, schung@nuvoton.com, vkoul@kernel.org, Frank.Li@kernel.org, paul@crapouillou.net, Eugeniy.Paltsev@synopsys.com, andriy.shevchenko@linux.intel.com, zhoubinbin@loongson.cn, patrice.chotard@foss.st.com, amelie.delaunay@foss.st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, thierry.reding@kernel.org, jonathanh@nvidia.com, ludovic.desroches@microchip.com, vireshk@kernel.org, keguang.zhang@gmail.com, afaerber@suse.de, mani@kernel.org, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, kelvin.cao@microchip.com, ldewangan@nvidia.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-sunxi@lists.linux.dev, imx@lists.linux.dev, Frank.Li@nxp.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 2/2] dmaengine: add union chan_dev for dma_chan::dev for clarity X-SA-Exim-Version: 4.2.1 (built Sun, 23 Feb 2025 07:57:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260813_103447_236965_16E1125D X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2026-08-12 3:24 p.m., Frank.Li@oss.nxp.com wrote: > From: Frank Li > > The current dma_chan structure contains both "device" and "dev". So > > chan->device->dev refers to the DMA engine device. > chan->dev->device refers to the per-channel device instance. > > Their similar naming makes the distinction unclear and increases reader > confusion. > > Add union dma_chan::chan_dev to make its purpose explicit and clearly > identify it as the per-channel device. After all user switch to chan_dev, > union and dma_chan::dev will be removed. > > Update the kernel-doc accordingly. Besides its sysfs usage, the per-channel > device is also used by some DMA engine drivers for IOMMU mapping and > therefore deserves a more accurate description. > > No functional change intended. > > Signed-off-by: Frank Li Thanks, I've often been confused by this myself. I'm glad you're cleaning it up and making progress. Reviewed-by: Logan Gunthorpe