From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01483C433DB for ; Wed, 3 Feb 2021 08:28:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 863C464F67 for ; Wed, 3 Feb 2021 08:28:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 863C464F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aPGaHvKUxU9d/o0LirmVqEpMXsU8rHkPETZLKIaurXI=; b=pjqWWB2bxXfqZxyMYjxSPAMrS RzI9N/3sqcbbffTzxq+Vr0O7I0qGID4GgSrtTWgr4glOzp8PI7+pvnB0blQ/IBtUk9GE4xsNyr2GY AYWIjYZfjk4WSuIDsC77kEofv2eFfo/baTw+/C8XKU/HPjPzCF0Xrzelv7L9G4LwDbqt0b/km23u8 7jacmp5MG9RoZre8YUc/+gxvPkjlzsNvtztv/SgA5CYadDCr+ieZUhAhhiKOnESAmg7w1Qi7iNxJR 0d87dotu4/cyf4D6WZfoMSzCWxI+gEb1QJPWgV70FSlrQoOXSEv3BtTme/aA2xbVaTVC6FXlFbi11 mkBpkng7w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7DV1-0005ZF-V4; Wed, 03 Feb 2021 08:26:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7DUy-0005Ym-LE for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 08:26:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612340811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ny65LY+TRxvsTsvW7S+eXZHndHGabCwYYH6ldS6g6HY=; b=XEbacsjbiA2kOaivzN8YrW/a0j7u3PZCMsifpBATAOJa6REzsYWf5MaJcPVHvo+Iwnoh3O yzNv2tYAzEUVgvS3uprDlMAi4PTIfeTyHsM5NvENRBv7QzE8/61HOPtwrsSNyvWZIljSX0 AE4H9wn5Lz0HV/lyNl82wVcfv5iEqGY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-MQ2bufTVPx6NwFu1loFFTw-1; Wed, 03 Feb 2021 03:26:48 -0500 X-MC-Unique: MQ2bufTVPx6NwFu1loFFTw-1 Received: by mail-wr1-f70.google.com with SMTP id p16so13679586wrx.10 for ; Wed, 03 Feb 2021 00:26:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ny65LY+TRxvsTsvW7S+eXZHndHGabCwYYH6ldS6g6HY=; b=Bv6FtPvtFfTdQd/X1LLgClM1i3kVeCv2jDq5Wi8rmdwRFOnlMo/F4CmuV9ei3PqlOx 8tabcgbHVSrtRK+1SYZYgCj+WFGPulfj5mY3B4hqVcqSOJyFNwMICVX82e2z5neXRYFM kV42kf5IpFFiP+loQeipeXEajT75FuZzNDhDMtXIaWiiFM7KA2BcMx45jxyYcR4IZscL kR8nYYb4I4+cVKmLS61PBhKQGqiEOmSbLoVC1afsifboX6/AyuCB8N/7Yn85aHEYudmG qw84yWUdAXmawmdqUqhMvHcgI4wKdnqR6nu/XRz2s/CO6ZaQ3Z1WiBERY+P1A1c+WLdv nuzA== X-Gm-Message-State: AOAM532rCIJdnOD8j2u844xrfTjGOkePZZRZdr+Fhm4+SR/Y8OLMehz5 /2fSeRlplzEyTJZ9eQIDiJPTTK3m2YiglVExUxCAU3wOzi/OJuxAgr1uBnTzZD3AucIZ3lGb2pN fk+Ar3pGxUTKRPmOEbfgauK+hHnjtma1ZmMc= X-Received: by 2002:a1c:6145:: with SMTP id v66mr1704817wmb.188.1612340806957; Wed, 03 Feb 2021 00:26:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXDjrVWxmNntc5xJPT+eSmrOkD9+6ETwunqBSSfUEjXcvq61kj8NhKYLN3UN3NRwqH7dmImA== X-Received: by 2002:a1c:6145:: with SMTP id v66mr1704796wmb.188.1612340806764; Wed, 03 Feb 2021 00:26:46 -0800 (PST) Received: from ?IPv6:2a01:cb14:499:3d00:cd47:f651:9d80:157a? ([2a01:cb14:499:3d00:cd47:f651:9d80:157a]) by smtp.gmail.com with ESMTPSA id q7sm1231601wro.55.2021.02.03.00.26.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 00:26:46 -0800 (PST) Subject: Re: [RFC PATCH 1/5] arm64: Move instruction encoder/decoder under lib/ To: Mark Rutland References: <20210120171745.1657762-1-jthierry@redhat.com> <20210120171745.1657762-2-jthierry@redhat.com> <20210202101755.GB59049@C02TD0UTHF1T.local> From: Julien Thierry Message-ID: <9c01f293-2c98-43e6-a497-89610fe5970e@redhat.com> Date: Wed, 3 Feb 2021 09:26:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20210202101755.GB59049@C02TD0UTHF1T.local> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jthierry@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_032652_747729_61E803C4 X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, broonie@kernel.org, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On 2/2/21 11:17 AM, Mark Rutland wrote: > Hi Julien, > > On Wed, Jan 20, 2021 at 06:17:41PM +0100, Julien Thierry wrote: >> Aarch64 instruction set encoding and decoding logic can prove useful >> for some features/tools both part of the kernel and outside the kernel. >> >> Isolate the function dealing only with encoding/decoding instructions, >> with minimal dependency on kernel utilities in order to be able to reuse >> that code. >> >> Code was only moved, no code should have been added, removed nor >> modifier. >> >> Signed-off-by: Julien Thierry > > This looks sound, but the diff is a little hard to check. > Yes, I was expecting this change to be hard to digest. > Would it be possible to split this into two patches, where: > > 1) Refactoring definitions into insn.h and insn.c, leaving those files > in their current locations. > I'm not quite sure I understand the suggestions. After this patch insn.h and insn.c still contain some definitions that can't really be used outside of kernel code which is why I split them into insn.* and aarch64-insn.* (the latter containing what could be used by tools). Or do you suggest that I still create the aarch64-insn.* files next to the insn.* files? > 2) Moving insn.h and insn.c out to arch/arm64/lib/, updating includes > > With that, the second patch might be easier for git to identify as a > rename (if using `git format-patch -M -C`), and it'd be easier to see > that there are no unintended changes. > But it is more a split than a rename (at least in this patch). But I'm happy to do this in another way. Thanks, -- Julien Thierry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel