From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6806C433E6 for ; Tue, 22 Dec 2020 13:16:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6553E21D7F for ; Tue, 22 Dec 2020 13:16:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6553E21D7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V7mthoyddMT6n557cA9bwUxm+J8nBeGJFBPYLBaIPh0=; b=afIQYoEb7yZwh5pVx+BWzZQpA uCwQ8s24Z1UFLeNiw33eZ4Q3SU5n48Dgf/uUCmF559xMH/XL3BWN+W6NKkqkhCA9nw2FqHMsawRgR lR4SNK+CH2/4SkjIPS7HqHJelkvlBWIQ3kGeUb6K08kWx7scu0t2O2qzB/qyctGpxMeR47XXjE1rY quTJ0QN2ekqGIkV58pcYJ3yRz5rbIrXTPbXxWqSBGvdcFeVvVb7U8dSF++JGtMEn0QeLeYW86RLeD NotVftuhWWnZ/5X0Ed0e/Nhm94NYaPEzJ+SvE3ucX2OEllLstflLvUI2CNf0/GA1sW9x2SKsBVMeM vQznwz52g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krhV6-0004N7-Nk; Tue, 22 Dec 2020 13:14:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krhTB-00032i-ID for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 13:12:55 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91B4E23133; Tue, 22 Dec 2020 13:12:50 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1krhT6-0035US-5K; Tue, 22 Dec 2020 13:12:48 +0000 MIME-Version: 1.0 Date: Tue, 22 Dec 2020 13:12:47 +0000 From: Marc Zyngier To: kostap@marvell.com Subject: Re: [PATCH 1/1] marvell: irqchip: pic: change driver initcall to arch In-Reply-To: <20201222122151.4549-1-kostap@marvell.com> References: <20201222122151.4549-1-kostap@marvell.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <9c20fec9eb52ba7328e63efdbc3209fd@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: kostap@marvell.com, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, gregory.clement@bootlin.com, tmn505@gmail.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, mw@semihalf.com, jaz@semihalf.com, nadavh@marvell.com, bpeled@marvell.com, stefanc@marvell.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_081253_773611_4CF36B01 X-CRM114-Status: GOOD ( 21.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tmn505@gmail.com, andrew@lunn.ch, jaz@semihalf.com, gregory.clement@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, tglx@linutronix.de, mw@semihalf.com, bpeled@marvell.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-12-22 12:21, kostap@marvell.com wrote: > From: Stefan Chulski > > Patch solves the PMU driver probe error. > PMU driver depends on irqchip pic driver, so it should probe > after irqchip pic driver. > Initcall order changed from device to arch. > > Signed-off-by: Stefan Chulski > Signed-off-by: Konstantin Porotchkin > --- > drivers/irqchip/irq-mvebu-pic.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mvebu-pic.c > b/drivers/irqchip/irq-mvebu-pic.c > index eec63951129a..eca1a6edf49c 100644 > --- a/drivers/irqchip/irq-mvebu-pic.c > +++ b/drivers/irqchip/irq-mvebu-pic.c > @@ -188,7 +188,19 @@ static struct platform_driver mvebu_pic_driver = { > .of_match_table = mvebu_pic_of_match, > }, > }; > -module_platform_driver(mvebu_pic_driver); > + > +static int __init mvebu_pic_driver_init(void) > +{ > + return platform_driver_register(&mvebu_pic_driver); > +} > + > +static void __exit mvebu_pic_driver_exit(void) > +{ > + return platform_driver_unregister(&mvebu_pic_driver); > +} > + > +arch_initcall(mvebu_pic_driver_init) > +module_exit(mvebu_pic_driver_exit) > > MODULE_AUTHOR("Yehuda Yitschak "); > MODULE_AUTHOR("Thomas Petazzoni > "); You are trading an implicit dependency for another one, so this patch isn't acceptable, as it is just as likely to break as the current situation. Furthermore, at least on the system I lying around (8040), the PMU driver is perfectly able to defer its probing until the interrupt becomes available, so I have no idea what problem you are trying to solve. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel