From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: PeterYin <peteryin.openbmc@gmail.com>,
patrick@stwcx.xyz, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: cosmo.chou@quantatw.com, potin.lai@quantatw.com, daniel-hsu@quantatw.com
Subject: Re: [PATCH v5 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC
Date: Thu, 31 Aug 2023 08:44:59 +0200 [thread overview]
Message-ID: <9c23d906-bba3-533e-ac31-3bad4fa46d64@linaro.org> (raw)
In-Reply-To: <5347163b-c225-d805-d851-fe28e6b57c56@gmail.com>
On 31/08/2023 08:34, PeterYin wrote:
>
> On 8/31/23 14:20, Krzysztof Kozlowski wrote:
>> On 31/08/2023 07:50, Peter Yin wrote:
>>> Add linux device tree entry related to
>>> Minerva specific devices connected to BMC SoC.
>>>
>>> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++
>>> 2 files changed, 378 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 9e1d7bf3cff6..edb0b2105333 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>>> aspeed-bmc-facebook-wedge400.dtb \
>>> aspeed-bmc-facebook-yamp.dtb \
>>> aspeed-bmc-facebook-yosemitev2.dtb \
>>> + aspeed-bmc-facebook-minerva.dtb \
>> Third or fourth time: that's not a correct order. This is a nit, but
>> since you keep ignoring it, I don't believe any other feedback was
>> applied. Why you did not respond to my comments but just ignored them?
> Sorry, I don't notice this is different file.
You just skipped that comment and did not respond to it in your last
private reply... Just like in previous versions. Go through all the
comments from previous versions, not few.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-31 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 5:50 [PATCH v5 0/2] *** Add Facebook Minerva (AST2600) BMC *** Peter Yin
2023-08-31 5:50 ` [PATCH v5 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC Peter Yin
2023-08-31 6:20 ` Krzysztof Kozlowski
2023-08-31 6:34 ` PeterYin
2023-08-31 6:44 ` Krzysztof Kozlowski [this message]
2023-08-31 5:50 ` [PATCH v5 2/2] dt-bindings: arm: aspeed: add Meta Minerva board Peter Yin
2023-08-31 6:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c23d906-bba3-533e-ac31-3bad4fa46d64@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=cosmo.chou@quantatw.com \
--cc=daniel-hsu@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patrick@stwcx.xyz \
--cc=peteryin.openbmc@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox