From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD81C433DF for ; Thu, 6 Aug 2020 20:02:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77B25221E2 for ; Thu, 6 Aug 2020 20:02:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DlJETwnF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vXzP8kir" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77B25221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L8v817efpBlVMueJm+/3TN+mA3J8rpWfY5hxP5HUsgA=; b=DlJETwnFO9QSq2dpgqCAqyw/+ Osb+gH/4vTQQD1/gXOZGqpRRSlLLEBgCcARdAvgIhe6AvHZ51Qmm9xztNGCTx0Zn5BQ6V9VrgkCmY I/hTfRoHhQ+c7zutEfmqE/caXWkkdyo0kc2RquNu69QXrW0qO+e+EgwmmWZcfrA7svISsaDZr/sgI 2aC/fcNIo9beiyLDXTNsKzyXxQN1yDKta2qH5yWBSiTGmWaeuKPwhqYEEUDhOYVwI7TfoCKuOVH9f 2mqkkgzA5LgQCZ4eUkqYgJSyM3mGJdlcvR3LODVMYFw068eYmuEPS579zIixZIAOhXsUK+5q4EQX+ Dohst1UAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3m4X-0003Hm-OK; Thu, 06 Aug 2020 20:01:05 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3m4U-0003GK-MW for linux-arm-kernel@lists.infradead.org; Thu, 06 Aug 2020 20:01:03 +0000 Received: by mail-wm1-x342.google.com with SMTP id k8so10834941wma.2 for ; Thu, 06 Aug 2020 13:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1efmHhkESZyyTkV4YjG9R+9VKAGSzU4A2n9DPJ51c6k=; b=vXzP8kirTQLXYXApQ4BkSpIMvXB164bzSWnTW5WsT1Th1fa0cfY/x6FOvSEdm6nXnD 4uMl/EHRTfBE49HyFD6TbXG+Hbt9V3beqowzhdWO9GfYvHI8qphDINlGViHhAJ6zOBrw xcAP9Cz9DxEAPnVO0nF7ecih9rDg17vCXQ344u58AwahDEq5GCRn0dLorkX/GEAmHo6o pfQZy+AdC2UYQtWrQuCiFIWZ4oPFfcf8KshjJC5hDASRdCQF+B2vyYIHOJRsbCHgRriM 29ipPohXt9rHbc0XtelExLCVJco6YzCcfGdfwuUTckpc42y+C0xQSd56DatK9MEviAhE 4lGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1efmHhkESZyyTkV4YjG9R+9VKAGSzU4A2n9DPJ51c6k=; b=cHqzhfvIhuGund2TsXlYtsdLtHMgC9ybE260gifddv8KlSZo6XE1mWkj3NAZJfxXiN D+umL/SMk46FS1xHftbl7NjPKpSyPrqa+dKqK8lnnW7RX19STX5rUtLQ06Wvia7a7nPH OeQJk0qyPtr0+Tl8TcQxJxpelpF+ucDFDZJtqqhCmj1WtSxTp0y498w1dX7HEcfo1obK dh1pmhBkXI/wMQdN3tBgxoT0VfJ4Ki9cPnXo+Q3RWcG+RnIKvt5L/b4ADuaHHqJWSEPf N/q63FqqkdEqIgJpoDuw6R/Z8Bw2PkSphw7fR2t6ue0FfKYMHEHF7IoqXU5k4BrJ4t+G KamA== X-Gm-Message-State: AOAM5306dnklB51nsznt4Z8Ab3CrI7jDpXqtDWqUiVbRHAQsy6IyeT3M 2x0POoLfNlmbzQUx81aI2r0SU+gk X-Google-Smtp-Source: ABdhPJwGV5s3DdZeTmZurz5B8CV3xP8yPdmxkvz6E0i1ONWbghrttEfIOdrVF+lRXrsTMBAlrjsgyw== X-Received: by 2002:a1c:964b:: with SMTP id y72mr9536627wmd.69.1596744059869; Thu, 06 Aug 2020 13:00:59 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y203sm8105701wmc.29.2020.08.06.13.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 13:00:59 -0700 (PDT) Subject: Re: [PATCH stable v4.9 v2] arm64: entry: Place an SB sequence following an ERET instruction From: Florian Fainelli To: Greg KH , Will Deacon , Will Deacon References: <20200709195034.15185-1-f.fainelli@gmail.com> <20200720130411.GB494210@kroah.com> Message-ID: <9c29080e-8b3a-571c-3296-e0487fa473fa@gmail.com> Date: Thu, 6 Aug 2020 13:00:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200806_160102_756867_A545C2FA X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nick Desaulniers , Andrew Jones , Fangrui Song , Suzuki K Poulose , Catalin Marinas , Kristina Martsenko , open list , stable@vger.kernel.org, "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , Mark Brown , James Morse , linux-arm-kernel@lists.infradead.org, Sami Tolvanen , Marc Zyngier , Ard Biesheuvel , Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/20/2020 11:26 AM, Florian Fainelli wrote: > On 7/20/20 6:04 AM, Greg KH wrote: >> On Thu, Jul 09, 2020 at 12:50:23PM -0700, Florian Fainelli wrote: >>> From: Will Deacon >>> >>> commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream >>> >>> Some CPUs can speculate past an ERET instruction and potentially perform >>> speculative accesses to memory before processing the exception return. >>> Since the register state is often controlled by a lower privilege level >>> at the point of an ERET, this could potentially be used as part of a >>> side-channel attack. >>> >>> This patch emits an SB sequence after each ERET so that speculation is >>> held up on exception return. >>> >>> Signed-off-by: Will Deacon >>> [florian: Adjust hyp-entry.S to account for the label >>> added change to hyp/entry.S] >>> Signed-off-by: Florian Fainelli >>> --- >>> Changes in v2: >>> >>> - added missing hunk in hyp/entry.S per Will's feedback >> >> What about 4.19.y and 4.14.y trees? I can't take something for 4.9.y >> and then have a regression if someone moves to a newer release, right? > > Sure, send you candidates for 4.14 and 4.19. Greg, did you have a chance to queue those changes for 4.9, 4.14 and 4.19? https://lore.kernel.org/linux-arm-kernel/20200720182538.13304-1-f.fainelli@gmail.com/ https://lore.kernel.org/linux-arm-kernel/20200720182937.14099-1-f.fainelli@gmail.com/ https://lore.kernel.org/linux-arm-kernel/20200709195034.15185-1-f.fainelli@gmail.com/ Thanks -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel