From: Ezequiel Garcia <ezequiel@collabora.com>
To: Pan Bian <bianpan2016@163.com>,
Jacob Chen <jacob-chen@iotwrt.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: rockchip/rga: fix potential use after free
Date: Mon, 11 Nov 2019 09:03:17 -0300 [thread overview]
Message-ID: <9c46d5a708814082cc0c8a94e53e9e21a12271f1.camel@collabora.com> (raw)
In-Reply-To: <1573460902-18563-1-git-send-email-bianpan2016@163.com>
Hi Pan Bian,
Thanks for the patch.
On Mon, 2019-11-11 at 16:28 +0800, Pan Bian wrote:
> The variable vga->vfd is an alias for vfd. Therefore, releasing vfd and
> then unregister vga->vfd will lead to a use after free bug. In fact, the
> free operation and the unregister operation are reversed.
>
Out of curiosity, how did you find this potential bug?
Acked-by: Ezequiel Garcia <ezequiel@collabora.com>
Regards,
Ezequiel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 8:28 [PATCH v2] media: rockchip/rga: fix potential use after free Pan Bian
2019-11-11 12:03 ` Ezequiel Garcia [this message]
2019-12-12 10:53 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c46d5a708814082cc0c8a94e53e9e21a12271f1.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=bianpan2016@163.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).