From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF8DC43331 for ; Mon, 11 Nov 2019 12:03:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A82342190F for ; Mon, 11 Nov 2019 12:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PLyCZTK2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A82342190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aC5pOJwPLn77Q+tCOIAcxePqll3HsIDq04YZs35u2lk=; b=PLyCZTK2ZrmHV/ 9xRfH1jqIDGOrCfeq2JpgE3/xm22dqZTKsTUIxVw8ugiRaPkWwo9UfE/J469cv9VQJYflqaoUgcuk CtBcPosXO6PFbJPkuWpCisfcu/8DR6pwxYn4x1aXbmNL7mI6weAXi92NO/44Vx71nxU/ixm8q4dCY fbCkm6JTzd7YcU04MGTTYwdgaUA7oOze/aZz/x+eRLcAGt1UoHggS+TDdKY8vlDg243zcnJk0Ec6R UN/BccY90RrusFxIQwACDGwNjvm8jJ6EHCDVzbpuZ1PAUHjnI52wQqQc9wkQvcg3hPT/GQXGFBe28 HljYbWBSgWEz5++TS2Gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU8Q0-0007Xn-4R; Mon, 11 Nov 2019 12:03:40 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU8Ps-0007JV-HK; Mon, 11 Nov 2019 12:03:34 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id B665228F3C1 Message-ID: <9c46d5a708814082cc0c8a94e53e9e21a12271f1.camel@collabora.com> Subject: Re: [PATCH v2] media: rockchip/rga: fix potential use after free From: Ezequiel Garcia To: Pan Bian , Jacob Chen , Mauro Carvalho Chehab , Heiko Stuebner Date: Mon, 11 Nov 2019 09:03:17 -0300 In-Reply-To: <1573460902-18563-1-git-send-email-bianpan2016@163.com> References: <1573460902-18563-1-git-send-email-bianpan2016@163.com> Organization: Collabora User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_040332_721429_7F723718 X-CRM114-Status: UNSURE ( 6.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pan Bian, Thanks for the patch. On Mon, 2019-11-11 at 16:28 +0800, Pan Bian wrote: > The variable vga->vfd is an alias for vfd. Therefore, releasing vfd and > then unregister vga->vfd will lead to a use after free bug. In fact, the > free operation and the unregister operation are reversed. > Out of curiosity, how did you find this potential bug? Acked-by: Ezequiel Garcia Regards, Ezequiel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel