From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rob Clark <robdclark@gmail.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/arm-smmu-qcom: add sdm670 adreno iommu compatible
Date: Tue, 30 Jul 2024 08:23:44 +0200 [thread overview]
Message-ID: <9c4a586c-e9f2-44eb-a8ce-0b3943b07de0@kernel.org> (raw)
In-Reply-To: <20240730013820.41702-6-mailingradian@gmail.com>
On 30/07/2024 03:38, Richard Acayan wrote:
> Add the compatible for the separate IOMMU on SDM670 for the Adreno GPU.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index 36c6b36ad4ff..7f4b15be4a11 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -539,6 +539,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {
> { .compatible = "qcom,sc8180x-smmu-500", .data = &qcom_smmu_500_impl0_data },
> { .compatible = "qcom,sc8280xp-smmu-500", .data = &qcom_smmu_500_impl0_data },
> { .compatible = "qcom,sdm630-smmu-v2", .data = &qcom_smmu_v2_data },
> + { .compatible = "qcom,sdm670-smmu-v2", .data = &qcom_smmu_v2_data },
Do the people even read the comments? What the comment is saying? I
admit it might be not precise, but "500" and "v2" are the same from that
point of view.
NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-30 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 1:38 [PATCH 0/2] iommu/arm-smmu-qcom: Add SDM670 SMMU v2 Richard Acayan
2024-07-30 1:38 ` [PATCH 1/2] dt-bindings: iommu: arm,smmu: add sdm670 adreno iommu compatible Richard Acayan
2024-07-30 1:38 ` [PATCH 2/2] iommu/arm-smmu-qcom: " Richard Acayan
2024-07-30 6:23 ` Krzysztof Kozlowski [this message]
2024-07-30 9:22 ` Dmitry Baryshkov
2024-10-29 21:22 ` [PATCH 0/2] iommu/arm-smmu-qcom: Add SDM670 SMMU v2 Richard Acayan
2024-10-31 19:12 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c4a586c-e9f2-44eb-a8ce-0b3943b07de0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).