From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC3EC531DC for ; Fri, 16 Aug 2024 15:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=04UNYulrmBw5at1Th7g14Wg4WZSr6HgYutjIS185Fn8=; b=aPjP2vH/h+m2xzSc+GxzWERfY7 GA33WsqaWiGKyRcMbRcg3z6p+pnA2L7CIXv7IStoOn7YK4+1E5DWZPAvXyaFEIjJHIK+jA2NEwEhF Zxb6xWFHYtjZ6dxyRw9BtttMHK2ZPwmFeAkfY7dY3covQbo5Zl2GrivH3ksJOsosWJnHAPsoxC7No wMAZS7ctnLjD1ZH2OjPT+nyLgIyoh3YBbGFBoV1VY9aL268DC5E1Yaz/J07ZUZhMfRRui162XKPcY lx5QI9QWA73TTpx1wbvbwlSlh1tGqalFY8JMgmctCJmFQBAC82eFx9CyoFVpNnUw9Q2RolublHQvD qfiZtMog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sezHC-0000000DTy9-06Ud; Fri, 16 Aug 2024 15:54:06 +0000 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sezDc-0000000DSzC-2hA9 for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2024 15:50:26 +0000 Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-4929f9a28c7so731611137.1 for ; Fri, 16 Aug 2024 08:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1723823424; x=1724428224; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=04UNYulrmBw5at1Th7g14Wg4WZSr6HgYutjIS185Fn8=; b=PUHwCdxXs7U/mqdyNpCiQn9LoFS75Vhnx1Z05p0UlVodUnUlsoVHuDL7XDKi/bYdfS K3XlNgAlvV7vYAehvZe9Wl4lQbRL5Qwfxx5mEVSY0sFDdU90xHgcBqE1zVPrpqRsjVo7 3FdkHesM3dO3dnz4Mit4ajweOGkhwM0pZ6Xtc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723823424; x=1724428224; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=04UNYulrmBw5at1Th7g14Wg4WZSr6HgYutjIS185Fn8=; b=KspQBV6GPC3BNerPCkLNJ/ujUe5a8tRGeJ1h+V8ZdvjMdrFOfw7MNl/opY2YOAQT0R Cl9XsxiFZSK1BUF0NANezdXhSa9nU4B/GNsyFoIX4OzMC17zNJwefZmUcTgSBOzsC9Qw 0rH9BLixtJV4UIaOcHDz17jTCTlo2lsl/MqYSk9/u8s+OnSy1keUp2TzXOUopDnH+QZr VilrMNJeFabQKceJ4VPwb/e+OO3iSzP9je1MBmGdFHXzn9TqMRB7w5hdfEaI0Vzmrxdz BC96R1awpa9nl+1Zf79P7hQnW21zBE0DhHw6gkQzYpfoiWXjn93+izS5v+nBbYeQRlGU 1+4Q== X-Forwarded-Encrypted: i=1; AJvYcCUfwzPpN5qWWajQT4qBcU4PJbSqi2Y99TtlX5TK8MzPrUZ3JlkeeLCgDDkVpcilU0HKgK1xsKHwq2AxCNWRYXp8bNcpLMY0l3we4JHDAdKN1RUuJM4= X-Gm-Message-State: AOJu0YwpqJc6IITlG5yhyPqtCnGf2EPSYS+P9swKkAVV/LK81lUS9D1/ kV8noGiM5dGIIgclGg74Phb3/HGIZhM1LeHQoyw+zQqa4I8wv+bjJqe0g5ZhYw== X-Google-Smtp-Source: AGHT+IE2SAN3rGBjCvJuW576PqD2U+6D8iHOvypWNA4L+rUXdZYnB1HrLenKMMJE5odaPgj8kD4R3A== X-Received: by 2002:a05:6102:511e:b0:48f:831d:cea6 with SMTP id ada2fe7eead31-497799a592dmr4404272137.25.1723823423697; Fri, 16 Aug 2024 08:50:23 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45369fd9e39sm17816701cf.2.2024.08.16.08.50.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 08:50:23 -0700 (PDT) Message-ID: <9c9a050c-f35b-47b8-823d-96535614b5bb@broadcom.com> Date: Fri, 16 Aug 2024 08:50:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 04/13] PCI: brcmstb: Use common error handling code in brcm_pcie_probe() To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Manivannan Sadhasivam , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240815225731.40276-1-james.quinlan@broadcom.com> <20240815225731.40276-5-james.quinlan@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240815225731.40276-5-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240816_085024_803858_38D2EAD5 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/15/24 15:57, Jim Quinlan wrote: > Refactor the error handling in the bottom half of the probe > function for readability. The invocation of clk_prepare_enable() > is moved lower in the function and this simplifies a couple > of return paths. dev_err_probe() is also used when it is apt. > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian