From: kmpark@infradead.org (Kyungmin Park)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register
Date: Mon, 7 Sep 2009 19:09:55 +0900 [thread overview]
Message-ID: <9c9fda240909070309i3dbf4820jb5b53cfeabc478c2@mail.gmail.com> (raw)
In-Reply-To: <002201ca2fa3$02487c40$06d974c0$%yang@samsung.com>
On Mon, Sep 7, 2009 at 7:07 PM, Jinsung Yang<jsgood.yang@samsung.com> wrote:
> Hi,
>
>> Can you re-organize it as each register. I mean KEYIFCON fileds first,
>> KEYIFSTRCLR files second and so on.
>>
>> Can't figure out well
>>
>
> I'm not sure what you tell me about..
> Do you mean something like that?
>
> #define REG1
> #define REG1_FIELD1
> #define REG1_FIELD2
>
> #define REG2
> #define REG2_FIELD1
> #define REG2_FIELD2
>
> #define REG3
> #define REG3_FIELD1
> #define REG3_FIELD2
>
> Or like this?
> #define REG1
> #define REG2
> #define REG3
>
> #define REG1_FIELD1
> #define REG1_FIELD2
> #define REG2_FIELD1
> #define REG2_FIELD2
> #define REG3_FIELD1
> #define REG3_FIELD2
>
latter
#define REG1_OFFSET
#define REG2_OFFSET
#define REG3_OFFSET
/* REG1 field */
#define REG1_FIELD1
#define REG1_FIELD2
/* REG2 field */
#define REG2_FIELD1
#define REG2_FIELD2
/* REG3 field */
#define REG3_FIELD1
#define REG3_FIELD2
How about to review the another keypad drivers?
Thank you,
Kyungmin Park
prev parent reply other threads:[~2009-09-07 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 13:30 [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register 양진성
2009-09-06 23:56 ` Kyungmin Park
2009-09-07 10:07 ` Jinsung Yang
2009-09-07 10:09 ` Kyungmin Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c9fda240909070309i3dbf4820jb5b53cfeabc478c2@mail.gmail.com \
--to=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).