linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register
@ 2009-09-05 13:30 양진성
  2009-09-06 23:56 ` Kyungmin Park
  0 siblings, 1 reply; 4+ messages in thread
From: 양진성 @ 2009-09-05 13:30 UTC (permalink / raw)
  To: linux-arm-kernel

This patch supports register map for s3c keypad driver.

Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
---
 arch/arm/plat-s3c/include/plat/regs-keypad.h |   39 ++++++++++++++++++++++++++
 1 files changed, 39 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-s3c/include/plat/regs-keypad.h

diff --git a/arch/arm/plat-s3c/include/plat/regs-keypad.h b/arch/arm/plat-s3c/include/plat/regs-keypad.h
new file mode 100644
index 0000000..ca71ecb
--- /dev/null
+++ b/arch/arm/plat-s3c/include/plat/regs-keypad.h
@@ -0,0 +1,39 @@
+/* linux/arch/arm/plat-s3c/include/plat/regs-keypad.h
+ *
+ * S3C Key Interface register definitions
+ *
+ * Kim Kyoungil, Copyright (c) 2006-2009 Samsung Electronics
+ *      http://www.samsungsemi.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+
+#ifndef __ASM_ARCH_REGS_KEYPAD_H
+#define __ASM_ARCH_REGS_KEYPAD_H
+
+/* 
+ * Keypad Interface
+ */
+#define S3C_KEYPADREG(x)	(x)
+
+#define S3C_KEYIFCON		S3C_KEYPADREG(0x00)
+#define S3C_KEYIFSTSCLR		S3C_KEYPADREG(0x04)
+#define S3C_KEYIFCOL		S3C_KEYPADREG(0x08)
+#define S3C_KEYIFROW		S3C_KEYPADREG(0x0C)
+#define S3C_KEYIFFC		S3C_KEYPADREG(0x10)
+
+#define S3C_KEYIF_COL_DMASK	(0xff)
+#define S3C_KEYIF_ROW_DMASK	(0xff)
+#define S3C_KEYIF_INT_F_EN	(1 << 0) /*falling edge(key-pressed) interuppt enable*/
+#define S3C_KEYIF_INT_R_EN	(1 << 1) /*rising edge(key-released) interuppt enable*/
+#define S3C_KEYIF_DF_EN		(1 << 2) /*debouncing filter enable*/
+#define S3C_KEYIF_FC_EN		(1 << 3) /*filter clock enable*/
+#define S3C_KEYIF_CON_MASK_ALL	(0x1f)
+#define S3C_KEYIF_COL_MASK_ALL	(0xffff)
+#define S3C_KEYIF_STSCLR_CLEAR	(0xffff)
+
+#endif /* __ASM_ARCH_REGS_KEYPAD_H */
+
-- 
1.6.2.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register
  2009-09-05 13:30 [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register 양진성
@ 2009-09-06 23:56 ` Kyungmin Park
  2009-09-07 10:07   ` Jinsung Yang
  0 siblings, 1 reply; 4+ messages in thread
From: Kyungmin Park @ 2009-09-06 23:56 UTC (permalink / raw)
  To: linux-arm-kernel

2009/9/5 ??? <jsgood.yang@samsung.com>:
> This patch supports register map for s3c keypad driver.
>
> Signed-off-by: Jinsung Yang <jsgood.yang@samsung.com>
> Signed-off-by: Kyeongil Kim <ki0351.kim@samsung.com>
> ---
> ?arch/arm/plat-s3c/include/plat/regs-keypad.h | ? 39 ++++++++++++++++++++++++++
> ?1 files changed, 39 insertions(+), 0 deletions(-)
> ?create mode 100644 arch/arm/plat-s3c/include/plat/regs-keypad.h
>
> diff --git a/arch/arm/plat-s3c/include/plat/regs-keypad.h b/arch/arm/plat-s3c/include/plat/regs-keypad.h
> new file mode 100644
> index 0000000..ca71ecb
> --- /dev/null
> +++ b/arch/arm/plat-s3c/include/plat/regs-keypad.h
> @@ -0,0 +1,39 @@
> +/* linux/arch/arm/plat-s3c/include/plat/regs-keypad.h
> + *
> + * S3C Key Interface register definitions
> + *
> + * Kim Kyoungil, Copyright (c) 2006-2009 Samsung Electronics
> + * ? ? ?http://www.samsungsemi.com/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +
> +#ifndef __ASM_ARCH_REGS_KEYPAD_H
> +#define __ASM_ARCH_REGS_KEYPAD_H
> +
> +/*
> + * Keypad Interface
> + */
> +#define S3C_KEYPADREG(x) ? ? ? (x)
> +
> +#define S3C_KEYIFCON ? ? ? ? ? S3C_KEYPADREG(0x00)
> +#define S3C_KEYIFSTSCLR ? ? ? ? ? ? ? ?S3C_KEYPADREG(0x04)
> +#define S3C_KEYIFCOL ? ? ? ? ? S3C_KEYPADREG(0x08)
> +#define S3C_KEYIFROW ? ? ? ? ? S3C_KEYPADREG(0x0C)
> +#define S3C_KEYIFFC ? ? ? ? ? ?S3C_KEYPADREG(0x10)
> +
> +#define S3C_KEYIF_COL_DMASK ? ?(0xff)
> +#define S3C_KEYIF_ROW_DMASK ? ?(0xff)
> +#define S3C_KEYIF_INT_F_EN ? ? (1 << 0) /*falling edge(key-pressed) interuppt enable*/
> +#define S3C_KEYIF_INT_R_EN ? ? (1 << 1) /*rising edge(key-released) interuppt enable*/
> +#define S3C_KEYIF_DF_EN ? ? ? ? ? ? ? ?(1 << 2) /*debouncing filter enable*/
> +#define S3C_KEYIF_FC_EN ? ? ? ? ? ? ? ?(1 << 3) /*filter clock enable*/
> +#define S3C_KEYIF_CON_MASK_ALL (0x1f)
> +#define S3C_KEYIF_COL_MASK_ALL (0xffff)
> +#define S3C_KEYIF_STSCLR_CLEAR (0xffff)

Can you re-organize it as each register. I mean KEYIFCON fileds first,
KEYIFSTRCLR files second and so on.

Can't figure out well

Thank you,
Kyungmin Park

> +
> +#endif /* __ASM_ARCH_REGS_KEYPAD_H */
> +
> --
> 1.6.2.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register
  2009-09-06 23:56 ` Kyungmin Park
@ 2009-09-07 10:07   ` Jinsung Yang
  2009-09-07 10:09     ` Kyungmin Park
  0 siblings, 1 reply; 4+ messages in thread
From: Jinsung Yang @ 2009-09-07 10:07 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

> Can you re-organize it as each register. I mean KEYIFCON fileds first,
> KEYIFSTRCLR files second and so on.
> 
> Can't figure out well
> 

I'm not sure what you tell me about..
Do you mean something like that?

#define REG1
#define REG1_FIELD1
#define REG1_FIELD2

#define REG2
#define REG2_FIELD1
#define REG2_FIELD2

#define REG3
#define REG3_FIELD1
#define REG3_FIELD2

Or like this?
#define REG1
#define REG2
#define REG3

#define REG1_FIELD1
#define REG1_FIELD2
#define REG2_FIELD1
#define REG2_FIELD2
#define REG3_FIELD1
#define REG3_FIELD2

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register
  2009-09-07 10:07   ` Jinsung Yang
@ 2009-09-07 10:09     ` Kyungmin Park
  0 siblings, 0 replies; 4+ messages in thread
From: Kyungmin Park @ 2009-09-07 10:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 7, 2009 at 7:07 PM, Jinsung Yang<jsgood.yang@samsung.com> wrote:
> Hi,
>
>> Can you re-organize it as each register. I mean KEYIFCON fileds first,
>> KEYIFSTRCLR files second and so on.
>>
>> Can't figure out well
>>
>
> I'm not sure what you tell me about..
> Do you mean something like that?
>
> #define REG1
> #define REG1_FIELD1
> #define REG1_FIELD2
>
> #define REG2
> #define REG2_FIELD1
> #define REG2_FIELD2
>
> #define REG3
> #define REG3_FIELD1
> #define REG3_FIELD2
>
> Or like this?
> #define REG1
> #define REG2
> #define REG3
>
> #define REG1_FIELD1
> #define REG1_FIELD2
> #define REG2_FIELD1
> #define REG2_FIELD2
> #define REG3_FIELD1
> #define REG3_FIELD2
>

latter

 #define REG1_OFFSET
 #define REG2_OFFSET
 #define REG3_OFFSET

/* REG1 field */
#define REG1_FIELD1
#define REG1_FIELD2

/* REG2 field */
#define REG2_FIELD1
#define REG2_FIELD2

/* REG3 field */
#define REG3_FIELD1
#define REG3_FIELD2

How about to review the another keypad drivers?

Thank you,
Kyungmin Park

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-07 10:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-05 13:30 [PATCH 09/12] [ARM][S3C6410] Add definitions of keypad register 양진성
2009-09-06 23:56 ` Kyungmin Park
2009-09-07 10:07   ` Jinsung Yang
2009-09-07 10:09     ` Kyungmin Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).