From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC7C8C7619A for ; Wed, 5 Apr 2023 03:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=53s/5Niw2QMBIpYholp/cadshtyxOSwwcXJXPkgU9RA=; b=e0EHrnboCvkwHm 4zoQ+edaRjU6ynEQZ5A3HqTfNk5D4fHswuWEQ7/6k345pHHrtiQjyMGp2rTOGtAY8oD4WDzAKTlZf OdUfyvtNTtIyiNNxW0khBpCeBytbCaXaNTnix+Qc9BN0MxdcTbHWC9UpuhjPginOAEImgGl75OW+X hVoCZsrq6LAHzx5s5bCbe4MxXUYmvuWD3g1+xWhNjsG5Q/LQnvXxaTMdKqie7+nPYRtzrEFT2HgxZ pC+FOKNzFcLl77+VRK+7Dr8glm33ahAPBXZtxwarxEYGZmxouUGLk9KmSdMsWU/7GSiKN85xBa3P/ sq5Kd2afghi38u7Zl7cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjuAo-003G4i-16; Wed, 05 Apr 2023 03:51:02 +0000 Received: from out30-111.freemail.mail.aliyun.com ([115.124.30.111]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjuAk-003G3e-0l for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2023 03:51:00 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R961e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=30;SR=0;TI=SMTPD_---0VfNxCDL_1680666644; Received: from 30.240.113.3(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VfNxCDL_1680666644) by smtp.aliyun-inc.com; Wed, 05 Apr 2023 11:50:47 +0800 Message-ID: <9cb06879-d743-e3b2-b8e3-23962b458202@linux.alibaba.com> Date: Wed, 5 Apr 2023 11:50:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 18/32] perf/alibaba_uncore: Assign parents for event_source device Content-Language: en-US To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org Cc: linuxarm@huawei.com, Dan Williams , Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Suzuki K Poulose , Liang Kan References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-19-Jonathan.Cameron@huawei.com> From: Shuai Xue In-Reply-To: <20230404134225.13408-19-Jonathan.Cameron@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_205058_493315_708D90A7 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/4/4 PM9:42, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the platform device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Cc: Shuai Xue > Signed-off-by: Jonathan Cameron > --- > drivers/perf/alibaba_uncore_drw_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c > index a7689fecb49d..0d129acf3f84 100644 > --- a/drivers/perf/alibaba_uncore_drw_pmu.c > +++ b/drivers/perf/alibaba_uncore_drw_pmu.c > @@ -683,6 +683,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev) > > drw_pmu->pmu = (struct pmu) { > .module = THIS_MODULE, > + .parent = &pdev->dev, > .task_ctx_nr = perf_invalid_context, > .event_init = ali_drw_pmu_event_init, > .add = ali_drw_pmu_add, Reviewed-by: Shuai Xue Thank you. Best Regards, Shuai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel