From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFB3FD2A521 for ; Wed, 16 Oct 2024 14:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7uD86GHH73wAIfXRyQS8Bz3q+Ng3nHf4VH1iDLFs+LQ=; b=FEaijFizBVGjbYx5MUzHf7+jZa Hys3d+1DXeA/KwfXYNsEaY9ozu33279k0RlkbwbNKhQw99HEHDN4S1ccnIKaqBk7GM7nShv+6AAUd l1ArV2eNL4g8DPi3OupbMsR8aNYjBbVZIxVmIvm1rPS5wZwYEslZI9C3RRtZyITJlydXjr75+YICB q4oJMgXQJJWsaqzOjA96PC1hZFJeb716yNMAnNlVLAUmylahDDiecrcXOkTfJ4TQQOtNieB6JI17P mphDg3ZtGxyw0GK0Lws2DguCELToUHKSDyt5+ga2aXI8s2LvIRyrVGvL8ux/WlxH/KnkjA8IZqQKI Larem3lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t150G-0000000C4TB-3FK4; Wed, 16 Oct 2024 14:27:56 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t14yp-0000000C4Hx-3e5P for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 14:26:29 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 49GEQIff053122; Wed, 16 Oct 2024 09:26:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1729088778; bh=7uD86GHH73wAIfXRyQS8Bz3q+Ng3nHf4VH1iDLFs+LQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=P+4fGtVznXW+wmHDiADj6Lo97gXLn0iUAft9wq48rNX+tXGU/hNekNGBP/2Mh0pkW 7U0H1tOLIYX5yhVGcDfES0lFjG2t/tNIzIzXAyIa7Q4+eY8NUdb6lUDCTfdIfgzWVE eJOeY5fLpEoKJwsUqZYPz0di59y2WprfR6+IBJPo= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 49GEQIbM026790 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Oct 2024 09:26:18 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 16 Oct 2024 09:26:17 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 16 Oct 2024 09:26:17 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 49GEQH66083088; Wed, 16 Oct 2024 09:26:17 -0500 Message-ID: <9cec1380-37f5-48e1-ad89-2bcede5d5f3c@ti.com> Date: Wed, 16 Oct 2024 09:26:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver To: Guillaume LA ROQUE , Catalin Marinas , Will Deacon , Thomas Gleixner , Nishanth Menon , Tero Kristo , Santosh Shilimkar CC: , , , Mattijs Korpershoek , Kevin Hilman , Nicolas Frayer References: <20241016-timodules-v3-0-fa71091ade98@baylibre.com> <20241016-timodules-v3-1-fa71091ade98@baylibre.com> <95b85e47-8554-430b-b878-e6045d8f6871@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_072628_024769_3AAF9659 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/16/24 9:18 AM, Guillaume LA ROQUE wrote: > Hi Andrew, > > Le 16/10/2024 à 15:37, Andrew Davis a écrit : >> On 10/16/24 4:41 AM, Guillaume La Roque wrote: >>> From: Nicolas Frayer >>> >>> Added module build support in Kconfig for the TI SCI interrupt router >>> driver >>> >>> Signed-off-by: Nicolas Frayer >>> Signed-off-by: Guillaume La Roque >>> --- >>>   arch/arm64/Kconfig.platforms      | 1 - >>>   drivers/irqchip/Kconfig           | 3 ++- >>>   drivers/irqchip/irq-ti-sci-intr.c | 1 + >>>   3 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >>> index 6c6d11536b42..393845a3ae5c 100644 >>> --- a/arch/arm64/Kconfig.platforms >>> +++ b/arch/arm64/Kconfig.platforms >>> @@ -135,7 +135,6 @@ config ARCH_K3 >>>       select SOC_TI >>>       select TI_MESSAGE_MANAGER >>>       select TI_SCI_PROTOCOL >>> -    select TI_SCI_INTR_IRQCHIP >>>       select TI_SCI_INTA_IRQCHIP >>>       select TI_K3_SOCINFO >>>       help >>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >>> index 341cd9ca5a05..a958731404e9 100644 >>> --- a/drivers/irqchip/Kconfig >>> +++ b/drivers/irqchip/Kconfig >>> @@ -533,9 +533,10 @@ config LS1X_IRQ >>>         Support for the Loongson-1 platform Interrupt Controller. >>>     config TI_SCI_INTR_IRQCHIP >>> -    bool >>> +    tristate "TI SCI INTR Interrupt Controller" >> >> Although not needed, might be good to gate this on ARCH_K3 >> as it only makes sense to add when K3 is an enabled platform. > > Actually if ARCH_K3 is not selected it's not possible to enable TI IRQCHIP driver from menuconfig so depends look good or do you want to have when i select irqchip driver ARCH_K3 is enabled ? > Just adding the below "depends on" is fine, no need to select or change anything else. Andrew >> Then add on compile test support: >> >> depends on ARCH_K3 || COMPILE_TEST >> > i will add in v4. > > thanks for review > > Guillaume >> Andrew >> >>>       depends on TI_SCI_PROTOCOL >>>       select IRQ_DOMAIN_HIERARCHY >>> +    default ARCH_K3 >>>       help >>>         This enables the irqchip driver support for K3 Interrupt router >>>         over TI System Control Interface available on some new TI's SoCs. >>> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c >>> index c027cd9e4a69..b49a73106c69 100644 >>> --- a/drivers/irqchip/irq-ti-sci-intr.c >>> +++ b/drivers/irqchip/irq-ti-sci-intr.c >>> @@ -303,3 +303,4 @@ module_platform_driver(ti_sci_intr_irq_domain_driver); >>>     MODULE_AUTHOR("Lokesh Vutla "); >>>   MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol"); >>> +MODULE_LICENSE("GPL"); >>> >