From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DE4C32771 for ; Wed, 22 Jan 2020 04:05:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B24992071E for ; Wed, 22 Jan 2020 04:05:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MIQ0wMud"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uhsGKyNy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B24992071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZoENGPxBSgzStxFBRFlfUZsDgLNH7FKU2uXgpBnG5BY=; b=MIQ0wMudnrLihj WVZv/k9cooRpwRfI9IMQAYQdFvkwoJDecrYR+byXfyYue5FxRN9YaGE6i5frSTkyEzFEbfKvERM0R xEfYaHlGVdIaQzBLngOnbc1n7zWbpfmg3kXcdTDxNhsP5YQqskyN7VQF3C282jrZ+AnWCnYMV+6kW RyrCanhVLl6JYq3GZbkxT64o0JsOcR1duxTyPTW2hVDFSef1VoSo6Xm8VwLbwoJIB+5x0A4E2myIP 9WIeD1CNwSlfNT8VINXdOIoUQSXrrl4gTK4ghSAyQHSsraG7Y+xUl1513Fnu27xgaXrpRWVlK9Tw0 +k6hctIbYV2q02bmysBg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iu7GH-00054m-4n; Wed, 22 Jan 2020 04:05:01 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iu7GE-00054K-Q1 for linux-arm-kernel@lists.infradead.org; Wed, 22 Jan 2020 04:05:00 +0000 Received: by mail-wm1-x341.google.com with SMTP id d139so3460124wmd.0 for ; Tue, 21 Jan 2020 20:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QnP3I9MQH2rjvN4odqaiJfYKIdwE2UEnGytQrH/isCo=; b=uhsGKyNygZhXrZu7vjW5rzhzl2zOR80ETGG0fo6Wx++dxDeZPl5EoBK2tzjxMJjxOd LeCOLr3vGDWeAVm06DUuLADW5K7S2/+mHDDLpGgRO0THcQL9JHtv7u3BvEBlJr0jP7Ak BE0RqXczHjodZn+Vo8L+XL/tls839WQqTk5qM/cWm6LihNu2HGaeeTmQ7BPScl7wWilc BaHpHzEbnqUYBFufqdTq8c+gHF7PTC94LXv6YhCXMiIXkJPB8Cb5UrHI5ADMRLjA42zo nLMeVAii95vUSkdWBg5b7poNaR1WUrM6yM2b2w7gN2l1Z0s8bZCpIZe+3tTbA8O4xFEI DIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QnP3I9MQH2rjvN4odqaiJfYKIdwE2UEnGytQrH/isCo=; b=NNW0i1DldDAaOmoYz5JHGepq7lb7RdIaQgMuuyQvxab6e6VI3PgyB9gTDRPhOQqq4X zzCRufkBieyijEEjJilyMgnfW7qM8C4CS8AsgBsfItwBUgnajeBwyHoEsw6GI0k3vYgp b0BrdFs4azHWsw0DFwL9joqzLDfv2OS6yAeawaU3vcTxj+ajZp/g/2rTBD/cHEEHqI8h AMYFmte6qRaPFMZ6Xt1RJsLE763kBOThweD8eJDjAKcThjU/Vw122DkkSUrZeAeaeXHV jT1FElXQENuktPNjfzv503U+eK2Na2wxa281pgR1KkiVUnz71rsfBs47sOAKdhhAjM8u mH7g== X-Gm-Message-State: APjAAAWrhKah5hoiD8SYJMUN8ilPmjrYfGAD4t2SpdlanBmSiMRzgZlQ r/RIH6tLtYkG0lyMoUMxAy4= X-Google-Smtp-Source: APXvYqy5KkRy1uXxqtjC4MyYoj8JskrPlSRfUong+9Z73j995d4xccxTBqgnHi3V+SoQVsINzFgxaw== X-Received: by 2002:a05:600c:2959:: with SMTP id n25mr481678wmd.185.1579665897027; Tue, 21 Jan 2020 20:04:57 -0800 (PST) Received: from [10.230.28.123] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id m3sm53812768wrs.53.2020.01.21.20.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 20:04:55 -0800 (PST) Subject: Re: [PATCH v2 net-next] net: convert suitable drivers to use phy_do_ioctl_running To: Heiner Kallweit , Andrew Lunn , David Miller , Maxime Ripard , Chen-Yu Tsai , Doug Berger , Pantelis Antoniou , Yisen Zhuang , Salil Mehta , Vladimir Zapolskiy , Sylvain Lemieux , Timur Tabi , Sergei Shtylyov , Steve Glendinning , Michal Simek , Woojung Huh , Microchip Linux Driver Support References: <2db5d899-a550-456d-a725-f7cf009f53a3@gmail.com> From: Florian Fainelli Message-ID: <9d2dbcc0-7e22-601a-35f6-135f2a9e6f99@gmail.com> Date: Tue, 21 Jan 2020 20:04:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <2db5d899-a550-456d-a725-f7cf009f53a3@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_200458_873459_5DAB7C81 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Linux USB Mailing List , linux-renesas-soc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/21/2020 1:09 PM, Heiner Kallweit wrote: > Convert suitable drivers to use new helper phy_do_ioctl_running. > > Signed-off-by: Heiner Kallweit The vast majority of drivers that you are converting use the following convention: - !netif_running -> return -EINVAL - !dev->phydev -> return -ENODEV so it may make sense to change the helper to accommodate the majority here, not that I believe this is going to make much practical difference, but if there were test cases that were specifically looking for such an error code, they could be failing after this changeset. For bgmac.c, bcmgenet.c and cpmac.c: Acked-by: Florian Fainelli Whether you decide to spin another version or not. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel