Re: [PATCH v6 4/4] media: platform: mediatek: Add MT8188 AIE driver

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

On Fri, 2026-06-05 at 16:30 +0800, Sarang Chaudhari wrote:
> Add the MediaTek AI Engine (AIE) V4L2 memory-to-memory driver for the
> MT8188 SoC. The AIE hardware accelerator provides face detection, facial
> landmark detection (FLD), and face attribute analysis (age, gender, race)
> capabilities.
> 
> The driver implements:
> - V4L2 mem2mem device with multi-planar video and metadata capture
> - Three operation modes: face detection (FD), attribute analysis, and
>   facial landmark detection (FLD) using Binary Tree Traversal
> - Pyramid-based multi-scale face detection (640x480 base, 2x downscale
>   per level)
> - Hardware configuration via DMA descriptor tables
> - Clock and power management integration

This patch looks similar to v3[1], so I think you should look my comment in v3, v4[2], v5[3].
Or more simple way, base on v5, fix with my v5 comment, and generate a real v6.

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20241225090113.17027-4-bo.kong@mediatek.com/
[2] https://patchwork.kernel.org/project/linux-mediatek/patch/20250220070114.15015-5-bo.kong@mediatek.com/
[3] https://patchwork.kernel.org/project/linux-mediatek/patch/20250403074005.21472-5-bo.kong@mediatek.com/

Regards,
CK

> 
> Signed-off-by: Sarang Chaudhari <sarang.chaudhari@mediatek.com>
> ---
>