From: Hanjun Guo <guohanjun@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
Aleksandr Mishin <amishin@t-argos.ru>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
<linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()
Date: Fri, 8 Nov 2024 11:52:32 +0800 [thread overview]
Message-ID: <9d53d1f4-1f65-be5e-f68d-18799080a2e5@huawei.com> (raw)
In-Reply-To: <ZtCgyuQ4IRr9Mx8x@bogus>
+Cc Catalin and Will
On 2024/8/30 0:24, Sudeep Holla wrote:
> On Thu, Aug 29, 2024 at 05:17:44PM +0100, Sudeep Holla wrote:
>> On Tue, Aug 27, 2024 at 01:12:39PM +0300, Aleksandr Mishin wrote:
>>> In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame'
>>> will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block
>>> because do{} block will be executed even if 'i == 0'.
>>>
>>> Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'.
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>>
>>
>> (For some reason I don't see the original email in my inbox, might have
>> got blocked 🙁). Anyways LGTM,
>>
>> Acked-by: Aleksandr Mishin <amishin@t-argos.ru>
>
> Sorry I messed up, I meant
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Catalin, this is a fix, and was acked by Sudeep and me, could you
merge it for next release cycle?
Thanks
Hanjun
next prev parent reply other threads:[~2024-11-08 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 10:12 [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block() Aleksandr Mishin
2024-08-29 13:52 ` Hanjun Guo
2024-08-29 16:17 ` Sudeep Holla
2024-08-29 16:24 ` Sudeep Holla
2024-11-08 3:52 ` Hanjun Guo [this message]
2024-11-08 16:49 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d53d1f4-1f65-be5e-f68d-18799080a2e5@huawei.com \
--to=guohanjun@huawei.com \
--cc=amishin@t-argos.ru \
--cc=catalin.marinas@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox