From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9828DC52D7C for ; Thu, 15 Aug 2024 15:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ypH/0neTHZJ3Pfc3D7w4cPCJLE+iJfGOt4G/6i26Wa0=; b=19nIF6HTbJ8upYmkBBgjEwcHpM GBoTXvZFn9OGROAWpR9gRnPrUvZcUODLO7jnJrxM0JIDtyOB43Ab+uwlFJyeDwzfXSu/QKnD9oqyD AuQrPMHczykv6HArFFz+vHdL4aNb4GXRB2dQO5nLiJNEl3Lgt8Vjkbp09CqVeScQOS+vk9n1SMTbK vtqo/mTWOZPqS+HeBaMKjZ2x7sFF68H8Fr2h8rLYGdNJyDOkfXKe3YuQwNxJIL7oTkEMH20bV2GbB MwfEgsOhdNzCnY2pyzldhIzGbhlDPe9CbeGLZf4OMFmJ/yHU6vCg6EbT1cz4agVOVB5VwMuw5zmZS rPaqVYxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1secDE-0000000ALxv-2knU; Thu, 15 Aug 2024 15:16:28 +0000 Received: from out-171.mta1.migadu.com ([2001:41d0:203:375::ab]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1secBc-0000000ALQY-2JO2 for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 15:14:57 +0000 Message-ID: <9d67d2b0-e4bd-466a-ad60-e40d4b1fc4e7@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723734886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ypH/0neTHZJ3Pfc3D7w4cPCJLE+iJfGOt4G/6i26Wa0=; b=J2ulUT7IVpaDBwKRuNBIsZQ8U0H6wXc1MsYkMQQiAUyGG3wSgUcYjWhW0HeuDBzxF1WgTq vDNgrW67em5uaDTBjMZHr68ZhcX6YZSz0PM26VTMiayHec07SlRSI3wuy0JJj6dvDUmN5f +IE98CpDJQkzv7ce733R8uA91BSnnWk= Date: Thu, 15 Aug 2024 11:14:41 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net-next 1/4] net: xilinx: axienet: Always disable promiscuous mode To: Simon Horman Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S . Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller References: <20240812200437.3581990-1-sean.anderson@linux.dev> <20240812200437.3581990-2-sean.anderson@linux.dev> <20240815145832.GG632411@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240815145832.GG632411@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_081448_899862_F8BFC331 X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/15/24 10:58, Simon Horman wrote: > On Mon, Aug 12, 2024 at 04:04:34PM -0400, Sean Anderson wrote: >> If prmiscuous mode is disabled when there are fewer than four multicast >> addresses, then it will to be reflected in the hardware. Fix this by >> always clearing the promiscuous mode flag even when we program multicast >> addresses. >> >> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") >> Signed-off-by: Sean Anderson >> --- >> >> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> index ca04c298daa2..e664611c29cf 100644 >> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c >> @@ -451,6 +451,10 @@ static void axienet_set_multicast_list(struct net_device *ndev) >> } else if (!netdev_mc_empty(ndev)) { >> struct netdev_hw_addr *ha; >> >> + reg = axienet_ior(lp, XAE_FMI_OFFSET); >> + reg &= ~XAE_FMI_PM_MASK; >> + axienet_iow(lp, XAE_FMI_OFFSET, reg); >> + > > Hi Sean, > > I notice that this replicates code in another part of this function. > And that is then factored out into common code as part of the last > patch of this series. > > I guess that it is in the wash, but perhaps it would > be nicer to factor out the common promisc mode setting code > as part of this patch. > > Otherwise, this LGTM. I thought about doing that, but it would have required changing the indentation of ~10 lines and I thought it would be easier to review the patch without that noise. --Sean