From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E669BCCF9EA for ; Mon, 27 Oct 2025 11:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZWAM/1l3ob/3LqSmNYM1Kzzm3JAMnpjQt4pTVWbHtSU=; b=MrbNMPOLJivxFjV9RDRLyrCNiS o+MVU/fjAJq3MWt+oUDT5w+OZLNiirwsX94n6Wxkst57W+U9TO9UXscapjWCuRir+ITV6bkcKNmNh AjcoqOwMLZRd9tmVUUuVl8qlSx30BAsn5LFF6bNqLr+64pdpyuNC+kgSzUjZXPu5T0dp1uVcdIeRn 9QYBEmE216NoUn18W2q1f8TcLm4CKKt5b94V20sYEQPT02GSbGYMwV7Qo4xZOCiV/azmozMUzVK6G Snh/WEqN7wHjBd16b4xLqdqwlN5VeWZbfX3tNz/c9lhnDzuF5Rp1WPPwOn7MNSyxXNrIhxeIF/TMY nSxPUXgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDLom-0000000Dp0B-32AL; Mon, 27 Oct 2025 11:55:20 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDLok-0000000DozA-0KAJ for linux-arm-kernel@lists.infradead.org; Mon, 27 Oct 2025 11:55:19 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59R81h7p915959 for ; Mon, 27 Oct 2025 11:55:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZWAM/1l3ob/3LqSmNYM1Kzzm3JAMnpjQt4pTVWbHtSU=; b=cNRPH67Z1NyjlP86 M3mT59D+2BjMtjmwTDK4eOBY5D48EYOjfmoKt45lQ91fdljCtvuHEmWbjcvu0jKN qvGFPVMEJobVnMbfmWfgwW/0VxH+7AuzzTvZb4skfqOMI9qISCFUwlnEbz43bGA0 //bJ4mw9Z0bu2PkyBcRWpQQmMa/U+MjAxRu/a5C0mhUp5qezSrfGK7//NzvQHkTj Zwdaqj9sY23LIXHqbOk/gx7gjt+PSV8cGkioWYe/BsryN8ruQdJY3dkBCzvrLyQM CTfdvPZ/yDfz8eOrfR8Eni4x/ELomNWnlFqbmEV2fZH+9ng5aIdxy4ZsYiGJzqaD 8Pp1Uw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a0px6mcfa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Oct 2025 11:55:16 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7811a602576so6730659b3a.0 for ; Mon, 27 Oct 2025 04:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761566115; x=1762170915; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZWAM/1l3ob/3LqSmNYM1Kzzm3JAMnpjQt4pTVWbHtSU=; b=v4UfMs8Z+UvLk6G5225L5wQ3NSR94IOwtOi/Tl/rZxY/x4IJuKepI/8T6DaFmk+fgd PdCATqnJwZUkK5TAocs9ySfuRMIglfMuGjElcNF6CY6pAw7iH2ubfbNOZpgvQkX7EKW3 zI7V9p/s1/Brug3WNmDP4EH9r+BZiB8NegV3/uz4Hd/7xbT40Nwcj7apPFzo4RQ11ue/ vmJFFIWxFDZmvjo7OAzJfD6K5m2tU6jdi4POqan8LIh/miIYM6E/6Jg7e78EWmuw/tzC 2V9clSrWoohfV+AugvT9eoIPbT/LMH8l/z1TFD35iq+kL+04yuXCe44Oi97F6B4x74Zd BncQ== X-Forwarded-Encrypted: i=1; AJvYcCV7UmJ3rbceBlSaQw68OJSgijRD07uUJs6njovb9szdaKMISOM7gvmgqbyRHA5TrLU96576aCHVE17JPdiO+eEa@lists.infradead.org X-Gm-Message-State: AOJu0YxPdK/RGUHzf422nVLwI/6ZaC/C/QnEEGChuQdOFHNr4Hds5hgG MOaao8Fe0otp8udHL2BPIPhDnR19iSR1XWmQdMnU1ipM2ruAGU4Wbmvi9eIpUKyxOnrTCHt51hZ zZ3qffOfHfENQ2BZ3wfT5+zegSjhAfGGni3+Nn2GDwYiie2b8VBDuSD7yazo2NG0V3mSnyFKZk6 VCpg== X-Gm-Gg: ASbGncvR4PXbRpHfOzrx80NgKDPwNWReGx4alcsCwdsPJuF8bTODQJJVk6654kVR9Ja m2YYTpEabpR9txE4CTSy6cUkjc22f40VeLnQdKHk2ig1apPvYPEJpt9matlxXsYFUV9NFD8u5bS B8ixvsLOx5YfR8UHrlqMxBXEEDyJiYkyfGTQVTsiIKBkLGHavJGVefJZf5BZo0ZzK89nL7KbOyG iYW47JohmPMNFJ5+ST8iLLRMylyxcPbE3Wz6xOV7NAsP1vAe981XJK7BpMGbA9vHCubNFiBj7E9 Nl+Qol0kgkNkdSj/eowuv7rCxETok51SQvt5MsGRTV1o8A3JBhF3/5K50UMKWiJdMbb/4ZoCA/i MkcjTloXLK0DmKInBgfw0tidLMHAVIQvQ0vOEisYrf61Nzqdk+dLkveig01w= X-Received: by 2002:a05:6a00:1803:b0:792:5db2:73ac with SMTP id d2e1a72fcca58-7a28674d25emr12047807b3a.7.1761566115154; Mon, 27 Oct 2025 04:55:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGGkAcnkXHKQF/eHcUEuUAMP8k34i7aRfOMaE7hRoA4fzc286ygZftSP3+bEdiIYw6mSvSXQ== X-Received: by 2002:a05:6a00:1803:b0:792:5db2:73ac with SMTP id d2e1a72fcca58-7a28674d25emr12047778b3a.7.1761566114705; Mon, 27 Oct 2025 04:55:14 -0700 (PDT) Received: from [10.133.33.217] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a4387cbf00sm1985642b3a.2.2025.10.27.04.55.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Oct 2025 04:55:14 -0700 (PDT) Message-ID: <9d6d7641-d2c0-4629-944c-1bb88eddc486@oss.qualcomm.com> Date: Mon, 27 Oct 2025 19:55:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] remoteproc: mtk_scp: change the snprintf() checking To: Dan Carpenter , Bjorn Andersson Cc: Mathieu Poirier , Matthias Brugger , AngeloGioacchino Del Regno , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI3MDExMSBTYWx0ZWRfX1Qg89TCsiMcr covMuL5cFnp7bQdgQffCq0/DueCI2H9TWhn0/J4qxPn+h2+7OMN2cih+nH0GvNAZrB/HTXqlI26 dtrWMC2DwkcXNeATglfRoX8jSXRLBSrnePJkwEd3glaFDKS8HBiUwD5Z7kT9gKmhLFuGhWPxCBp FWrmXB7XmQ0ISurrJTv5OiQT6MDgjC/foeJdRlRFK5oifQop1f+OaTBFQ5BLCCh+CgL1/xN8kek eydi0rSNmK+wbtADLGQtkIX6YnQ1MfejuLPqlejx15hVjXeO7yGrA0Ikn9zZBJbLEG6nCRuxwvy fYc1drZ89B6ic8dft4D8ADvkgluWwNyD1fpQxjYIZVxf/lNC4FWDmXoUGWGY5MwVvXGURpIJ7I1 l3LAfvZlbD1qlZcaPv6LH9k34+crcA== X-Proofpoint-ORIG-GUID: SX9TaOX9z6OC5iIv2SpqgAW7qkCH9vZL X-Proofpoint-GUID: SX9TaOX9z6OC5iIv2SpqgAW7qkCH9vZL X-Authority-Analysis: v=2.4 cv=WqMm8Nfv c=1 sm=1 tr=0 ts=68ff5da4 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=9rX-9eNafPfUpquPNkAA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-27_05,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510270111 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251027_045518_241563_80753925 X-CRM114-Status: GOOD ( 26.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/27/2025 3:08 PM, Dan Carpenter wrote: > The snprintf() calls here work but they have several minor style issues: > > 1) It uses ARRAY_SIZE() which is the number of elements in an array. > Since were talking about char that works, but it's more common to > use sizeof() which is the number of bytes. > 2) The printf format is "%1d". The "1" ensures we always print at > least 1 character but since numbers all have at least 1 digit this > can be removed. > 3) The kernel implementation of snprintf() cannot return negative error > codes. Also these particular calls to snprintf() can't return zero > and the code to handle that zero return is sort of questionable. > 4) In the current kernel the only "core_id" we print is "0" but if it > was more than 9 then the output would be truncated so GCC complains. > Add an "a >= sizeof(scp_fw_file)" check for output which is too long. > > Signed-off-by: Dan Carpenter Reviewed-by: Zhongqiu Han > --- > v2: The v1 introduced a W=1 warning because of the truncation issue. > It's a false positive because GCC assumes that "core_id" can be > every possible value of int but actually it can only be zero. And > also generally, in the kernel, truncating is fine and it is fine > here too. > > But let's use that as an opportunity to do more cleanups. > > drivers/remoteproc/mtk_scp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 10e3f9eb8cd2..db8fd045468d 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1127,11 +1127,11 @@ static const char *scp_get_default_fw_path(struct device *dev, int core_id) > return ERR_PTR(-EINVAL); > > if (core_id >= 0) > - ret = snprintf(scp_fw_file, ARRAY_SIZE(scp_fw_file), "scp_c%1d", core_id); > + ret = snprintf(scp_fw_file, sizeof(scp_fw_file), "scp_c%d", core_id); > else > - ret = snprintf(scp_fw_file, ARRAY_SIZE(scp_fw_file), "scp"); > - if (ret <= 0) > - return ERR_PTR(ret); > + ret = snprintf(scp_fw_file, sizeof(scp_fw_file), "scp"); > + if (ret >= sizeof(scp_fw_file)) > + return ERR_PTR(-ENAMETOOLONG); > > /* Not using strchr here, as strlen of a const gets optimized by compiler */ > soc = &compatible[strlen("mediatek,")]; -- Thx and BRs, Zhongqiu Han