From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B71CC433F5 for ; Sat, 9 Oct 2021 09:26:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6BF260F57 for ; Sat, 9 Oct 2021 09:26:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6BF260F57 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Px7IDlg9hyU8+MmcIRCxe0wyhYuyTD8OGr5aneGjnI=; b=40JnN2TNiNJtXzu8G4CfpPljE3 U7kg8A4IGypYpafAnPqe9UNJYKftSSc/8Iu/JqeI1ilNYKWcrwTudM5UZiDJatZYAGYnMt4vgIw49 hbj6YHF+FVrzlcgoos7ljNtfUtEjPGx+K1uBxFiVD589PxNQOtSvvUTs2knwUEOME+Bje6i/sW6DS dp4HSsLH9YqqRm2YQvsk56r5uGeiR3J6DxXxmk5M+huw/Oy51JeA9CnuiMOxdtPbXb4rlI1x75y2k yQtxgnUpY3GEZ498xcLsdGA4IfozuYmlkcnXYOFR8azjpWZLozaeiBnPs44QzDWbyB/Se/Q5e2GOs W7EcNv2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ8ao-005MfF-DM; Sat, 09 Oct 2021 09:24:34 +0000 Received: from mx3.molgen.mpg.de ([141.14.17.11] helo=mx1.molgen.mpg.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZ8aj-005Mcw-0m; Sat, 09 Oct 2021 09:24:31 +0000 Received: from [192.168.0.2] (ip5f5aef39.dynamic.kabel-deutschland.de [95.90.239.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id ECA9861E5FE00; Sat, 9 Oct 2021 11:24:09 +0200 (CEST) Subject: Re: [PATCH 1/2] firmware: include drivers/firmware/Kconfig unconditionally To: Arnd Bergmann , Bjorn Andersson Cc: Arnd Bergmann , Mark Brown , Liam Girdwood , Charles Keepax , Simon Trimmer , Michael Ellerman , Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Geert Uytterhoeven , Linus Walleij , Andrew Morton , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org References: <20210928075216.4193128-1-arnd@kernel.org> From: Paul Menzel Message-ID: <9dedf9bb-5377-9f2c-cbb1-2a57b40493da@molgen.mpg.de> Date: Sat, 9 Oct 2021 11:24:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210928075216.4193128-1-arnd@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211009_022429_252068_57276B7F X-CRM114-Status: GOOD ( 35.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [Cc: +linuxppc-dev@lists.ozlabs.org] Dear Arnd, Am 28.09.21 um 09:50 schrieb Arnd Bergmann: > From: Arnd Bergmann > > Compile-testing drivers that require access to a firmware layer > fails when that firmware symbol is unavailable. This happened > twice this week: > > - My proposed to change to rework the QCOM_SCM firmware symbol > broke on ppc64 and others. > > - The cs_dsp firmware patch added device specific firmware loader > into drivers/firmware, which broke on the same set of > architectures. > > We should probably do the same thing for other subsystems as well, > but fix this one first as this is a dependency for other patches > getting merged. > > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Charles Keepax > Cc: Simon Trimmer > Cc: Arnd Bergmann > Cc: Michael Ellerman > Signed-off-by: Arnd Bergmann > --- > Not sure how we'd want to merge this patch, if two other things > need it. I'd prefer to merge it along with the QCOM_SCM change > through the soc tree, but that leaves the cirrus firmware broken > unless we also merge it the same way (rather than through ASoC > as it is now). > > Alternatively, we can try to find a different home for the Cirrus > firmware to decouple the two problems. I'd argue that it's actually > misplaced here, as drivers/firmware is meant for kernel code that > interfaces with system firmware, not for device drivers to load > their own firmware blobs from user space. > --- > arch/arm/Kconfig | 2 -- > arch/arm64/Kconfig | 2 -- > arch/ia64/Kconfig | 2 -- > arch/mips/Kconfig | 2 -- > arch/parisc/Kconfig | 2 -- > arch/riscv/Kconfig | 2 -- > arch/x86/Kconfig | 2 -- > drivers/Kconfig | 2 ++ > 8 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index ad96f3dd7e83..194d10bbff9e 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1993,8 +1993,6 @@ config ARCH_HIBERNATION_POSSIBLE > > endmenu > > -source "drivers/firmware/Kconfig" > - > if CRYPTO > source "arch/arm/crypto/Kconfig" > endif > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index ebb49585a63f..8749517482ae 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1931,8 +1931,6 @@ source "drivers/cpufreq/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/acpi/Kconfig" > > source "arch/arm64/kvm/Kconfig" > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index 045792cde481..1e33666fa679 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -388,8 +388,6 @@ config CRASH_DUMP > help > Generate crash dump after being started by kexec. > > -source "drivers/firmware/Kconfig" > - > endmenu > > menu "Power management and ACPI options" > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 771ca53af06d..6b8f591c5054 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -3316,8 +3316,6 @@ source "drivers/cpuidle/Kconfig" > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "arch/mips/kvm/Kconfig" > > source "arch/mips/vdso/Kconfig" > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index 4742b6f169b7..27a8b49af11f 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -384,6 +384,4 @@ config KEXEC_FILE > > endmenu > > -source "drivers/firmware/Kconfig" > - > source "drivers/parisc/Kconfig" > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 301a54233c7e..6a6fa9e976d5 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -561,5 +561,3 @@ menu "Power management options" > source "kernel/power/Kconfig" > > endmenu > - > -source "drivers/firmware/Kconfig" > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index e5ba8afd29a0..5dcec5f13a82 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2834,8 +2834,6 @@ config HAVE_ATOMIC_IOMAP > def_bool y > depends on X86_32 > > -source "drivers/firmware/Kconfig" > - > source "arch/x86/kvm/Kconfig" > > source "arch/x86/Kconfig.assembler" > diff --git a/drivers/Kconfig b/drivers/Kconfig > index 30d2db37cc87..0d399ddaa185 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -17,6 +17,8 @@ source "drivers/bus/Kconfig" > > source "drivers/connector/Kconfig" > > +source "drivers/firmware/Kconfig" > + > source "drivers/gnss/Kconfig" > > source "drivers/mtd/Kconfig" > With this change, I have the new entries below in my .config: ``` $ diff -u .config.old .config --- .config.old 2021-10-07 11:38:39.544000000 +0200 +++ .config 2021-10-09 10:02:03.156000000 +0200 @@ -1992,6 +1992,25 @@ CONFIG_CONNECTOR=y CONFIG_PROC_EVENTS=y + +# +# Firmware Drivers +# + +# +# ARM System Control and Management Interface Protocol +# +# end of ARM System Control and Management Interface Protocol + +# CONFIG_FIRMWARE_MEMMAP is not set +# CONFIG_GOOGLE_FIRMWARE is not set + +# +# Tegra firmware driver +# +# end of Tegra firmware driver +# end of Firmware Drivers + # CONFIG_GNSS is not set CONFIG_MTD=m # CONFIG_MTD_TESTS is not set ``` No idea if the entries could be hidden for platforms not supporting them. ARM System Control and Management Interface Protocol ---- [ ] Add firmware-provided memory map to sysfs [ ] Google Firmware Drivers ---- Tegra firmware driver ---- Kind regards, Paul _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel