From: Robin Murphy <robin.murphy@arm.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/3] perf: arm-ni: Remove spurious NULL in attribute_group definition
Date: Mon, 18 Nov 2024 15:23:47 +0000 [thread overview]
Message-ID: <9e04fa8f-7c08-49a9-9647-f8d1f183ffcf@arm.com> (raw)
In-Reply-To: <20241118-sysfs-const-attribute_group-fixes-v1-1-48e0b0ad8cba@weissschuh.net>
On 2024-11-18 3:02 pm, Thomas Weißschuh wrote:
> This NULL value is most-likely a copy-paste error from an array
> definition. So far the NULL didn't have any effect.
> As there will be a union in struct attribute_group at this location,
> it will trigger a compiler warning.
Acked-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/perf/arm-ni.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
> index 90fcfe693439ef3e18e23c6351433ac3c5ea78b5..fd7a5e60e96302fada29cd44e7bf9c582e93e4ce 100644
> --- a/drivers/perf/arm-ni.c
> +++ b/drivers/perf/arm-ni.c
> @@ -247,7 +247,6 @@ static struct attribute *arm_ni_other_attrs[] = {
>
> static const struct attribute_group arm_ni_other_attr_group = {
> .attrs = arm_ni_other_attrs,
> - NULL
> };
>
> static const struct attribute_group *arm_ni_attr_groups[] = {
>
next prev parent reply other threads:[~2024-11-18 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 15:02 [PATCH 0/3] sysfs: treewide: Remove spurious NULL in attribute_group definition Thomas Weißschuh
2024-11-18 15:02 ` [PATCH 1/3] perf: arm-ni: " Thomas Weißschuh
2024-11-18 15:23 ` Robin Murphy [this message]
2024-11-18 15:02 ` [PATCH 2/3] s390/con3215: " Thomas Weißschuh
2024-11-18 15:02 ` [PATCH 3/3] cpu: " Thomas Weißschuh
2024-11-18 15:22 ` [PATCH 0/3] sysfs: treewide: " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e04fa8f-7c08-49a9-9647-f8d1f183ffcf@arm.com \
--to=robin.murphy@arm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox