From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BB4606A31A for ; Tue, 27 Oct 2026 03:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uPu0jy+f; dkim=pass (1024-bit key, unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=Ve8Rl2Ol DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=YDlSsGkPiCD2jaBiZMMJ7ZD6fj3FrxVPQZM0mqrVkUo=; b=uPu0jy+ffdRb2V awfTo8qScn2AJW33cJF4p08M44aIup20Qe6GDizYaHsmknECPMfVK3AAz/VKXLnWfq8k9YPB5x/Lf APpmBgHa2nlqgecXJeM5cUd/X8LO2bm0/vOo6gJ6kseib2TcoKhqHz6v719yOeCUdHtMhYZe25syw 8xuKohGRsnJToTrPY6BfLbIt0cOX7GLF0SJzPiusWM6vpw1k2v2jYsVY2JQqPh0YwfcVlSRIyrq5F 4YZALYqIpBHy0veJqXLqkAWwH4EyRMCQYJBN0Kxu45sSD8dRyLeNIhB8bAp4ojNS8/zLK2aw50rxh +QVDSk295mJ7hk5L87Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLY4r-00000003hdU-31hO; Tue, 27 Oct 2026 03:42:21 +0000 Received: from canpmsgout08.his.huawei.com ([113.46.200.223]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLY4n-00000003hcS-2qg2 for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2026 03:42:20 +0000 dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=YDlSsGkPiCD2jaBiZMMJ7ZD6fj3FrxVPQZM0mqrVkUo=; b=Ve8Rl2OlROcGd6JfjoBap6gzrYog0dukM4EGqiglM7cUOhIPim1yGQfqo7DvPO8e7s29+WLz5 e5xFnapvOYPiJHZ/sIQWb1FedKQ4KAgvUgpsBE7MLMvukG2c8kUdX4Pcv+HFRULe+j5z+jgdkTf xGLQB0/tbrmqdxxXrOySlpc= Received: from mail.maildlp.com (unknown [172.19.163.15]) by canpmsgout08.his.huawei.com (SkyGuard) with ESMTPS id 4jDGWq33R0zmV7W; Tue, 27 Oct 2026 11:41:59 +0800 (CST) Received: from kwepemk200008.china.huawei.com (unknown [7.202.194.74]) by mail.maildlp.com (Postfix) with ESMTPS id 00BFA40592; Tue, 27 Oct 2026 11:42:05 +0800 (CST) Received: from [10.67.110.68] (10.67.110.68) by kwepemk200008.china.huawei.com (7.202.194.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 27 Oct 2026 11:42:04 +0800 Message-ID: <9e0521af-4ae2-4a53-bbd5-2d86cceb69c3@huawei.com> Date: Tue, 27 Oct 2026 11:42:03 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 00/10] arm_mpam: resctrl: Separate MPAM domains To: Reinette Chatre , , , , CC: , , , , , , References: From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemk200008.china.huawei.com (7.202.194.74) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261026_204218_031207_E0F939C5 X-CRM114-Status: GOOD ( 26.35 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-22.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 在 2026/10/20 6:07, Reinette Chatre 写道: > RFC v1: https://lore.kernel.org/lkml/85ca29e89eacf12cfa7071249419e7cadb8f0691.1788220029.git.reinette.chatre@intel.com/ > > The MPAM driver represents a resctrl domain with a single structure, > struct mpam_resctrl_dom, that holds both a control domain and a > monitoring domain. On a system that supports both allocation and > monitoring, one instance is created for each domain and its two > domains are added to the resource's control and monitoring domain > lists. > > Holding both domains in one structure requires control and monitoring > to be done at the same scope, and ties each control domain to a > monitoring domain. This does not fit the proposed support for multiple > controls per resource [1]. There, each control of a resource, for > example a "min" and a "max" memory bandwidth control, has its own list > of control domains while the resource keeps a single list of > monitoring domains. With one structure for both, every control domain > would come with a monitoring domain of its own, which does not reflect > the resource. > > This series gives control and monitoring domains their own structures, > set up and torn down independently as CPUs come online and go offline, > in preparation for supporting multiple controls per resource. Along > the way it stops failing CPU online when a domain cannot be set up, > and adds checks when setting up a monitoring domain. > > 1-2 Preparatory cleanups of domain allocation > 3 Do not fail CPU online when domain setup fails > 4-6 Separate the control and monitoring domain structures > 7-9 Checks when setting up a monitoring domain > 10 Comment update, kept separate for review > > An earlier version of the domain split was posted on its own [2]. This > version incorporates the feedback from that discussion. It gives each > type of domain its own structure instead of duplicating the shared > one, sets up each domain independently instead of undoing one domain > when setting up the other fails, and adds the checks in patches 8 and > 9. > > Patch 7 turns a WARN_ON_ONCE(0) into a warning that fires. It is a > separate patch because it is not clear whether the silent failure was > intended. If it was, the patch can instead drop the dead > WARN_ON_ONCE(). > > This is an RFC because I am only able to compile test MPAM changes, > which is also why the patches are small and each change is justified > on its own. Patches can be squashed if preferred, for example patch 10 > into patches 5 and 9. Testing on MPAM hardware would be greatly > appreciated, as is any other feedback. Hi Reinette, I tested it on a QEMU with MPAM rebased on v7.3-rc6 and all pass: 1、Resctrl mounts，L3/L2 each report 32 closids (control IDs) 2、Cache and memory bandwidth controls 3、Priority, min, max, option and hard-limit: write, read back, and the emulated hardware shows the same value 4、CDP mode and usage/bandwidth counters 5、All builds pass without warnings: arm64/x86_64, debug on/off, self-tests on/off, resctrl off, ACPI off Test cases: https://github.com/ruanjinjie-eng/mpam_testcase/tree/qemu Tested-by: Jinjie Ruan ruanjinjie@huawei.com > > The series is based on the for-next/mpam branch of the arm64 tree: > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > [1] https://lore.kernel.org/lkml/d258a32f-12d5-464d-abe9-4720fb3e44b3@intel.com/ > [2] https://lore.kernel.org/lkml/85ca29e89eacf12cfa7071249419e7cadb8f0691.1788220029.git.reinette.chatre@intel.com/ > > Reinette Chatre (10): > arm_mpam: resctrl: Use find_component() when allocating a domain > arm_mpam: resctrl: Rename ctrl_comp in mpam_resctrl_alloc_domain() > arm_mpam: resctrl: Do not fail CPU online when domain setup fails > arm_mpam: resctrl: Split control and monitoring domain setup into > helpers > arm_mpam: resctrl: Give the monitoring domain its own structure > arm_mpam: resctrl: Rename struct mpam_resctrl_dom to > mpam_resctrl_ctrl_dom > arm_mpam: resctrl: Warn when no monitoring component is found for a > CPU > arm_mpam: resctrl: Require a component for each monitoring event > arm_mpam: resctrl: Require monitoring components to cover the same > CPUs > arm_mpam: resctrl: Update the comment on monitoring domain setup > > drivers/resctrl/mpam_devices.c | 2 +- > drivers/resctrl/mpam_internal.h | 11 +- > drivers/resctrl/mpam_resctrl.c | 325 +++++++++++++++++--------------- > 3 files changed, 181 insertions(+), 157 deletions(-) > > > base-commit: 8ea457f746d915d55f78b43d33b1cd618f3d93ad -- Best regards, Jinjie