From: Florian Fainelli <f.fainelli@gmail.com>
To: Brian Norris <briannorris@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
linux-mmc@vger.kernel.org, Al Cooper <alcooperx@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Florian Fainelli <f.fainelli@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Thierry Reding <thierry.reding@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, Haibo Chen <haibo.chen@nxp.com>,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Faiz Abbas <faiz_abbas@ti.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v3 3/7] mmc: sdhci-brcmstb: Fix SDHCI_RESET_ALL for CQHCI
Date: Mon, 24 Oct 2022 11:04:42 -0700 [thread overview]
Message-ID: <9e15ffc5-fda9-b2c2-97f1-866c51bde113@gmail.com> (raw)
In-Reply-To: <20221024105229.v3.3.I6a715feab6d01f760455865e968ecf0d85036018@changeid>
On 10/24/22 10:54, Brian Norris wrote:
> [[ NOTE: this is completely untested by the author, but included solely
> because, as noted in commit df57d73276b8 ("mmc: sdhci-pci: Fix
> SDHCI_RESET_ALL for CQHCI for Intel GLK-based controllers"), "other
> drivers using CQHCI might benefit from a similar change, if they
> also have CQHCI reset by SDHCI_RESET_ALL." We've now seen the same
> bug on at least MSM, Arasan, and Intel hardware. ]]
>
> SDHCI_RESET_ALL resets will reset the hardware CQE state, but we aren't
> tracking that properly in software. When out of sync, we may trigger
> various timeouts.
>
> It's not typical to perform resets while CQE is enabled, but this may
> occur in some suspend or error recovery scenarios.
>
> Include this fix by way of the new sdhci_and_cqhci_reset() helper.
>
> Fixes: d46ba2d17f90 ("mmc: sdhci-brcmstb: Add support for Command Queuing (CQE)")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-24 18:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 17:54 [PATCH v3 0/7] mmc: sdhci controllers: Fix SDHCI_RESET_ALL for CQHCI Brian Norris
2022-10-24 17:54 ` [PATCH v3 1/7] mmc: cqhci: Provide helper for resetting both SDHCI and CQHCI Brian Norris
2022-10-24 18:02 ` Florian Fainelli
2022-10-25 13:09 ` Adrian Hunter
2022-10-24 17:54 ` [PATCH v3 2/7] mmc: sdhci-of-arasan: Fix SDHCI_RESET_ALL for CQHCI Brian Norris
2022-10-25 13:09 ` Adrian Hunter
2022-10-24 17:54 ` [PATCH v3 3/7] mmc: sdhci-brcmstb: " Brian Norris
2022-10-24 18:04 ` Florian Fainelli [this message]
2022-10-25 13:09 ` Adrian Hunter
2022-10-24 17:54 ` [PATCH v3 4/7] mms: sdhci-esdhc-imx: " Brian Norris
2022-10-25 13:10 ` Adrian Hunter
2022-10-24 17:54 ` [PATCH v3 5/7] mmc: sdhci-tegra: " Brian Norris
2022-10-25 13:10 ` Adrian Hunter
2022-10-24 17:55 ` [PATCH v3 6/7] mmc: sdhci_am654: " Brian Norris
2022-10-25 13:10 ` Adrian Hunter
2022-10-25 21:45 ` Brian Norris
2022-10-25 21:53 ` Florian Fainelli
2022-10-25 22:26 ` Brian Norris
2022-10-25 23:29 ` Florian Fainelli
2022-10-26 5:36 ` Adrian Hunter
2022-10-26 18:18 ` Brian Norris
2022-10-26 18:23 ` Florian Fainelli
2022-10-27 5:45 ` Adrian Hunter
2022-10-24 17:55 ` [PATCH v3 7/7] mmc: sdhci-*: Convert drivers to new sdhci_and_cqhci_reset() Brian Norris
2022-10-25 13:10 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e15ffc5-fda9-b2c2-97f1-866c51bde113@gmail.com \
--to=f.fainelli@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alcooperx@gmail.com \
--cc=andersson@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=briannorris@chromium.org \
--cc=faiz_abbas@ti.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).