From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 775DDECAAA1 for ; Mon, 24 Oct 2022 18:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FVDR/mylWeTc/IeF8DIZY+WZgae7kHJHGvCfolGGQOY=; b=nHNwfEJTT79Wgm 3+Rx9qQs19zKA3cRoZLwIiJmT7DZEqZ2A0DBGjKD4bzjmpnC3DxeQqs39vlW4GdXdWuzM/RF1G8vs 1dD7yAE/JpM+75msJyttj2gUOGCgvvY3pzgNitTn49S3Zpx3jFO+K2P12OYA9fQwN9f38Phseo33g hbf8CRKjllNqpsl7W6+IMe226uT0eBpJCCQ1H1AXclyWRdNnDKxxSf4kmSfePm0+TpwUNWNIe30UI utLn09jxzW1NPRs7XrNc7+vdsu1DhbDxawEVhdkdll8PZZEJDUjtV2xr2yfe9nZqM3oqdY1zvrZ3j cA7AfdG7F+LEruedkkSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1on1or-002bRD-Oh; Mon, 24 Oct 2022 18:05:02 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1on1op-002bPR-4r for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 18:05:00 +0000 Received: by mail-qk1-x72f.google.com with SMTP id t25so6575279qkm.2 for ; Mon, 24 Oct 2022 11:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8uZ3VwfktP6MlXqcTSmXnIQiEYTG6oe41z15jnyDxAg=; b=hUQNLA+Bt+iC3EXWYW6u4ZiXQN+8gSkbnmx8T2s8gwIyjYMlb9xie2OOJHwqqdlE6g TPMX8YiSGrjcgbVnTCnFsXG5p9TyBfNZW9cG8k8CcqbzN2bmQnheWRACOBZ/d0Ypyji3 rAeT3VRnZNw4YbeuVXZ3vEOKtNVMeNwXu/MjHy95n+2bxkdGNTOtyJszmv75cO39QUVX 3tMEuxZT7eSOq8Es/EwqZssEHzAuhydL/i7aK2CmAmpvk3RmjxlZZXCchdX4A7oDcSBj OT7wE6byf63cJL5bI9VHwdG17EIHCSUqDNg2p48fauR7p1cAjQNOcc/NytgEWglrxAdz RDuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uZ3VwfktP6MlXqcTSmXnIQiEYTG6oe41z15jnyDxAg=; b=476Pjqy7M4XDh//5pub8FAYm0qeYfIIQQgEXTCyIgoVAy8KsegWyIEM+lHlqXYc+BW SiL4k+FjNNfZwVy5JqLXoz7jnmpg9WvPC8x6ZIH9TMjWhPHWlYTTWgBqpesngKyPAXiz Q++ZgsPk/WHMJR/liIP/X178TKOR0iE52o/OnENxr1kYbEYsaeE5PyS6JL/aXIZ/buXt 5gE7W4AQcxk4o7sGUeOJ3iAu+NlBIC1bAzHI47dG5CdCyAcok6BLMqPKXqD6MNDh1BjU 5OPhLMZLddAk+AYh3D47zz11DpvuH+6+4IjxW0slXMOEeZ8HtryN4z3V0ik2ThniilLw fHHw== X-Gm-Message-State: ACrzQf2DqkuAEldg7BB3bHqip49Y3Y7bcnzUQ4bmWsBOUOFGNabxELKe LJHA/yqp40BqB0lgFmXnL5k= X-Google-Smtp-Source: AMsMyM6VD3e4iOCRwH+WEfJk7Le9i9P05UDL6cK9G/xPqVkJKTVIOyBY4IzI1tu67LqNtF/xB4eU0A== X-Received: by 2002:a05:620a:24d5:b0:6ee:d4bb:e5ba with SMTP id m21-20020a05620a24d500b006eed4bbe5bamr23818286qkn.457.1666634695655; Mon, 24 Oct 2022 11:04:55 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id e10-20020a05622a110a00b0039cb9ef50b5sm335003qty.26.2022.10.24.11.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 11:04:55 -0700 (PDT) Message-ID: <9e15ffc5-fda9-b2c2-97f1-866c51bde113@gmail.com> Date: Mon, 24 Oct 2022 11:04:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 3/7] mmc: sdhci-brcmstb: Fix SDHCI_RESET_ALL for CQHCI Content-Language: en-US To: Brian Norris , Ulf Hansson Cc: Shawn Lin , linux-mmc@vger.kernel.org, Al Cooper , Bjorn Andersson , Sowjanya Komatineni , Broadcom internal kernel review list , Sascha Hauer , Konrad Dybcio , Florian Fainelli , NXP Linux Team , Thierry Reding , Fabio Estevam , Michal Simek , linux-kernel@vger.kernel.org, Shawn Guo , Adrian Hunter , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Haibo Chen , Andy Gross , linux-arm-kernel@lists.infradead.org, Faiz Abbas , Jonathan Hunter References: <20221024175501.2265400-1-briannorris@chromium.org> <20221024105229.v3.3.I6a715feab6d01f760455865e968ecf0d85036018@changeid> From: Florian Fainelli In-Reply-To: <20221024105229.v3.3.I6a715feab6d01f760455865e968ecf0d85036018@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_110459_242936_2B808645 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/24/22 10:54, Brian Norris wrote: > [[ NOTE: this is completely untested by the author, but included solely > because, as noted in commit df57d73276b8 ("mmc: sdhci-pci: Fix > SDHCI_RESET_ALL for CQHCI for Intel GLK-based controllers"), "other > drivers using CQHCI might benefit from a similar change, if they > also have CQHCI reset by SDHCI_RESET_ALL." We've now seen the same > bug on at least MSM, Arasan, and Intel hardware. ]] > > SDHCI_RESET_ALL resets will reset the hardware CQE state, but we aren't > tracking that properly in software. When out of sync, we may trigger > various timeouts. > > It's not typical to perform resets while CQE is enabled, but this may > occur in some suspend or error recovery scenarios. > > Include this fix by way of the new sdhci_and_cqhci_reset() helper. > > Fixes: d46ba2d17f90 ("mmc: sdhci-brcmstb: Add support for Command Queuing (CQE)") > Signed-off-by: Brian Norris Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel