From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD23CE7FDFC for ; Tue, 3 Feb 2026 01:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=80iknK13Kq+wx2P2fwBcvk34JAYKQJmD7fJDTp2xaOU=; b=bgFnkw9idXUNnhs1hdc/d9v8ee xKkwnwiuhCVY+V5NBa/988MfI/wgjJVvnJPROkcz6tX+Awt/WLU1wUUVSnA9jaBniGyeg4V2GMQbJ phbWLt40Swi57c2FRn4eOgqZrGFFiA2JLS4rc6hhhxgttC9RSGN9SAbPbE95NeqyOwRlqf3ZOjxqA VwBY6Fc4mmP4tfnezS6eYyTcKNxTCWTkBf1TvlQ8EL/RMIjimB87LxiFCsTwiSlmOEEVVyESqw3Ff lYh/vG+zvchxbUKRNZkvDNLaIy0RaaB/woE+dj0MbIRKeacneeV/x58Ud4q0uv1TWntYhZYWQP7XP JYpo/EyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vn5G9-00000005qor-49pO; Tue, 03 Feb 2026 01:31:17 +0000 Received: from mail-m3297.qiye.163.com ([220.197.32.97]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vn5G6-00000005qnm-1pQ7; Tue, 03 Feb 2026 01:31:16 +0000 Received: from [172.16.12.43] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 32e1603b0; Tue, 3 Feb 2026 09:31:06 +0800 (GMT+08:00) Message-ID: <9e1da672-a52d-4ec3-a20a-fe6f8ca15496@rock-chips.com> Date: Tue, 3 Feb 2026 09:31:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 05/18] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use From: Damon Ding To: Luca Ceresoli , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, dmitry.baryshkov@oss.qualcomm.com Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, p.zabel@pengutronix.de, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, dianders@chromium.org, m.szyprowski@samsung.com, jani.nikula@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20251217093321.3108939-1-damon.ding@rock-chips.com> <20251217093321.3108939-6-damon.ding@rock-chips.com> <7256ecf9-b10b-428c-a1a6-e35e80a686ed@rock-chips.com> Content-Language: en-US In-Reply-To: <7256ecf9-b10b-428c-a1a6-e35e80a686ed@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9c211febb503a3kunmdf9f046968496a X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQ0waTVYaHxlIHUhDGEJNGEJWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpKQk 1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=PNeLKk6IXR55KNlke+4USCf5fom3f/N3+2kARL8pH0JwEPUlW60pXl+rtEoTZiX5O8yGuHc/m5vU/SaCJ1Gp07bJlpVKV7LVXgo8PO9QLI5HrJU160XWWzJRmQP51/j2tw/tfdjC+39EH3iKM0kT7IBxukZVeDjGby7EtvavdRI=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=80iknK13Kq+wx2P2fwBcvk34JAYKQJmD7fJDTp2xaOU=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260202_173114_964728_CDFC2865 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 2/2/2026 10:54 AM, Damon Ding wrote: > Hi Luca, > > On 1/31/2026 8:33 PM, Luca Ceresoli wrote: >> Hello Damon, Dmitry, >> >> On Wed Dec 17, 2025 at 10:33 AM CET, Damon Ding wrote: >>> As suggested by Dmitry, the DRM legacy bridge driver can be pulled >>> out of imx/ subdir for multi-platform use. The driver is also renamed >>> to make it more generic and suitable for platforms other than i.MX. >>> >>> Signed-off-by: Damon Ding >>> Suggested-by: Dmitry Baryshkov >>> Tested-by: Marek Szyprowski >>> >>> --- >>> >>> Changes in v7: >>> - Rename legacy-bridge to of-display-mode-bridge. >>> - Remove unnecessary API drm_bridge_is_legacy(). >> >> ... >> >>> --- a/drivers/gpu/drm/bridge/Kconfig >>> +++ b/drivers/gpu/drm/bridge/Kconfig >>> @@ -244,6 +244,16 @@ config DRM_NXP_PTN3460 >>>       help >>>         NXP PTN3460 eDP-LVDS bridge chip driver. >>> >>> +config DRM_OF_DISPLAY_MODE_BRIDGE >>> +    tristate >>> +    depends on DRM_BRIDGE && OF >>> +    help >>> +      This is a DRM bridge implementation that uses >>> of_get_drm_display_mode >>> +      to acquire display mode. >>> + >>> +      Newer designs should not use this bridge and should use proper >>> panel >>> +      driver instead. >> >> "Newer designs should not use this bridge", but in patch 8 you are >> introducing a new use ot devm_drm_of_display_mode_bridge(). Shouldn't you >> instead "use proper panel driver instead" in patch 8? >> >> Can you point to the conversation where the converstaion where Dmitry >> suggested this change? Maybe it already contains the answer to my >> qustion. Also adding a link to that conversation in the commit message >> woule be useful. >> > > First of all, thanks for your reviews on this patch series. > > link: https://lore.kernel.org/all/ > xwenycscalzdlpuxytorbiyvej3k7pv3lhxwtadilxq65ipwsv@x5rxm53w5e22/ > > I think it may be a misleading issue caused by directly copying the > previous Kconfig description. Now that the new > devm_drm_of_display_mode_bridge() helper has been added, drivers using > the panel-bridge framework can rely on it to maintain compatibility with > legacy display mode parsing. > > It would be better to update the comment as follows: > > This is a DRM bridge implementation that uses of_get_drm_display_mode to > acquire display mode. > > It exists for compatibility with legacy display mode parsing, in order > to conform to the panel-bridge framework. > Dmitry, what's you take on this? Best regards, Damon