From: James Clark <james.clark@linaro.org>
To: Yicong Yang <yangyicong@huawei.com>,
suzuki.poulose@arm.com, mike.leach@linaro.org,
coresight@lists.linaro.org
Cc: jonathan.cameron@huawei.com, prime.zeng@hisilicon.com,
hejunhao3@huawei.com, linuxarm@huawei.com,
yangyicong@hisilicon.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] coresight: tmc: Add missing doc of tmc_drvdata::reading
Date: Thu, 14 Nov 2024 10:32:37 +0000 [thread overview]
Message-ID: <9e3174ba-2384-4260-b1a0-059aab2f393b@linaro.org> (raw)
In-Reply-To: <20241114081653.24328-2-yangyicong@huawei.com>
On 14/11/2024 8:16 am, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> tmc_drvdata::reading is used to indicate whether a reading process
> is performed through /dev/xyz.tmc. Document it.
>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> drivers/hwtracing/coresight/coresight-tmc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h
> index 2671926be62a..fdf7955e7350 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc.h
> +++ b/drivers/hwtracing/coresight/coresight-tmc.h
> @@ -174,6 +174,7 @@ struct etr_buf {
> * @pid: Process ID of the process that owns the session that is using
> * this component. For example this would be the pid of the Perf
> * process.
> + * @reading: buffer's in the reading through "/dev/xyz.tmc" entry
> * @buf: Snapshot of the trace data for ETF/ETB.
> * @etr_buf: details of buffer used in TMC-ETR
> * @len: size of the available trace for ETF/ETB.
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2024-11-14 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 8:16 [PATCH 1/2] coresight: tmc: Don't change the buffer size if it's in use Yicong Yang
2024-11-14 8:16 ` [PATCH 2/2] coresight: tmc: Add missing doc of tmc_drvdata::reading Yicong Yang
2024-11-14 10:32 ` James Clark [this message]
2024-11-14 10:30 ` [PATCH 1/2] coresight: tmc: Don't change the buffer size if it's in use James Clark
2024-11-14 14:51 ` Yicong Yang
2024-11-14 15:26 ` James Clark
2024-11-14 17:20 ` Suzuki K Poulose
2024-11-19 12:40 ` Yicong Yang
2024-11-19 13:52 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e3174ba-2384-4260-b1a0-059aab2f393b@linaro.org \
--to=james.clark@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=hejunhao3@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=mike.leach@linaro.org \
--cc=prime.zeng@hisilicon.com \
--cc=suzuki.poulose@arm.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox