From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCB4AE81DE8 for ; Fri, 6 Oct 2023 11:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QVkWX9lvZh6Cmg2qYwFR+i5dBSpmTZzsNG71PxJuHVE=; b=l0tDuHdGwFjjYz m9FXmx8rfr+u+a4GrhnQdkL7RlQeB/2edT6MYgnM6GmpR9/QpP7I5AaJ+7WOHF2/WyfLg43TdxLRr 0dMWSl7/MK1PiN8/U/qWNuNm6E8qRUM5/yghwANoiM7YSEsbPVzM2a1a7BvnCU7u24zJOHYRM98xA ik2v7O/fXfK0HFkPopElDMiAz1TxyKC6jpD4+almhFYNfzycR2D8hHgzcIu6vamXv9ut6/17PFu2B abl0kWN+rdQi1K/4jLyQJrhkYAuqP6oIT+GhO9EIQHbKzGgYxf1CzfjnHFE3ou8KNC+OeYQruyQAL ikF5f5Eis2hdUc7mVGNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qojNx-005ip9-3A; Fri, 06 Oct 2023 11:52:49 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qojNu-005iof-0L for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 11:52:48 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 396Bqf8s103787; Fri, 6 Oct 2023 06:52:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696593161; bh=tr9c/rUYC9mgA9/TX+5lWnVnFOuxhCvAshbr7tR4Pfw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=cMevrau7Cn7zoVIiXLjxat/qxpGboqYR18QPkPVI0p5EGPV+TnsnPtV6rBTxyJxGJ FJJtoC1vzqw+ktTNS7dieka8UJ3mNQooUh4okE1dahmrleCOGah7Xqgbc9V/RxnU2X +JwCDy+QPv+hV9p8vUExtMMvSMlwdx9ZMrGjgGWU= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 396BqfZW120393 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Oct 2023 06:52:41 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 6 Oct 2023 06:52:41 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 6 Oct 2023 06:52:41 -0500 Received: from [10.249.131.134] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 396Bqb8D083191; Fri, 6 Oct 2023 06:52:38 -0500 Message-ID: <9e3489f0-98f4-48ac-89a8-ea4ad3ee115c@ti.com> Date: Fri, 6 Oct 2023 17:22:35 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the mcu domain watchdog instances Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , References: <20231006042901.6474-1-j-keerthy@ti.com> <20231006042901.6474-6-j-keerthy@ti.com> <20231006113410.tibvxxkeuujqnbv4@evolution> From: "J, KEERTHY" In-Reply-To: <20231006113410.tibvxxkeuujqnbv4@evolution> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_045246_224073_567E8C0E X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/6/2023 5:04 PM, Nishanth Menon wrote: > On 09:58-20231006, Keerthy wrote: >> There are totally 2 instances of watchdog module in MCU domain. >> These instances are coupled with the MCU domain R5F instances. > >> Disabling them as they are not used by Linux. > Device tree is hardware description - not tied to how Linux uses it. > > Reason these wdts are disabled by default is because they are tightly > coupled with R5Fs. > >> >> Signed-off-by: Keerthy >> --- >> .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 24 +++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> index a7b5c4cb7d3e..809a0b1cf038 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi >> @@ -714,4 +714,28 @@ >> ti,esm-pins = <63>; >> bootph-pre-ram; >> }; >> + Nishanth, Below i have addressed the coupling with R5Fs & MCU domains watcdogs. >> + /* >> + * The 2 RTI instances are couple with MCU R5Fs so keeping them >> + * disabled as these will be used by their respective firmware >> + */ >> + mcu_watchdog0: watchdog@40600000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40600000 0x00 0x100>; >> + clocks = <&k3_clks 367 1>; >> + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 367 0>; >> + assigned-clock-parents = <&k3_clks 367 4>; >> + status = "disabled"; >> + }; >> + >> + mcu_watchdog1: watchdog@40610000 { >> + compatible = "ti,j7-rti-wdt"; >> + reg = <0x00 0x40610000 0x00 0x100>; >> + clocks = <&k3_clks 368 1>; >> + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>; >> + assigned-clocks = <&k3_clks 368 0>; >> + assigned-clock-parents = <&k3_clks 368 4>; > > Please DONOT ignore the review comments - I did ask the documentation in > dts as well. reason being that this is what people will see rather than > dig up the commit log. it should be intutive when reading the dts why > nodes are disabled by default Vs the standard of leaving it enabled by > default. Given esp that these peripherals do not have anything to do > with board semantics (pinmux or something similar) to be complete. As mentioned above. I added single comment for addressing both the watchdogs. - Keerthy > >> + status = "disabled"; >> + }; >> }; >> -- >> 2.17.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel