From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B955CAC592 for ; Fri, 19 Sep 2025 16:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V9g8/b377ZgIX2okreMIo9dHbgozzQMEamJx+ALsihI=; b=OZ9F1SC0lZIcr6Mxxs4FSMeYBD 6q4jrTNwjpBqZF89EgPMaGvjcr7Po9l9/IReFDWeOGuB+Zcn3JNA0X0UACoR2iYLMIc90Cp2OXSp0 /ywOMMeg/TgB7tH6tSrs0MaOtKb5nrFnf0jlh4FeCrFpf9Yzcw/Do9cOA3IpTCO7PZgZKzvUuXwxH wv86oD9QUCKXodZYMw9t4Lw5yB+CxS2QymsGGbGyPKfcRG+HecaD4PQjku4H3P99pAKPZZAbCdGRl MsVUXJKvh6b94vnJILvAy1M51O20OxHZbHZmKZwLnVeQcEie9V61NRzhFG4X1FTE0umzNCBfP/x7C OU4rg3rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzdh8-00000003Trs-2A3n; Fri, 19 Sep 2025 16:10:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uzdh1-00000003Tpp-1Yq7 for linux-arm-kernel@lists.infradead.org; Fri, 19 Sep 2025 16:10:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50743169E; Fri, 19 Sep 2025 09:10:30 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ECDCB3F66E; Fri, 19 Sep 2025 09:10:32 -0700 (PDT) Message-ID: <9e5b267d-3b4d-49bb-946c-dd501ca64e54@arm.com> Date: Fri, 19 Sep 2025 17:10:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/29] ACPI / PPTT: Stop acpi_count_levels() expecting callers to clear levels To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-3-james.morse@arm.com> <20250911114623.00007cd3@huawei.com> Content-Language: en-GB From: James Morse In-Reply-To: <20250911114623.00007cd3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250919_091039_469475_71D506C4 X-CRM114-Status: GOOD ( 11.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonathan, On 11/09/2025 11:46, Jonathan Cameron wrote: > On Wed, 10 Sep 2025 20:42:42 +0000 > James Morse wrote: > >> In acpi_count_levels(), the initial value of *levels passed by the >> caller is really an implementation detail of acpi_count_levels(), so it >> is unreasonable to expect the callers of this function to know what to >> pass in for this parameter. The only sensible initial value is 0, >> which is what the only upstream caller (acpi_get_cache_info()) passes. >> >> Use a local variable for the starting cache level in acpi_count_levels(), >> and pass the result back to the caller via the function return value. >> >> Gid rid of the levels parameter, which has no remaining purpose. >> >> Fix acpi_get_cache_info() to match. >> >> Suggested-by: Jonathan Cameron >> Signed-off-by: James Morse >> Reviewed-by: Lorenzo Pieralisi > Reviewed-by: Jonathan Cameron Thanks! James