From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D0D5C76196 for ; Thu, 6 Apr 2023 18:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cjlkh5FhO5RZ6zpRRZRontyn7watSkP/7bvWZ4nBKRs=; b=LMHre5TjasjFR4 YZvAxXeS2bRC6qDuaWU9Tx9RCl4FTtWD54Nu31tFLHAYESDp2obHQJ3vlb+o7Wb+DVAs8MWcXd/t5 X+mmWwJ80bvcMAqt5Zvac3WX2zJvtAuAZHwHk9OZ0EyYT+RBZLnm6PtRAoZSCeiMbGCmiGrfl+1UE klwrUY5qqHk1j5MYfE6aQN3dpHA5mW2Xvbg033hp0jxfCXj4l4bDYc94ajO3/9k6rt+TdvO3MF07u u5PXKX4WXI+DAJGShLk3xmSp8HChArsBCP1DLdrbCJky6eQG+3ZhUhi5ztGUhZkBaIkjxPerlOHh+ CiMJCNCeMXEHl9zfq5wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkUjh-008JaV-0a; Thu, 06 Apr 2023 18:53:29 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkUjd-008JZO-2U; Thu, 06 Apr 2023 18:53:27 +0000 Received: by mail-qt1-x82c.google.com with SMTP id p2so33888049qtw.13; Thu, 06 Apr 2023 11:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680807203; x=1683399203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fkm1WIFQjf0PCje4i/w8NoBsWJO6GDFcmZxAmQoOl44=; b=Hk/h42787AxVBPwrLukrVXWSP1EEwYZ86x+YO7gowFQsitDPKp4OEua9Zuw8kAd6yD afvTz75pYSlKCpKUWGjbSbU2i+x1Adq/w8CT3r2sz1Om3L3i6/3ie8rB6AjJgizhnhPU HP+tQp9otXm5oXhhrrR7xy+NvquFJ99RNOB9nOQTbwRMm2pE2ckrbkO3KKiKmF03V5hj bnifesflc1ds0hnR8rHGoRhsd8cgrwcGIuE6qJAiJ8ddt+KrPZlOPjrNEpSb7E784PMI e6Fu43GE0QVTOAwq/Yuks2S+Un57LPeEb28vEtp9u15Wa+V7GVUSO9TwoFkeBjExVbQI hV7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680807203; x=1683399203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fkm1WIFQjf0PCje4i/w8NoBsWJO6GDFcmZxAmQoOl44=; b=WtYAchbHKmijNoiCzp3/FQXLE05NT+bleiN9tBhEDCbsZe7WAyPJ1KHRn+QXJNy7nr +rUzOO/2Nfz1q0oxpZlDcx4DstA35DKK8ov3CnnZd5CHkEPXYajTW3CVGlRe68BwXs0C g5ojk3tdpAgX/iKYwuKKUIEfzGjIURW5pY9Q1x7DVwKdaSTkylQJTGsx9JBeHPTylFmI 3m59BhjkzVojQxud8b53SrNUC7DEGUudGdKa2S39bnqDUADGEXg8KhusvrGC4mwKXGXQ 7bX1jZFCAkUJu882irjYlpC2HXpidU6xBPvQg79yAK54xnFYy2YYTEhedWGs1fIKTgLS o0vA== X-Gm-Message-State: AAQBX9fWdX30iTfINZp9GfbguHrITuDwdxDKWDGzVIvlZFKKJSFE+Cl9 VYgNy2A/q9ryx2Er9lZmeSU= X-Google-Smtp-Source: AKy350Ygh+Zln0AyES3s+WW8OVnCmQVo50LSQ2mA1GXiXZIQpWrUZIfgBe1uOlV3Zzi7dprgaHTmyA== X-Received: by 2002:a05:622a:202:b0:3e3:8bbc:d152 with SMTP id b2-20020a05622a020200b003e38bbcd152mr11802926qtx.66.1680807203095; Thu, 06 Apr 2023 11:53:23 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w24-20020ac86b18000000b003e64490a35bsm609139qts.21.2023.04.06.11.53.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:53:22 -0700 (PDT) Message-ID: <9e98496b-73a0-78a5-e890-7d7e4be1f469@gmail.com> Date: Thu, 6 Apr 2023 11:53:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: brcmstb: Add two optional props Content-Language: en-US To: Krzysztof Kozlowski , Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230406124625.41325-1-jim2101024@gmail.com> <20230406124625.41325-2-jim2101024@gmail.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_115325_809247_2E950B39 X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/6/23 11:34, Krzysztof Kozlowski wrote: > On 06/04/2023 14:46, Jim Quinlan wrote: >> Regarding "brcm,enable-l1ss": >> >> The Broadcom STB/CM PCIe HW -- which is also used by RPi SOCs -- requires >> the driver probe to configure one of three clkreq# modes: >> >> (a) clkreq# driven by the RC >> (b) clkreq# driven by the EP for ASPM L0s, L1 >> (c) bidirectional clkreq#, as used for L1 Substates (L1SS). >> >> The HW can tell the difference between (a) and (b), but does not know >> when to configure (c). Further, the HW will cause a CPU abort on boot if >> guesses wrong regarding the need for (c). So we introduce the boolean >> "brcm,enable-l1ss" property to indicate that (c) is desired. This >> property is already present in the Raspian version of Linux, but the >> driver implementaion that will follow adds more details and discerns >> between (a) and (b). >> >> Regarding "brcm,completion-timeout-msecs" >> >> Our HW will cause a CPU abort if the L1SS exit time is longer than the >> completion abort timeout. We've been asked to make this configurable, so >> we are introducing "brcm,completion-abort-msecs". >> >> Signed-off-by: Jim Quinlan >> --- >> .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml >> index 7e15aae7d69e..ef4ccc05b258 100644 >> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml >> @@ -64,6 +64,18 @@ properties: >> >> aspm-no-l0s: true >> >> + brcm,enable-l1ss: >> + description: Indicates that the downstream device is L1SS >> + capable and L1SS is desired, e.g. by setting >> + CONFIG_PCIEASPM_POWER_SUPERSAVE=y. Note that CLKREQ# > > How does CONFIG_PCIEASPM_POWER_SUPERSAVE apply to *BSD? In other words, there should be no OS/Linux specific comments in a Device Tree binding, which would be a friendlier and nicer way of providing the same feedback. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel