Re: [PATCH net v3] net: stmmac: request the MDIO reset GPIO only once

[Linkui Xiao <xiaolinkui@126.com>]

Hi Jakub,

On 2026/9/25 00:37, Jakub Kicinski wrote:
> On Mon, 21 Sep 2026 09:57:27 +0800 Linkui Xiao wrote:
>> +struct gpio_desc;
>>   struct stmmac_pcs;
>>   
>>   struct stmmac_resources {
>> @@ -287,6 +288,8 @@ struct stmmac_priv {
>>   
>>   	unsigned int pause_time;
>>   	struct mii_bus *mii;
>> +	struct gpio_desc *mdio_reset_gpio;
>> +	u32 mdio_reset_delays[3];
> 
> Someone already marked it as changes requested but also no need to
> forward declare structs unless first use is as function arguemnt.
Thanks for the review. I'll remove the forward declaration of
struct gpio_desc and include <linux/gpio/consumer.h> in stmmac.h
instead, since its first use is as a struct member.

I'll send v4 shortly.

Thanks,
Linkui