From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A32B8C77B60 for ; Fri, 28 Apr 2023 10:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bxheg2bsrRJvS227MbeArf12/MCbKVJTFsgdV1uXq2w=; b=HYbfNX9ylJx8wG nsniAnDxH3hp7aOxzyaMqgTZ8zx5TCgRfpRcjdHx1VR0JB2gScRFHlraIKg39L9CJBHoG4cbXbZQ5 0wh/XW4ihdnapv0e3/lHP+ynm9eVC8yXfY/6Hz3MX1UoSbj94jfbukSvGbCMfIDX/xlSWFecHEAv9 +z1C2GWPHwwIyF1Ocr198F3WEUa9dBrXiSTUbTsRQHV9ZwP7Jx3EtOdJQEYH7xeMsvWIzqLLqbetc pJcT52RVKcu4vr3wTlhe/IR8K+vK7X5J12+TPtUXCcl5K/bApTI+zDMOKwx1NDikVPs9S9cNmThhS E4Wa4FZUL8JTlaobcclQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1psL00-008iVt-11; Fri, 28 Apr 2023 10:06:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1psKzw-008iV7-1t for linux-arm-kernel@lists.infradead.org; Fri, 28 Apr 2023 10:06:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C82D660E9E; Fri, 28 Apr 2023 10:06:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AD47C433EF; Fri, 28 Apr 2023 10:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682676399; bh=81OkaQlfi3CrgD0EqbtFoJUkJdZFa1rVghoCulNspY8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZximVBIuPdOi+pwiva8zkP48wBNEhFzkukIzxqilzyieetx0RRa9fwflJLXosbXdw DlZfWsL10oOzaGxnWfee8x40HA9Y9zz4vZT7+R8WgcGy4+DOVH6Iw/SSibm4hFURzP NAUDm0Wy+GBXPhxnVsGhRhsRftRKVyTQWbQZs950F6S50Astnfp3ENuVchmgx78F8p luk8Ti+6xo1xF6ilCNV/Uf9a1dVTo3QcB2V4thlQ328UfJaWxu7mMbQcLy104wXMNJ U5/9IzOIbRSGHmfPOkowr/kswengIZN7zgcrQzetjioPLIgb1zTSnG3pQKt/flvAbh QxQfRtNTgaHHQ== Message-ID: <9eda664b-e2ce-1f95-a112-1a808c95e011@kernel.org> Date: Fri, 28 Apr 2023 12:06:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC v2 3/3] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol To: Oleksii Moisieiev , "sudeep.holla@arm.com" Cc: Linus Walleij , Cristian Marussi , Peng Fan , Michal Simek , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" References: Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230428_030640_717801_CA424EFE X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/04/2023 15:26, Oleksii Moisieiev wrote: > Add new SCMI v3.2 pinctrl protocol bindings definitions and example. > > Signed-off-by: Oleksii Moisieiev Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed several entries, including DT list, so this won't be tested. I won't be doing full review, no point if patch is not tested. > --- > .../bindings/firmware/arm,scmi.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 2f7c51c75e85..41ba5b8d8151 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -212,6 +212,63 @@ properties: > reg: > const: 0x18 > > + protocol@19: > + $ref: '#/$defs/protocol-node' > + > + properties: > + reg: > + const: 0x19 > + > + '#pinctrl-cells': > + const: 0 > + > + allOf: > + - $ref: "/schemas/pinctrl/pinctrl.yaml#" Drop quotes. > + > + required: > + - reg > + > + additionalProperties: > + anyOf: > + - type: object > + allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml# > + - $ref: /schemas/pinctrl/pinmux-node.yaml# > + > + description: > + A pin multiplexing sub-node describe how to configure a > + set of pins is some desired function. > + A single sub-node may define several pin configurations. > + This sub-node is using default pinctrl bindings to configure > + pin multiplexing and using SCMI protocol to apply specified > + configuration using SCMI protocol. > + > + properties: > + phandle: true What's this? > + function: true > + groups: true > + pins: true > + bias-bus-hold: true > + bias-disable: true > + bias-high-impedance: true > + bias-pull-up: true > + bias-pull-default: true > + bias-pull-down: true > + drive-open-drain: true > + drive-open-source: true > + drive-push-pull: true > + drive-strength: true > + input-debounce: true > + input-value: true > + input-schmitt: true > + low-power-mode: true > + output-mode: true > + output-value: true > + power-source: true > + skew-rate: true > + > + additionalProperties: true This should be false... but if it is true, then listing all properties does not make sense. And anyway usual way is to make it instead unevaluatedProperties:false. I have troubles understanding your goal here. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel