From: Krzysztof Kozlowski <krzk@kernel.org>
To: Friday Yang <friday.yang@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188
Date: Sun, 4 May 2025 15:40:32 +0200 [thread overview]
Message-ID: <9f01a9a4-89b2-4bfc-97cd-827be989ef16@kernel.org> (raw)
In-Reply-To: <20250430094545.23932-3-friday.yang@mediatek.com>
On 30/04/2025 11:45, Friday Yang wrote:
> From: "Friday Yang" <friday.yang@mediatek.com>
>
> To prevent handling glitch signals during MTCMOS on/off transitions,
> SMI requires clamp and reset operations. Parse the reset settings for
> SMI LARBs and the clamp settings for the SMI Sub-Common. Register
> genpd callback for the SMI LARBs located in image, camera and IPE
> subsystems, and apply reset and clamp operations within the callback.
>
> Signed-off-by: Friday Yang <friday.yang@mediatek.com>
> Tested-by: Friday Yang <friday.yang@mediatek.com>
How is this possible? Are you claiming that none of other authors test
their patches? How testing would be not implied by authorship?
> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Acked-by: Rob Herring <robh@kernel.org>
Changelog says that v7 has only following changes:
- Remove the 'devm_pm_runtime_enable' change.
While v6 had no such tags.
No clue what happened here, but looks like mess with the tags and really
incomplete changelog.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-04 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 9:45 [PATCH v7 0/2] Add SMI reset and clamp for MediaTek MT8188 SoC Friday Yang
2025-04-30 9:45 ` [PATCH v7 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 Friday Yang
2025-05-04 13:42 ` Krzysztof Kozlowski
2025-07-28 6:21 ` Friday Yang (杨阳)
2025-04-30 9:45 ` [PATCH v7 2/2] memory: mtk-smi: mt8188: " Friday Yang
2025-05-04 13:40 ` Krzysztof Kozlowski [this message]
2025-07-28 6:21 ` Friday Yang (杨阳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f01a9a4-89b2-4bfc-97cd-827be989ef16@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=friday.yang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).