From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0645DC3DA59 for ; Mon, 22 Jul 2024 11:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CKKJpxIdq+M8iPk7399MioD6tMMhy7EgITgmmbPN/L4=; b=tvT+PdVvQ7BLEACsqrbx1MjX4/ QCtrhP4uOiDojuEAmA/BIzZPxBYnxLAJA2VMtdVv63K9EDeGC2xdvTvwQnU478W01zRTw3B94v0nP wnoJO1agDVvMUFCVDE9CX7tu++Ue8UYn+6FVhWyiAl9t1et2KRbxLdLGauZHuzxHK2Xr4M4Z2Bh9e fhBn4TduCE6VFj38NKJqx4nSqjusixJbAyMsIKyNtYLurp4cXAS1lmUe4mw2+wHKx9IskgUF0cPrk 2t12LoIuu10GlDwmHb46zskBQT4p4A4/2bs0ba6q/EvEhETVkP6wiXK11429J1/DO4gzadfY2tg/i XC38AABg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVqzi-00000009Ljp-1PLX; Mon, 22 Jul 2024 11:14:18 +0000 Received: from mgamail.intel.com ([192.198.163.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVqzL-00000009Lfz-2E0b for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2024 11:13:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721646835; x=1753182835; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=epq/oVOAbsZItv4EApiSC0nImHFpX+Gb33tvWPeHBYo=; b=DTPm4z9FEvY6ji0vyToesRGJ5SxWMqjqdCGbJixXAkNgrM10c3nH9FcV ZIEDo1GOjg9cOfB8V3z5OgfC0iCpgIrA+SHEoUVwijkh9F3fs992vNxRR 2jpxpardBBHrC5g6ABHNh/LWlmdIS43GKL/S8IkiWv4PxsWmDZxS177r3 cxKwXhf+M0UJp9TJUWNEvrYBYT3pcZo+5ZA5ys8IjgOUd8z7OVUfGiKM/ qJfPlUCV2I99DqYcHrA9gjXOLjXDqzy+DYtcRexk02zG0rPZCdQrFZBjj PhZaCgA/E2WxVyY50eWx/xQ7u+jU4ZmnGHOkVCjT84MuzpVDlVcI0bmAU g==; X-CSE-ConnectionGUID: VnOwO1p8QpWZidEMxp7sEw== X-CSE-MsgGUID: nMLr9NOhQK2FkEfvYu2eOw== X-IronPort-AV: E=McAfee;i="6700,10204,11140"; a="19080178" X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="19080178" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 04:13:52 -0700 X-CSE-ConnectionGUID: g0rJ/vUPRvSo0+TcOy12CQ== X-CSE-MsgGUID: 9jb6BcuBSeit7re7VGHE5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,228,1716274800"; d="scan'208";a="56702178" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.246.41.28]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 04:13:48 -0700 Message-ID: <9f08c5cb-fb4b-4994-9128-0484aa6c06d7@intel.com> Date: Mon, 22 Jul 2024 14:13:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/6] perf auxtrace: Iterate all AUX events when finish reading To: Leo Yan , Arnaldo Carvalho de Melo , Namhyung Kim , Ian Rogers , James Clark , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Jiri Olsa , Mark Rutland , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240721202113.380750-1-leo.yan@arm.com> <20240721202113.380750-5-leo.yan@arm.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20240721202113.380750-5-leo.yan@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240722_041355_654997_70322674 X-CRM114-Status: GOOD ( 25.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/07/24 23:21, Leo Yan wrote: > When finished to read AUX trace data from mmaped buffer, based on the > AUX buffer index the core layer needs to search the corresponding PMU > event and re-enable it to continue tracing. > > However, current code only searches the first AUX event. It misses to > search other enabled AUX events, thus, it returns failure if the buffer > index does not belong to the first AUX event. > > This patch extends the auxtrace_record__read_finish() function to > search for every enabled AUX events, so all the mmaped buffer indexes > can be covered. > > Signed-off-by: Leo Yan > --- > tools/perf/util/auxtrace.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index e2f317063eec..95be330d7e10 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -670,18 +670,25 @@ static int evlist__enable_event_idx(struct evlist *evlist, struct evsel *evsel, > int auxtrace_record__read_finish(struct auxtrace_record *itr, int idx) > { > struct evsel *evsel; > + int ret = -EINVAL; > > if (!itr->evlist || !itr->pmu) > return -EINVAL; > > evlist__for_each_entry(itr->evlist, evsel) { > - if (evsel->core.attr.type == itr->pmu->type) { > + if (evsel__is_aux_event(evsel)) { If the type is the same, then there is no need to change the logic here? Otherwise, maybe that should be a separate patch > if (evsel->disabled) > - return 0; > - return evlist__enable_event_idx(itr->evlist, evsel, idx); > + continue; > + ret = evlist__enable_event_idx(itr->evlist, evsel, idx); > + if (ret >= 0) Should this be: if (ret < 0) > + return ret; And will need a common error path for the pr_err() below. > } > } > - return -EINVAL; > + > + if (ret < 0) > + pr_err("Failed to event enable event (idx=%d): %d\n", idx, ret); > + > + return ret; > } > > /*