From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2E87C5478C for ; Tue, 27 Feb 2024 09:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yt2f4uA7ptIrX0uHwdKxzFbIuny1M/zfSruFhqPXmsU=; b=llRx3vLmsxODUV aLu1s1We0NpgL822ppYhE+iExyvUfMSiMNenqRBe8+rb8rNgdwbTFQ6+kHRj9oWG81HBQFWrPnflc w7QgEvxT6JY07Tlrra3ruUbzSf6+JlpUdAkkQbD1tvpMzG38AyYpjgW82QNRkB5AdfLTY0G7F1ob0 cxGesT2JVnzjvUO4lb5cZyOwERrxYwWuPzhXdQ2gvO77U0U6MPpiZm+Bv0E5FKRHpON7QjXC/Vecr olH3olWH94rqoqbSOHKM04KpYZRX5vN4juVVO5G88HRASnhL0I83ltG5aHMoxTjVkZ9zHgkIaWOOj AfmfOIm+QLwXuW9GkfPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1retwQ-00000004Z92-2PIe; Tue, 27 Feb 2024 09:40:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1retwN-00000004Z7y-47bY for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 09:40:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5933DDA7; Tue, 27 Feb 2024 01:40:34 -0800 (PST) Received: from [10.163.48.107] (unknown [10.163.48.107]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6BB13F762; Tue, 27 Feb 2024 01:39:53 -0800 (PST) Message-ID: <9f20e601-a5b8-48be-8364-3ea9b45d0940@arm.com> Date: Tue, 27 Feb 2024 15:09:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64/hw_breakpoint: Determine lengths from generic perf breakpoint macros Content-Language: en-US To: Will Deacon Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, broonie@kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org References: <20240223113102.4027779-1-anshuman.khandual@arm.com> <20240223125224.GC10641@willie-the-truck> <1901fadb-1d71-4374-be8c-00935bb27854@arm.com> <20240227090529.GA13359@willie-the-truck> From: Anshuman Khandual In-Reply-To: <20240227090529.GA13359@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_014000_132539_C12AB3B9 X-CRM114-Status: UNSURE ( 9.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/27/24 14:35, Will Deacon wrote: > On Tue, Feb 27, 2024 at 11:01:54AM +0530, Anshuman Khandual wrote: >> On 2/26/24 16:34, Mark Rutland wrote: >>> I don't think this needs to change, and can be left as-is. >> >> Fair enough, but just wondering how about deriving len_in_bytes from >> hweight_long(ARM_BREAKPOINT_LEN_*) instead ? This also drops the hard >> coding using the platform macros itself, without going to user ABI. > > Please leave this code alone. It's fine like it is and there are plenty of > other things that would actually benefit from your attention. The BRBE > series, for example. Sure, no problem, will drop this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel