linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE
Date: Thu, 15 Nov 2018 15:47:10 +0100	[thread overview]
Message-ID: <9f303eb5-31a1-a3dc-66e9-645b46c5983c@gmail.com> (raw)
In-Reply-To: <20181115143347.f4wtdipdhhyooatu@verge.net.au>

On 11/15/2018 03:33 PM, Simon Horman wrote:
> On Wed, Nov 14, 2018 at 04:32:05PM +0100, Marek Vasut wrote:
>> On 11/13/2018 04:22 PM, Geert Uytterhoeven wrote:
>>> Enable R-Car Gen3 PCIe PHY support, which is needed for PCIe to function
>>> on the Renesas Condor board.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> This helps
>>
>> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> 
> Thanks, would it be better to use enable this driver as a module rather
> than a built-in?

I think not, since the pcie-rcar cannot be compiled in as module, so the
associated phy driver shouldn't be compiled in as module either.

>>> ---
>>>  arch/arm64/configs/defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 9d0b42d96f03156e..77f98a7e860b8850 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -657,6 +657,7 @@ CONFIG_PHY_HISI_INNO_USB2=y
>>>  CONFIG_PHY_MVEBU_CP110_COMPHY=y
>>>  CONFIG_PHY_QCOM_QMP=m
>>>  CONFIG_PHY_QCOM_USB_HS=y
>>> +CONFIG_PHY_RCAR_GEN3_PCIE=y
>>>  CONFIG_PHY_RCAR_GEN3_USB2=y
>>>  CONFIG_PHY_RCAR_GEN3_USB3=m
>>>  CONFIG_PHY_ROCKCHIP_EMMC=y
>>>
>>
>>
>> -- 
>> Best regards,
>> Marek Vasut
>>


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2018-11-15 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 15:22 [PATCH] arm64: defconfig: Enable CONFIG_PHY_RCAR_GEN3_PCIE Geert Uytterhoeven
2018-11-14 15:32 ` Marek Vasut
2018-11-15 14:33   ` Simon Horman
2018-11-15 14:47     ` Marek Vasut [this message]
2018-11-16 14:57       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f303eb5-31a1-a3dc-66e9-645b46c5983c@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).