From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BFC0C04FFE for ; Sat, 20 Apr 2024 23:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgJOMAsccwDrSo9A9OlUTZOIUOdd2J/ZFE3r+rez+ck=; b=R1O5DaNtnzCKia 0Xlf+HTE5y+5OtUvveSBjFGE78TkncNrvxOU7ogsRffkL8uvjPGq1C9nZz7CVz7TPdwbwNKsgu2u/ 8BnaVsNi+WW2z/jYn72LfVM/GmbXKONHiiDVlYHKEbkHCDli/PZ8t+KVpv8TkdMM8i+s2lLbaMnU3 +p8QV6ruxbUc4mTliwHGtXxHr9A0/vq/P9XJ5g8nn1zyUuGFEC/7AwAUVgQBPPKyaf3uGBrhPuk2/ ti7EWnFjsnpW+ZGfEtXB6HxGdySdtvUWnyvFnpVe6hsQ6PA6r/erSZZRo4KuS/3/W/tL4FimmzBjF KhgXj/rhYWwzIulbyaZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJhD-00000009Kgo-3NBg; Sat, 20 Apr 2024 23:00:35 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryJhB-00000009Kf6-2aj8 for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2024 23:00:34 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-56e136cbcecso4482787a12.3 for ; Sat, 20 Apr 2024 16:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713654030; x=1714258830; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gS/avcdT3uZE+/g4l+u7eNrKfkVrRBnHoxOYygE+RDE=; b=SeuslA4yRe1kR/KgjhhMUuFY66ecaWU0sKUYRsx5FMKTGO+fgGC9pL5ArkMjpSD4zY eVM+fH3zo7wUp+0OfWFB0NUwkBYbwXx/NJl8dHRWGVdTb4KoQUh/+XM5YZ2S3SrpW8OH AZSRuYQB9QkYD+JZq0hhqCr+6b2m+3pirL5E/0vGtlESnvQRpZjz8MbHqBHxHtsMQ9vD a9kf19MU11v7BfI27LgzSpfDg1L06bPiEWE7wWb/7GnynhUZzicafF79fAwsIpWDCdjf 7WN89MzzX+Od4Izo6f0RbppaxshUCxbQvOWACNGGKT7t8/y1nDSfvtGH63eot347oDmt 1Ltw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713654030; x=1714258830; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gS/avcdT3uZE+/g4l+u7eNrKfkVrRBnHoxOYygE+RDE=; b=poBSDv8pBRLVCzGCL5sVpoKRTZSuoiFe23bObjWd8Jk9lX6WvPveP5dpI8yd3xVx3e o6RmJXc3n7VWR+q9mq6dS2ASQIv0aFyISaqqb2YXf0IKQAgg+0fJCNt9PTa+NaVvw/v6 5Tx6cloYyl903UwECzevxmcoySgVSQcoBcRD1JqBkCxdIqJGUtMC8AAjlcDidksJRgMI ihE5F+wdO5+ZkOW+wd1wO7nLdMIBW3NKCTTfdAWEhvy4xMkdb8QsK9Z3HxOEyf0KOzp0 H1GKkKO5DQdIEltQn0kaOfm6AfS/mjrxEzXTuiwEHmHGGSlBTMlbg/b187GzydchzeoC 08bA== X-Forwarded-Encrypted: i=1; AJvYcCX8an8Fo8Ck1VXlOaYlC2vyIvq1OoNdzG2KLuz8K1/1eSiwAzzCufpXQ+8lEC49ta/Ys9Qshr5SogA+K0w+pw9qfwe2T+PztTc6A6MJayiBEq9N4JI= X-Gm-Message-State: AOJu0YwNlcKqj4vfO4RGnOYbIUvjlpQb/4SAu/dlS9SMgA7yjt7QncKj tt2F8HoZNCoyo2xOSZe/gkd6D3Ay6NV3t5SpzPQ55QZqDCyqISeP8hJVTeYRcjA= X-Google-Smtp-Source: AGHT+IH4lwqPioLpoIzW6dLhOLlXPP3zMShUOxH0TJXNnW3DIij9PpcqOmEnmKfQrSavTUI2UaMo9Q== X-Received: by 2002:a50:9ece:0:b0:570:cd6:8ef with SMTP id a72-20020a509ece000000b005700cd608efmr4297896edf.29.1713654029517; Sat, 20 Apr 2024 16:00:29 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id eo9-20020a056402530900b00571ef2c1308sm913940edb.12.2024.04.20.16.00.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Apr 2024 16:00:29 -0700 (PDT) Message-ID: <9f44c386-4be9-4904-bf67-f0e664773baa@linaro.org> Date: Sun, 21 Apr 2024 00:00:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/26] media: pci: mgb4: Refactor struct resources To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> <20240419-fix-cocci-v2-1-2119e692309c@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240419-fix-cocci-v2-1-2119e692309c@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240420_160033_710052_F1A909DF X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2024 10:47, Ricardo Ribalda wrote: > The struct resource end field is inclusive not exclusive, this is, the > size is (end - start) +1. ", this is," doesn't parse on my end "i.e" => that is, would be more appropriate I think. "The struct resource end field is inclusive not exclusive of the size" which I still think is a confusing statement. Perhaps something much easier to understand is called for "The struct resource end field signifies the end address not the relative offset from the start field i.e size == (end - start) + 1. Amend the .end field to specify the end address not the relative size from the offset as is currently given." Other than that, I think its reasonable to assume the mapping != 0 - 0x100 inclusive. Please consider updating your commit log and if you do add my Reviewed-by: Bryan O'Donoghue --- bod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel