From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E36C10F07 for ; Mon, 11 Dec 2023 10:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yi6WWeV/orUuxn6en9uNpphzHNGZRD6xttkIkfpbrww=; b=UI1XxoPgP4C8rl /YmzESZ4Ha21mbEM/UReAvBcp2+mmYyYaHm+A6PjQN/LWqNZBtWfssHAEsLi12e3aAbJ9osWbEY7i u7vEK5wXRw8RQ5aG6Nvx8e/msS7d2wWOwigDxVNfg9yXgWf3mno5gCIsEUlePPYQhANgl2xbryfzC JuzFCNZu+Xtv2Lx8l5k0HWQrpwJDaLYMTJ2UfoOMRipZI1Nx5zG8vmYSUo+rj41OpMRqa+SO7NwZr 1rkrNBBthJOZWNfoSnWNxFx3+eSnVTMqZq6v7p4k9+0pGVOqXs82/RhpDaKKsYiS6DgBragx/iKms X1WAG4eYiR7sRna7HiCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCd68-004Y1U-1b; Mon, 11 Dec 2023 10:01:12 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCd64-004XyQ-1V for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 10:01:11 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3BBA0xGK071011; Mon, 11 Dec 2023 04:00:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1702288859; bh=2paImWByJrTjROw8WnVv5FUglPWngDhuD4VbnvfawPM=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=B0YIoYlxNaGFRmSHJRHWKi7aKMPn/PNqAExXc/pG/Nk0UbP7+EZZzVBmRvqYU2WVS ye2rxb24vGGRjBepVSPA/FCElOT95q258sYgoaJ0lyCgiPE5wEEjuii6c8seGzG3sm m/JeElUwD/DBIwhhYcUyaMzH6gl2MmubDWz0AmrY= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3BBA0xrC034776 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 Dec 2023 04:00:59 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 11 Dec 2023 04:00:59 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 11 Dec 2023 04:00:59 -0600 Received: from [10.24.69.31] (danish-tpc.dhcp.ti.com [10.24.69.31]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3BBA0s88080210; Mon, 11 Dec 2023 04:00:55 -0600 Message-ID: <9f63b81d-1826-411f-b310-e726e5eb5cb3@ti.com> Date: Mon, 11 Dec 2023 15:30:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-am642-evm: add overlay for icssg1 2nd port Content-Language: en-US To: "Anwar, Md Danish" , Andrew Lunn CC: Vignesh Raghavendra , Nishanth Menon , Conor Dooley , Krzysztof Kozlowski , Rob Herring , , , , Tero Kristo , , References: <20231207081917.340167-1-danishanwar@ti.com> <20231207081917.340167-4-danishanwar@ti.com> From: MD Danish Anwar In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_020108_687155_88683D4C X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On 08/12/23 12:58 pm, Anwar, Md Danish wrote: > On 12/8/2023 3:10 AM, Andrew Lunn wrote: >>> + mdio-mux-2 { >>> + compatible = "mdio-mux-multiplexer"; >>> + mux-controls = <&mdio_mux>; >>> + mdio-parent-bus = <&icssg1_mdio>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + mdio@0 { >>> + reg = <0x0>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + icssg1_phy2: ethernet-phy@3 { >>> + reg = <3>; >>> + tx-internal-delay-ps = <250>; >>> + rx-internal-delay-ps = <2000>; >>> + }; >>> + }; >> >> That looks odd. A mux generally has > 1 mdio bus. Otherwise its not >> really a mux. >> > > We are disabling node `mdio-mux-1` which has the `cpsw3g_mdio` bus and > then adding a new node `mdio-mux-2` which has the `icssg1_mdio` bus. The > mux can actually have two different mdio buses. The patch actually > disables the mux1 node and creates a new node for icssg1_mdio bus so > that cpsw3g mdio bus is disabled properly. > > We can modify the existing `mdio-mux-1` as well (added the code below) > instead of disabling mux1 and creating mux2 node. > > &mdio_mux_1 { > mdio-parent-bus = <&icssg1_mdio>; > #address-cells = <1>; > #size-cells = <0>; > > mdio@0 { > reg = <0x0>; > #address-cells = <1>; > #size-cells = <0>; > > icssg1_phy2: ethernet-phy@3 { > reg = <3>; > tx-internal-delay-ps = <250>; > rx-internal-delay-ps = <2000>; > }; > }; > }; > > Let me know what do you think. Is the approach in the patch correct or > should I modify existing mux node only? > Can you please let me know which approach should I follow here? >> And this mux hardware exists all the time right? So it should be in >> the .dtsi file. >> > > Agreed. But the mdio-mux-1 node was added in k3-am642-evm.dts by the > commit 985204ecae1c37d55372874ff9146231d28fccc6. I did the same with > mdio-mux-2 node. > >> Andrew > -- Thanks and Regards, Danish _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel