From: Hugues FRUCHET <hugues.fruchet@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-media@vger.kernel.org>
Cc: Alain Volmat <alain.volmat@foss.st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amelie DELAUNAY <amelie.delaunay@foss.st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Philippe CORNU <philippe.cornu@foss.st.com>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] media: stm32: dcmi: Drop always NULL sd_state from dcmi_pipeline_s_fmt()
Date: Mon, 27 Jun 2022 11:40:08 +0200 [thread overview]
Message-ID: <9f6cff45-1894-23b5-afe7-49986e65ab5d@foss.st.com> (raw)
In-Reply-To: <20220618222354.478227-1-marex@denx.de>
Hi Marek,
Thanks for the patch.
Acked-by: Hugues Fruchet <hugues.fruchet@st.com>
BR,
Hugues.
On 6/19/22 00:23, Marek Vasut wrote:
> The second argument is always NULL, stop passing it to the function.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alain Volmat <alain.volmat@foss.st.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Amelie DELAUNAY <amelie.delaunay@foss.st.com>
> Cc: Hugues FRUCHET <hugues.fruchet@foss.st.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Philippe CORNU <philippe.cornu@foss.st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> drivers/media/platform/st/stm32/stm32-dcmi.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
> index 56f4e04bc7c49..ec54b5ecfd544 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
> @@ -622,7 +622,6 @@ static struct media_entity *dcmi_find_source(struct stm32_dcmi *dcmi)
> }
>
> static int dcmi_pipeline_s_fmt(struct stm32_dcmi *dcmi,
> - struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_format *format)
> {
> struct media_entity *entity = &dcmi->source->entity;
> @@ -664,7 +663,7 @@ static int dcmi_pipeline_s_fmt(struct stm32_dcmi *dcmi,
> format->format.width, format->format.height);
>
> fmt.pad = pad->index;
> - ret = v4l2_subdev_call(subdev, pad, set_fmt, sd_state, &fmt);
> + ret = v4l2_subdev_call(subdev, pad, set_fmt, NULL, &fmt);
> if (ret < 0) {
> dev_err(dcmi->dev, "%s: Failed to set format 0x%x %ux%u on \"%s\":%d pad (%d)\n",
> __func__, format->format.code,
> @@ -1115,7 +1114,7 @@ static int dcmi_set_fmt(struct stm32_dcmi *dcmi, struct v4l2_format *f)
> mf->width = sd_framesize.width;
> mf->height = sd_framesize.height;
>
> - ret = dcmi_pipeline_s_fmt(dcmi, NULL, &format);
> + ret = dcmi_pipeline_s_fmt(dcmi, &format);
> if (ret < 0)
> return ret;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-06-27 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 22:23 [PATCH] media: stm32: dcmi: Drop always NULL sd_state from dcmi_pipeline_s_fmt() Marek Vasut
2022-06-27 9:40 ` Hugues FRUCHET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6cff45-1894-23b5-afe7-49986e65ab5d@foss.st.com \
--to=hugues.fruchet@foss.st.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=philippe.cornu@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).