From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 157AEC43334 for ; Mon, 27 Jun 2022 09:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=26Qm4zdw/AA6F86+rJz8ReSvaiVUaYLhqXvveaTU3zY=; b=VQQ54G1RbcQ2Ts ia11c9p/bsRUhAwdLem/I9T3ZMlaRWFYuD252UwNj7p9qB5W90TJy/Ae7+/RnHmY+KfV+H3v27VTE vzE/owdcCjJl0GKIGUDAPH5gyffvUNjTNsYMMCN3EPaWHwmWHPNtJVFCcbc9YXFzoFnmmzGbIrdo1 EByyJAd7zr+eZV+N1A4nYo8zeg+RP8Cl28JTrQ7xBXYxpbzm5cTrztUvegG8MlbRiy8vhmwrloOY/ LlPs/Ril3I6VktPyLX7bZi8r0V4gAOduJxRmQ+BtXaW26w/49EOmR05DSoc4RyBx6Et4Syra/tVC9 yfSK+QJCfhyfJoymg3QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5lE8-00HObu-GB; Mon, 27 Jun 2022 09:40:16 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5lE4-00HOZX-IH for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 09:40:14 +0000 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25R7mAUU015017; Mon, 27 Jun 2022 11:40:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=o7dfOl4S6u/3Ojhlka+sdSby2aZu6UTszEhV542U3es=; b=2rHsEkg7pZBd2U48NeKhr6YNtEF9MQiu+yZKNIfv4car7CxxqOUj2kpKq6+VP1Y2JncH Rw/U4iFraMvRFvqYWWjp5qiqXCAxWexH54FeQcdL0qzevVu/CXT4mZGxkavER7DjPaHk 5jDJ6WAkyB5HXd2dZPPo8yqrSUdxnvuzdm9D+rAMX/XgRT9UAT8WDbHRDcx3MpK4FZq0 /IhuAfRyXPyEF4clC9qC6mkh3QxREnN9pn0JvGWM10wRdK4r/tMccB0gL0d8tA5bohrd HHi5D38c8vuWEs8QEr6R4AC+x6E+VuFFgJcXNcLio/WxjR5FcS1S4Xu7gBdvvoDEYKOD tQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3gwqsm8uxv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 11:40:10 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5D8AB10002A; Mon, 27 Jun 2022 11:40:09 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 59286216EC3; Mon, 27 Jun 2022 11:40:09 +0200 (CEST) Received: from [10.201.21.143] (10.75.127.46) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 27 Jun 2022 11:40:08 +0200 Message-ID: <9f6cff45-1894-23b5-afe7-49986e65ab5d@foss.st.com> Date: Mon, 27 Jun 2022 11:40:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] media: stm32: dcmi: Drop always NULL sd_state from dcmi_pipeline_s_fmt() Content-Language: en-US To: Marek Vasut , CC: Alain Volmat , Alexandre Torgue , Amelie DELAUNAY , Laurent Pinchart , Philippe CORNU , , References: <20220618222354.478227-1-marex@denx.de> From: Hugues FRUCHET In-Reply-To: <20220618222354.478227-1-marex@denx.de> X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-27_06,2022-06-24_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_024012_946317_BC59F585 X-CRM114-Status: GOOD ( 19.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, Thanks for the patch. Acked-by: Hugues Fruchet BR, Hugues. On 6/19/22 00:23, Marek Vasut wrote: > The second argument is always NULL, stop passing it to the function. > > Signed-off-by: Marek Vasut > Cc: Alain Volmat > Cc: Alexandre Torgue > Cc: Amelie DELAUNAY > Cc: Hugues FRUCHET > Cc: Laurent Pinchart > Cc: Philippe CORNU > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/media/platform/st/stm32/stm32-dcmi.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c > index 56f4e04bc7c49..ec54b5ecfd544 100644 > --- a/drivers/media/platform/st/stm32/stm32-dcmi.c > +++ b/drivers/media/platform/st/stm32/stm32-dcmi.c > @@ -622,7 +622,6 @@ static struct media_entity *dcmi_find_source(struct stm32_dcmi *dcmi) > } > > static int dcmi_pipeline_s_fmt(struct stm32_dcmi *dcmi, > - struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_format *format) > { > struct media_entity *entity = &dcmi->source->entity; > @@ -664,7 +663,7 @@ static int dcmi_pipeline_s_fmt(struct stm32_dcmi *dcmi, > format->format.width, format->format.height); > > fmt.pad = pad->index; > - ret = v4l2_subdev_call(subdev, pad, set_fmt, sd_state, &fmt); > + ret = v4l2_subdev_call(subdev, pad, set_fmt, NULL, &fmt); > if (ret < 0) { > dev_err(dcmi->dev, "%s: Failed to set format 0x%x %ux%u on \"%s\":%d pad (%d)\n", > __func__, format->format.code, > @@ -1115,7 +1114,7 @@ static int dcmi_set_fmt(struct stm32_dcmi *dcmi, struct v4l2_format *f) > mf->width = sd_framesize.width; > mf->height = sd_framesize.height; > > - ret = dcmi_pipeline_s_fmt(dcmi, NULL, &format); > + ret = dcmi_pipeline_s_fmt(dcmi, &format); > if (ret < 0) > return ret; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel