From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96FA6CED618 for ; Wed, 9 Oct 2024 07:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AbWJb505WIa4s94mFp8zyjinYDs5YYe1TRbBJaJlz4c=; b=bMRdRg4fdzyhJTmjS+X5b2DSN/ ST97bDyYGmqPMxpoKhatfr+5CTVUW9NRuvQgpa2TIfvl78cfWrLMQhX6zFTFUahc5z4so7hTX57xC sYzLTsyhQjpwZpre4jGPdtJLU1TfJHPRD5ljZE8Dz0W/9SDHjihgu81n4Em/rkxH3zy1SrdYnjTpa l9B1qo18Do0kkRjbTcSPRBxSOq+JnXWmuN6WBA7IaJ+inojiRl6G/65bBsYBUn9m13dQOrfHiTmL+ WPsKvriBSqdI3CIXNtCRmKlnAbHQ7IEteFj4/8z+14UsMI+ol41WnB2VP3+qKyVz9X5hbTthbBDhP toDyxu9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syRHd-00000008GVy-2ljI; Wed, 09 Oct 2024 07:38:57 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syRGH-00000008GJF-1OPj; Wed, 09 Oct 2024 07:37:35 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1728459451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AbWJb505WIa4s94mFp8zyjinYDs5YYe1TRbBJaJlz4c=; b=fNMtd12n1HUt/Pfi2vyUactjFuzeZsFTFwjhJ5itdEDfS4AIU9vwLOGNHFVdMP8ywgiYtB tap+s/jWaDTouRZWvxfQccLu/+7Zb+UxA/3uVUTBfE9FVRo87G7cWCpyEGlTKPNzywEzLf txYD6fvD3jf0f8x5IHCCH9xlEf62rvaexEchjQDDZWjfMIUBFa1ONXo0NbEJAno3x7ZglJ MD7XYvXntvev2ruYRbBmLSSvaP5AULMd44uVqBZkc7tLyY0dSrauso5T7gnyLBiJMzIm18 Iv3fs0o3tHikss9ybK36JXbQUMzsdYaXC56STtx1/YTWVXx0xFO6w5FRSFLiiw== Date: Wed, 09 Oct 2024 09:37:31 +0200 From: Dragan Simic To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Caesar Wang Subject: Re: [PATCH v2 12/14] ARM: dts: rockchip: drop grf reference from rk3036 hdmi In-Reply-To: <20241008203940.2573684-13-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> <20241008203940.2573684-13-heiko@sntech.de> Message-ID: <9f75abfcf0406238cae0cce694feec88@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_003733_547091_CA06234D X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > Neither the binding nor the driver implementation specify/use the grf > reference provided in the rk3036. And neither does the newer rk3128 > user of the hdmi controller. So drop the rockchip,grf property. > > Fixes: b7217cf19c63 ("ARM: dts: rockchip: add hdmi device node for > rk3036") > Cc: Caesar Wang > Signed-off-by: Heiko Stuebner Looking good to me, thanks for the patch. There's nothing about the "rockchip,grf" property in drivers/gpu/drm/rockchip/inno_hdmi.c. Reviewed-by: Dragan Simic > --- > arch/arm/boot/dts/rockchip/rk3036.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi > b/arch/arm/boot/dts/rockchip/rk3036.dtsi > index 37369538483f..09371f07d7b4 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi > +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi > @@ -400,7 +400,6 @@ hdmi: hdmi@20034000 { > interrupts = ; > clocks = <&cru PCLK_HDMI>; > clock-names = "pclk"; > - rockchip,grf = <&grf>; > pinctrl-names = "default"; > pinctrl-0 = <&hdmi_ctl>; > #sound-dai-cells = <0>;