From: Peng Fan <peng.fan@oss.nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level
Date: Tue, 10 Jan 2023 10:25:31 +0800 [thread overview]
Message-ID: <9fadd80c-c867-714c-20a3-48cac2390fa4@oss.nxp.com> (raw)
In-Reply-To: <20230109161242.54620-1-l.stach@pengutronix.de>
On 1/10/2023 12:12 AM, Lucas Stach wrote:
> Same as done for both LCDIF interfaces in the MEDIA domain, set
> the panic priority of the LCDIF instance in the HDMI domain to
> the maximium NoC priority of 7 to minimize chances of display
> underflows.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c
> index 0629f64ef4f1..28458ed1793b 100644
> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c
> @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = {
> #define HDMI_RTX_CLK_CTL3 0x70
> #define HDMI_RTX_CLK_CTL4 0x80
> #define HDMI_TX_CONTROL0 0x200
> +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12)
>
> static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc,
> struct imx8mp_blk_ctrl_domain *domain)
> @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc,
> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11));
> regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0,
> BIT(4) | BIT(5) | BIT(6));
> + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0,
> + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7));
> break;
> case IMX8MP_HDMIBLK_PD_PAI:
> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17));
For the LCDIF, Reviewed-by: Peng Fan <peng.fan@nxp.com>
BTW: will you also add HRV hurry level? If not, I could also post a patch.
Thanks,
Peng.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-10 2:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:12 [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level Lucas Stach
2023-01-10 2:25 ` Peng Fan [this message]
2023-01-10 9:39 ` Lucas Stach
2023-01-11 2:57 ` Peng Fan
2023-01-11 7:31 ` Sandor Yu
2023-01-12 9:15 ` Lucas Stach
2023-01-13 13:23 ` [EXT] " Sandor Yu
2023-01-26 0:32 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fadd80c-c867-714c-20a3-48cac2390fa4@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).