* [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level @ 2023-01-09 16:12 Lucas Stach 2023-01-10 2:25 ` Peng Fan 2023-01-26 0:32 ` Shawn Guo 0 siblings, 2 replies; 8+ messages in thread From: Lucas Stach @ 2023-01-09 16:12 UTC (permalink / raw) To: Shawn Guo Cc: Pengutronix Kernel Team, NXP Linux Team, Fabio Estevam, linux-arm-kernel, patchwork-lst Same as done for both LCDIF interfaces in the MEDIA domain, set the panic priority of the LCDIF instance in the HDMI domain to the maximium NoC priority of 7 to minimize chances of display underflows. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c index 0629f64ef4f1..28458ed1793b 100644 --- a/drivers/soc/imx/imx8mp-blk-ctrl.c +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { #define HDMI_RTX_CLK_CTL3 0x70 #define HDMI_RTX_CLK_CTL4 0x80 #define HDMI_TX_CONTROL0 0x200 +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, struct imx8mp_blk_ctrl_domain *domain) @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(4) | BIT(5) | BIT(6)); + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); break; case IMX8MP_HDMIBLK_PD_PAI: regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-09 16:12 [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level Lucas Stach @ 2023-01-10 2:25 ` Peng Fan 2023-01-10 9:39 ` Lucas Stach 2023-01-26 0:32 ` Shawn Guo 1 sibling, 1 reply; 8+ messages in thread From: Peng Fan @ 2023-01-10 2:25 UTC (permalink / raw) To: Lucas Stach, Shawn Guo Cc: Pengutronix Kernel Team, NXP Linux Team, Fabio Estevam, linux-arm-kernel, patchwork-lst On 1/10/2023 12:12 AM, Lucas Stach wrote: > Same as done for both LCDIF interfaces in the MEDIA domain, set > the panic priority of the LCDIF instance in the HDMI domain to > the maximium NoC priority of 7 to minimize chances of display > underflows. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > index 0629f64ef4f1..28458ed1793b 100644 > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { > #define HDMI_RTX_CLK_CTL3 0x70 > #define HDMI_RTX_CLK_CTL4 0x80 > #define HDMI_TX_CONTROL0 0x200 > +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) > > static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, > struct imx8mp_blk_ctrl_domain *domain) > @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, > regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); > regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, > BIT(4) | BIT(5) | BIT(6)); > + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, > + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); > break; > case IMX8MP_HDMIBLK_PD_PAI: > regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); For the LCDIF, Reviewed-by: Peng Fan <peng.fan@nxp.com> BTW: will you also add HRV hurry level? If not, I could also post a patch. Thanks, Peng. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-10 2:25 ` Peng Fan @ 2023-01-10 9:39 ` Lucas Stach 2023-01-11 2:57 ` Peng Fan 0 siblings, 1 reply; 8+ messages in thread From: Lucas Stach @ 2023-01-10 9:39 UTC (permalink / raw) To: Peng Fan, Shawn Guo Cc: Pengutronix Kernel Team, NXP Linux Team, Fabio Estevam, linux-arm-kernel, patchwork-lst Hi Peng, Am Dienstag, dem 10.01.2023 um 10:25 +0800 schrieb Peng Fan: > > On 1/10/2023 12:12 AM, Lucas Stach wrote: > > Same as done for both LCDIF interfaces in the MEDIA domain, set > > the panic priority of the LCDIF instance in the HDMI domain to > > the maximium NoC priority of 7 to minimize chances of display > > underflows. > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c > > index 0629f64ef4f1..28458ed1793b 100644 > > --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > > +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > > @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { > > #define HDMI_RTX_CLK_CTL3 0x70 > > #define HDMI_RTX_CLK_CTL4 0x80 > > #define HDMI_TX_CONTROL0 0x200 > > +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) > > > > static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, > > struct imx8mp_blk_ctrl_domain *domain) > > @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, > > regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); > > regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, > > BIT(4) | BIT(5) | BIT(6)); > > + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, > > + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); > > break; > > case IMX8MP_HDMIBLK_PD_PAI: > > regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); > > For the LCDIF, Reviewed-by: Peng Fan <peng.fan@nxp.com> > > BTW: will you also add HRV hurry level? If not, I could also post a patch. > Sure, I can post a patch for that. However, I would really appreciate if NXP made some information available on how HRV is actually working/used. The reference manual is lacking a lot in that regard. Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-10 9:39 ` Lucas Stach @ 2023-01-11 2:57 ` Peng Fan 2023-01-11 7:31 ` Sandor Yu 0 siblings, 1 reply; 8+ messages in thread From: Peng Fan @ 2023-01-11 2:57 UTC (permalink / raw) To: Lucas Stach, Shawn Guo, sandor.yu Cc: Pengutronix Kernel Team, NXP Linux Team, Fabio Estevam, linux-arm-kernel, patchwork-lst +Sandor On 1/10/2023 5:39 PM, Lucas Stach wrote: > Hi Peng, > > Am Dienstag, dem 10.01.2023 um 10:25 +0800 schrieb Peng Fan: >> >> On 1/10/2023 12:12 AM, Lucas Stach wrote: >>> Same as done for both LCDIF interfaces in the MEDIA domain, set >>> the panic priority of the LCDIF instance in the HDMI domain to >>> the maximium NoC priority of 7 to minimize chances of display >>> underflows. >>> >>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de> >>> --- >>> drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c >>> index 0629f64ef4f1..28458ed1793b 100644 >>> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c >>> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c >>> @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { >>> #define HDMI_RTX_CLK_CTL3 0x70 >>> #define HDMI_RTX_CLK_CTL4 0x80 >>> #define HDMI_TX_CONTROL0 0x200 >>> +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) >>> >>> static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, >>> struct imx8mp_blk_ctrl_domain *domain) >>> @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); >>> regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, >>> BIT(4) | BIT(5) | BIT(6)); >>> + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, >>> + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); >>> break; >>> case IMX8MP_HDMIBLK_PD_PAI: >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); >> >> For the LCDIF, Reviewed-by: Peng Fan <peng.fan@nxp.com> >> >> BTW: will you also add HRV hurry level? If not, I could also post a patch. >> > Sure, I can post a patch for that. However, I would really appreciate > if NXP made some information available on how HRV is actually > working/used. The reference manual is lacking a lot in that regard. I know little about HDMI, loop HDMI SW owner Sandor to help. Regards, Peng. > > Regards, > Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-11 2:57 ` Peng Fan @ 2023-01-11 7:31 ` Sandor Yu 2023-01-12 9:15 ` Lucas Stach 0 siblings, 1 reply; 8+ messages in thread From: Sandor Yu @ 2023-01-11 7:31 UTC (permalink / raw) To: Peng Fan (OSS), Lucas Stach, Shawn Guo Cc: Pengutronix Kernel Team, dl-linux-imx, Fabio Estevam, linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de > -----Original Message----- > From: Peng Fan (OSS) <peng.fan@oss.nxp.com> > Sent: 2023年1月11日 10:58 > To: Lucas Stach <l.stach@pengutronix.de>; Shawn Guo > <shawnguo@kernel.org>; Sandor Yu <sandor.yu@nxp.com> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>; dl-linux-imx > <linux-imx@nxp.com>; Fabio Estevam <festevam@gmail.com>; > linux-arm-kernel@lists.infradead.org; patchwork-lst@pengutronix.de > Subject: Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read > hurry level > > +Sandor > > On 1/10/2023 5:39 PM, Lucas Stach wrote: > > Hi Peng, > > > > Am Dienstag, dem 10.01.2023 um 10:25 +0800 schrieb Peng Fan: > >> > >> On 1/10/2023 12:12 AM, Lucas Stach wrote: > >>> Same as done for both LCDIF interfaces in the MEDIA domain, set the > >>> panic priority of the LCDIF instance in the HDMI domain to the > >>> maximium NoC priority of 7 to minimize chances of display > >>> underflows. > >>> > >>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > >>> --- > >>> drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c > >>> b/drivers/soc/imx/imx8mp-blk-ctrl.c > >>> index 0629f64ef4f1..28458ed1793b 100644 > >>> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c > >>> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c > >>> @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data > imx8mp_hsio_blk_ctl_dev_data = { > >>> #define HDMI_RTX_CLK_CTL3 0x70 > >>> #define HDMI_RTX_CLK_CTL4 0x80 > >>> #define HDMI_TX_CONTROL0 0x200 > >>> +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) > >>> > >>> static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl > *bc, > >>> struct imx8mp_blk_ctrl_domain *domain) > @@ -316,6 +317,8 @@ > >>> static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl > *bc, > >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); > >>> regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, > >>> BIT(4) | BIT(5) | BIT(6)); > >>> + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, > >>> + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); > >>> break; > >>> case IMX8MP_HDMIBLK_PD_PAI: > >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); > >> > >> For the LCDIF, Reviewed-by: Peng Fan <peng.fan@nxp.com> > >> > >> BTW: will you also add HRV hurry level? If not, I could also post a patch. > >> > > Sure, I can post a patch for that. However, I would really appreciate > > if NXP made some information available on how HRV is actually > > working/used. The reference manual is lacking a lot in that regard. > > I know little about HDMI, loop HDMI SW owner Sandor to help. HRV is not actually used for imx8mp. It is a validation IP. Please ignore it. B.R Sandor > > Regards, > Peng. > > > > > Regards, > > Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-11 7:31 ` Sandor Yu @ 2023-01-12 9:15 ` Lucas Stach 2023-01-13 13:23 ` [EXT] " Sandor Yu 0 siblings, 1 reply; 8+ messages in thread From: Lucas Stach @ 2023-01-12 9:15 UTC (permalink / raw) To: Sandor Yu, Peng Fan (OSS), Shawn Guo Cc: Pengutronix Kernel Team, dl-linux-imx, Fabio Estevam, linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de Hi Sandor, Am Mittwoch, dem 11.01.2023 um 07:31 +0000 schrieb Sandor Yu: > > > > [...] > > > > BTW: will you also add HRV hurry level? If not, I could also post a patch. > > > > > > > Sure, I can post a patch for that. However, I would really appreciate > > > if NXP made some information available on how HRV is actually > > > working/used. The reference manual is lacking a lot in that regard. > > > > I know little about HDMI, loop HDMI SW owner Sandor to help. > > HRV is not actually used for imx8mp. It is a validation IP. Please ignore it. Does that mean we should completely ignore it in upstream and you will carry any necessary patches in downstream? I.e. we wouldn't add the HURRY level configuration to the upstream HDMI blk-ctrl? Regards, Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [EXT] Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-12 9:15 ` Lucas Stach @ 2023-01-13 13:23 ` Sandor Yu 0 siblings, 0 replies; 8+ messages in thread From: Sandor Yu @ 2023-01-13 13:23 UTC (permalink / raw) To: Lucas Stach, Peng Fan (OSS), Shawn Guo Cc: Pengutronix Kernel Team, dl-linux-imx, Fabio Estevam, linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de > -----Original Message----- > From: Lucas Stach <l.stach@pengutronix.de> > Sent: 2023年1月12日 17:15 > To: Sandor Yu <sandor.yu@nxp.com>; Peng Fan (OSS) > <peng.fan@oss.nxp.com>; Shawn Guo <shawnguo@kernel.org> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>; dl-linux-imx > <linux-imx@nxp.com>; Fabio Estevam <festevam@gmail.com>; > linux-arm-kernel@lists.infradead.org; patchwork-lst@pengutronix.de > Subject: [EXT] Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic > read hurry level > > Caution: EXT Email > > Hi Sandor, > > Am Mittwoch, dem 11.01.2023 um 07:31 +0000 schrieb Sandor Yu: > > > > > > [...] > > > > > BTW: will you also add HRV hurry level? If not, I could also post a > patch. > > > > > > > > > Sure, I can post a patch for that. However, I would really > > > > appreciate if NXP made some information available on how HRV is > > > > actually working/used. The reference manual is lacking a lot in that > regard. > > > > > > I know little about HDMI, loop HDMI SW owner Sandor to help. > > > > HRV is not actually used for imx8mp. It is a validation IP. Please ignore it. > > Does that mean we should completely ignore it in upstream and you will carry > any necessary patches in downstream? I.e. we wouldn't add the HURRY level > configuration to the upstream HDMI blk-ctrl? > HRV part could be ignore in upstream code, but HURRY level configuration for LCDIF should keep in upstream HDMI blk-ctrl. B.R Sandor > Regards, > Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level 2023-01-09 16:12 [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level Lucas Stach 2023-01-10 2:25 ` Peng Fan @ 2023-01-26 0:32 ` Shawn Guo 1 sibling, 0 replies; 8+ messages in thread From: Shawn Guo @ 2023-01-26 0:32 UTC (permalink / raw) To: Lucas Stach Cc: Pengutronix Kernel Team, NXP Linux Team, Fabio Estevam, linux-arm-kernel, patchwork-lst On Mon, Jan 09, 2023 at 05:12:42PM +0100, Lucas Stach wrote: > Same as done for both LCDIF interfaces in the MEDIA domain, set > the panic priority of the LCDIF instance in the HDMI domain to > the maximium NoC priority of 7 to minimize chances of display > underflows. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-26 0:33 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-09 16:12 [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level Lucas Stach 2023-01-10 2:25 ` Peng Fan 2023-01-10 9:39 ` Lucas Stach 2023-01-11 2:57 ` Peng Fan 2023-01-11 7:31 ` Sandor Yu 2023-01-12 9:15 ` Lucas Stach 2023-01-13 13:23 ` [EXT] " Sandor Yu 2023-01-26 0:32 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).