From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88216C433EF for ; Fri, 1 Apr 2022 12:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cYE6TsLSPvm16pEzNmcVO/4duw7ySDaU48TNiZOQcX0=; b=fuESsa7zYG8l5I OvyyaJXrDuLcrUWN/OFJrPIAi5JjH2YFaB1K5ahEannUaT6eujI7IbM+ST1MYQpO+/ETQYu9gfNWE dj4b7W2FHcZAD4uY2+g7PIeNDidf3TMIJiuXPJCdWy6M95Xr/rM2Z9DhBT9qYO8Ni3M4Rij9bTOTp sET9Clzo13NiD1vJ+k6j2ckMv1e7UJd6WUHOgRAq5rfI88WYPZcs6XaFmWoXFjW2Gzt4d+7Y+ABHh iyr2YJQAOt3Ye9gTwS7PN0doFyxJ8xlr0dzDtMr1TxNEfWlmfBNSC+90ZViGvoPTE2gky3f7KaZaI VKNKGNAjm0dGBng/SmUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGPW-005dCH-4d; Fri, 01 Apr 2022 12:29:50 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGPS-005dA8-3D for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 12:29:47 +0000 Received: by mail-wm1-x336.google.com with SMTP id bi13-20020a05600c3d8d00b0038c2c33d8f3so3406435wmb.4 for ; Fri, 01 Apr 2022 05:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=knarY0P/HR9VLQQwSOZKVbQpfKOi+mXAWn23v+UHOuU=; b=es3vNB+gmwleXUR7l3lIqpohW+v8Dt5oOPi/d27WUddaSeFFBuAu9BlbXS8CkgsnUz xX9p93HJSwkLh/pszTghxMozVeCn/KeSZLXtv0iO38kVLLNuQRFpjj56IJEKBvyUBi4p +MOT83oOqz6fCWpZs5JlmKXLPOfI7okx9BFbMuMLQ8GZl281jTbbDK6xEW2OdAxglyR9 A2imFYdhQdX1+cHktz80HFIsTZmrD6FCIcegrU9FVr5NeAVEm9v7fFYR2WDz9eWhaHiP xTUlGgs7dQMZccji8ThdGwpLtiqmRju7+5vSt4ro7FAC4hVVq/yiDODDqlebMBJCh4kL 4low== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=knarY0P/HR9VLQQwSOZKVbQpfKOi+mXAWn23v+UHOuU=; b=PQSvbws9SSQ/2FQIkZvBe/Xvn8ZeQcl4kCV909cJpvtOVrZsEjKmOuzEXpoRsRaWsJ QyrUPAcEIgznIOL8juWX9nR0lafvWc33JDIkXgUlnNwelr/Cgn+WugskXhl9i4WVF/nO UA9M1CejXoWFOMpVZx3kqDghgv+nZ9dOvGQaY+1blB4xRE4FAUd9K/Vd9CnTCZASo51U MjxZMG0uob4kZhQlZfBkqap4xacCGb4ztieFP70vX7ZT5fiNw/RP8EkFsFg51ddeEaaK nFpsnSY4aB6ztFABljTFNdt9JNcT1iRmZ2V6gyd2kKmsjMpowv2aTSWPcg+5SQxUMGVt Ndhw== X-Gm-Message-State: AOAM5330OscobTTVuZ/LhRfGO3XwKwfJNAPkyElp8KrRXc1iIk9wj8ur TgVJdSr9rCPPWYR8FN3P0v5UMA== X-Google-Smtp-Source: ABdhPJzK9FbrQ+L6WETEz5Zs6aYYBGgKOhOzatOgaMiCxJy5rQAIxQS9fC5rZd0K9XJbOp53GVI/5g== X-Received: by 2002:a05:600c:1e85:b0:38c:ef05:ba5d with SMTP id be5-20020a05600c1e8500b0038cef05ba5dmr8462294wmb.119.1648816183627; Fri, 01 Apr 2022 05:29:43 -0700 (PDT) Received: from [192.168.86.34] (cpc90716-aztw32-2-0-cust825.18-1.cable.virginm.net. [86.26.103.58]) by smtp.googlemail.com with ESMTPSA id v13-20020adfe28d000000b0020375f27a5asm2036360wri.4.2022.04.01.05.29.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 05:29:43 -0700 (PDT) Message-ID: <9fd2c36d-0ac2-357e-23da-9d20397dbb67@linaro.org> Date: Fri, 1 Apr 2022 13:29:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RESEND2] net: stmmac: Fix unset max_speed difference between DT and non-DT platforms Content-Language: en-US To: Chen-Yu Tsai , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King References: <20220331184832.16316-1-wens@kernel.org> From: Srinivas Kandagatla In-Reply-To: <20220331184832.16316-1-wens@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_052946_186364_0DC415E5 X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/03/2022 19:48, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > In commit 9cbadf094d9d ("net: stmmac: support max-speed device tree > property"), when DT platforms don't set "max-speed", max_speed is set to > -1; for non-DT platforms, it stays the default 0. > > Prior to commit eeef2f6b9f6e ("net: stmmac: Start adding phylink support"), > the check for a valid max_speed setting was to check if it was greater > than zero. This commit got it right, but subsequent patches just checked > for non-zero, which is incorrect for DT platforms. > > In commit 92c3807b9ac3 ("net: stmmac: convert to phylink_get_linkmodes()") > the conversion switched completely to checking for non-zero value as a > valid value, which caused 1000base-T to stop getting advertised by > default. > > Instead of trying to fix all the checks, simply leave max_speed alone if > DT property parsing fails. > > Fixes: 9cbadf094d9d ("net: stmmac: support max-speed device tree property") > Fixes: 92c3807b9ac3 ("net: stmmac: convert to phylink_get_linkmodes()") > Signed-off-by: Chen-Yu Tsai > Acked-by: Russell King (Oracle) > --- LGTM, Reviewed-by: Srinivas Kandagatla --srini > > Resend2: CC Srinivas at Linaro instead of ST. Collected Russell's ack. > Resend: added Srinivas (author of first fixed commit) to CC list. > > This was first noticed on ROC-RK3399-PC, and also observed on ROC-RK3328-CC. > The fix was tested on ROC-RK3328-CC and Libre Computer ALL-H5-ALL-CC. > > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 5d29f336315b..11e1055e8260 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -431,8 +431,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > plat->phylink_node = np; > > /* Get max speed of operation from device tree */ > - if (of_property_read_u32(np, "max-speed", &plat->max_speed)) > - plat->max_speed = -1; > + of_property_read_u32(np, "max-speed", &plat->max_speed); > > plat->bus_id = of_alias_get_id(np, "ethernet"); > if (plat->bus_id < 0) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel